From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 7A5963858C33 for ; Fri, 19 Jan 2024 07:09:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A5963858C33 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A5963858C33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705648168; cv=none; b=DeuBK0OnXC8W4nZjh0bUM4miAnDy/kYJ0RZc6p9yUgg3nwZvOUm9ETu2JiARc5vG8T79LNXaiPx+y6jhODCWYDAbLURJaIzS4bd5AZHlNJLZxOivQArIzeHiL9P+PUt8amBlJIuBuJX9rD5zB7P6SHTK8PI625RZRu95fDCVhYs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705648168; c=relaxed/simple; bh=/nHQM7JOuhdtWyXS3WGVkJ/XFXcxHmECeGlEE9lQVkk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=EAcz7F1h4lEsWfGWNgsUXPf9obbTRWfGpNoSay0sFfP6Ywxi39IT97vDEmIBEQDz21WSbhbvR5qIKpTwThxqmCPoOW0PwX2UUTQs5se/ysR50WodZAk2vngcrS2+mmLFbThTROD+barjruREwCI2JnDulM/YACvMk9UAf08g/+k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6d9af1f52bcso362472b3a.3 for ; Thu, 18 Jan 2024 23:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1705648165; x=1706252965; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HJc7iexsSe6TOKK97+WhKk5hS/LuC43KtQ6kARSS2XY=; b=a4pgUYSvKxWK2074LTWiLcJn1nbZdDqRHfq0kD0JPSMg7lcwxGMDmet6LxCiVCkKZB cjNANxZqJmLPLuZ0BLJBXfSM6eCYYhGsHEVwbnSSq7VfxQee4tyWyFAGjCIuhGmoSb9e XIz36EycNdDbEJl8CpTHi4vIeY857igdtzSTrk4sXK7pDt27GcZw9cFNrhyA6gJjwJDK YG/SPK4XTW6i/FjSdB+cUA/RKrgpgp1zJL09ZGJz/CQ5BoEiScilxYsk61vWePHfKa4+ ii1BSgYXGRNG9ymZgGVQegU7CwgD+i7/tdleQgaXxF5NB0xAtKROmF/iQFyuc8uJZcZI 8ZOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705648165; x=1706252965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HJc7iexsSe6TOKK97+WhKk5hS/LuC43KtQ6kARSS2XY=; b=Vt0T7coqQIzZFtL3JVUt/jX7I0oZnQr+agGvw0G/qRPsyS8wm8pJCiw8es27xpMsE4 02GI4+9deZuKn8uwQODfGBih6+eWj7RvV7tk+i6oiLZ/sdBfS76cRsSX1/DO2lfpMgbZ qI58OQMmU3UpmM8eNzsLemSRJVRI2tOx71P7NZHrIaMn8l2kDGxcojisE9wLcVzOZBFc 7BDgpDZDl2DGR86saPBMrPXftQw6DAQHm3hpuFLh77c+05yp6D7zOOOwgTH3HYT5kEjj eWp/Rh7OliSZSEvo+gD+7D1ohs+F0cIQwq+nuOgjedMJiPGbhNn4ndZRMUfx/EY+G4wV xLuQ== X-Gm-Message-State: AOJu0YwQ3KQ43F8lxiBdUUL8T9JW4zBb0iYH26pnK84jR0Lv5z0mJWJt PBpFpeDK4/iGfXh0ykap+hbr++7cdAojA51YQbZoyc48DK38uDUlWHCvWSoo++dRAUm8OntZicB 4wzdw+chSmDh8LyjRfyCh1l6P3035Eir2+uR2OA== X-Google-Smtp-Source: AGHT+IHXkHdGAqjjbM8ntra8/2c4PNRr7Wdqu/b0Cij/nlBFPMNo3LqovYIeCosATtj2qm6K2hwrxbXwxu3nJK42MGM= X-Received: by 2002:a05:6a20:2d91:b0:197:1e78:8a79 with SMTP id bf17-20020a056a202d9100b001971e788a79mr1648953pzb.50.1705648165471; Thu, 18 Jan 2024 23:09:25 -0800 (PST) MIME-Version: 1.0 References: <20240119070540.95115-1-monk.chiang@sifive.com> In-Reply-To: <20240119070540.95115-1-monk.chiang@sifive.com> From: Kito Cheng Date: Fri, 19 Jan 2024 15:09:14 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add split pattern to generate SFB instructions. [PR113095] To: Monk Chiang Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de, apinski@marvell.com, jeffreyalaw@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks! generally LGTM, but I would wait one more week to see any other comments :) On Fri, Jan 19, 2024 at 3:05=E2=80=AFPM Monk Chiang wrote: > > Since the match.pd transforms (zero_one =3D=3D 0) ? y : z y, > into ((typeof(y))zero_one * z) y. Add splitters to recongize > this expression to generate SFB instructions. > > gcc/ChangeLog: > PR target/113095 > * config/riscv/sfb.md: New splitters to rewrite single bit > sign extension as the condition to SFB instructions. > > gcc/testsuite/ChangeLog: > * gcc.target/riscv/sfb.c: New test. > --- > gcc/config/riscv/sfb.md | 32 ++++++++++++++++++++++++++++ > gcc/testsuite/gcc.target/riscv/sfb.c | 24 +++++++++++++++++++++ > 2 files changed, 56 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/riscv/sfb.c > > diff --git a/gcc/config/riscv/sfb.md b/gcc/config/riscv/sfb.md > index 8ab747142c8..520b12c22f9 100644 > --- a/gcc/config/riscv/sfb.md > +++ b/gcc/config/riscv/sfb.md > @@ -35,3 +35,35 @@ > [(set_attr "length" "8") > (set_attr "type" "sfb_alu") > (set_attr "mode" "")]) > + > +;; Combine creates this form ((typeof(y))zero_one * z) y > +;; for SiFive short forward branches. > + > +(define_split > + [(set (match_operand:X 0 "register_operand") > + (and:X (sign_extract:X (match_operand:X 1 "register_operand") > + (const_int 1) > + (match_operand 2 "immediate_operand")) > + (match_operand:X 3 "register_operand"))) > + (clobber (match_operand:X 4 "register_operand"))] > + "TARGET_SFB_ALU" > + [(set (match_dup 4) (zero_extract:X (match_dup 1) (const_int 1) (match= _dup 2))) > + (set (match_dup 0) (if_then_else:X (ne:X (match_dup 4) (const_int 0)) > + (match_dup 3) > + (const_int 0)))]) > + > +(define_split > + [(set (match_operand:X 0 "register_operand") > + (and:X (sign_extract:X (match_operand:X 1 "register_operand") > + (const_int 1) > + (match_operand 2 "immediate_operand")) > + (match_operand:X 3 "register_operand"))) > + (clobber (match_operand:X 4 "register_operand"))] > + "TARGET_SFB_ALU && (UINTVAL (operands[2]) < 11)" > + [(set (match_dup 4) (and:X (match_dup 1) (match_dup 2))) > + (set (match_dup 0) (if_then_else:X (ne:X (match_dup 4) (const_int 0)) > + (match_dup 3) > + (const_int 0)))] > +{ > + operands[2] =3D GEN_INT (1 << UINTVAL(operands[2])); > +}) > diff --git a/gcc/testsuite/gcc.target/riscv/sfb.c b/gcc/testsuite/gcc.tar= get/riscv/sfb.c > new file mode 100644 > index 00000000000..22f164051f4 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/riscv/sfb.c > @@ -0,0 +1,24 @@ > +//* { dg-do compile } */ > +/* { dg-options "-O2 -march=3Drv32gc -mabi=3Dilp32d -mtune=3Dsifive-7-se= ries" } */ > + > +int f1(unsigned int x, unsigned int y, unsigned int z) > +{ > + return ((x & 1) =3D=3D 0) ? y : z ^ y; > +} > + > +int f2(unsigned int x, unsigned int y, unsigned int z) > +{ > + return ((x & 1) !=3D 0) ? z ^ y : y; > +} > + > +int f3(unsigned int x, unsigned int y, unsigned int z) > +{ > + return ((x & 1) =3D=3D 0) ? y : z | y; > +} > + > +int f4(unsigned int x, unsigned int y, unsigned int z) > +{ > + return ((x & 1) !=3D 0) ? z | y : y; > +} > +/* { dg-final { scan-assembler-times "bne" 4 } } */ > +/* { dg-final { scan-assembler-times "movcc" 4 } } */ > -- > 2.40.1 >