From: Kito Cheng <kito.cheng@sifive.com>
To: Robin Dapp <rdapp.gcc@gmail.com>
Cc: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
gcc-patches <gcc-patches@gcc.gnu.org>,
palmer <palmer@rivosinc.com>,
jeffreyalaw <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] RISC-V: Support TARGET_VECTORIZE_PREFERRED_VECTOR_ALIGNMENT to optimize codegen of RVV auto-vectorization
Date: Mon, 15 May 2023 16:02:40 +0800 [thread overview]
Message-ID: <CALLt3TjKaaAXhp0zkEG+M5cX0r1MjRTkdnU1TwLSAjJcq5uUkQ@mail.gmail.com> (raw)
In-Reply-To: <bfb29e33-f395-c331-a338-9c4ed6e153cf@gmail.com>
> we need to discern what we want to achieve here. The goal might
> be to prevent the vectorizer from performing peeling or versioning
> for alignment. I realize the peeling code looks ugly but it's
> actually for a good cause when the target does not support
> misaligned vector access or only with severe penalty.
Vector spec says it should support element alignment, so my
understanding is default behavior should be just aligned to
vector-spec said :)
I guess Ju-Zhe might have different thoughts on that, we might need
some more comment from him.
> So I'd much rather prefer that over the current approach as it
> is more localized and will need an mtune-related approach later
> anyway.
I know there is some HW implementation that might be faster if the
address is aligned to 128 bit or 256 bit, and some HW implementation
might only get a few penalties from the first iteration if not aligned
to some alignment.
Anyway those are all mtune-related, so I guess eventually both
riscv_builtin_vectorization_cost and
riscv_vectorize_preferred_vector_alignment should get info from mtune.
>
> Regards
> Robin
next prev parent reply other threads:[~2023-05-15 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 11:44 juzhe.zhong
2023-05-15 0:35 ` juzhe.zhong
2023-05-15 2:38 ` Kito Cheng
2023-05-15 2:47 ` juzhe.zhong
2023-05-15 2:56 ` Kito Cheng
2023-05-15 3:17 ` juzhe.zhong
2023-05-15 7:19 ` Robin Dapp
2023-05-15 8:02 ` Kito Cheng [this message]
2023-05-15 8:10 ` juzhe.zhong
2023-05-15 8:58 ` Robin Dapp
2023-05-15 10:32 ` juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALLt3TjKaaAXhp0zkEG+M5cX0r1MjRTkdnU1TwLSAjJcq5uUkQ@mail.gmail.com \
--to=kito.cheng@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=palmer@rivosinc.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).