From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 066B83858D20 for ; Mon, 12 Jun 2023 14:55:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 066B83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-53f04fdd77dso1850382a12.3 for ; Mon, 12 Jun 2023 07:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1686581710; x=1689173710; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8yUnLiewDKz/KL50bzRdZN5ZNAhXFG3IQOwKScis9uw=; b=IWus3CFkgV/UY695qZcv+bnqxsxw6IUvWiTx9Zi3vz5b6eZR7upK85FyuFWa+MuRZ9 jJ6aLB/kBP5ZRJnjo+TdiJHOWWAjgkTU5l5v5cifKGR9TbA7Am/Cyix9wHurV3TM2xXW 6J/n/+YzO8/q0s1dZ4unmfVMi1rH/xNQ39OqH1timhHzacOC5Q+vbTiVxm5FaEVpPI5n KrSkBs8ISD3AGlvmbNdPd4quAEYAT2T7qxve5llsfBGxw2VRPrJ3AJe7lLA2Molv4Ply dTIlaw/VrC5rwK8TrHpIyiPOUnpAlGuK4pkhnR07s7Oc0v8pTLvIAWgN2fLsLGF/Rr1I Rpfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686581710; x=1689173710; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8yUnLiewDKz/KL50bzRdZN5ZNAhXFG3IQOwKScis9uw=; b=VHPv98D1Ftq0ot0PHqyyfjPki7FkQkFWvi+hYGOF3aT0yHwp/8Q5tdufMRye2ZQ8l4 Qf3jMZGHQykMbScyIq9Fnw3N/sirpVCa00xmBFdhEtiighFrQO+lzE8iD3s3tLqtaS1i OIUdEPzNzNcXaQ3UYy1nt7KmaHUeB2+WD7HUFvMB720xHw4Q/V/PuMwtJVl16M3u/pL8 kHW8CVMC68GYBw5FtH8y8bJG4CSAO6xHxXbVS1qgBvA9qlBztJY97npIrB4y6iM1MPJJ qmBD/AuWR+onGVSYhXNAYwWUGM5AOlfkj9TCBiM5Vu/dNt44XN83NqdmA9PS3mVzxFBe dE9g== X-Gm-Message-State: AC+VfDwx/qa+OPfnX3hn/IqObAQXjz826BW+Vi5lghsbcqb7i4UroFy3 q5VAd2ORbMsQroKQtoM59AMmXEeqq95BMvbWIoiPzw== X-Google-Smtp-Source: ACHHUZ46rV3jW9HQAjTfVkx19EjGus8O5mzKyA9pk6APEUsSZWouSCL5NyuH5tezsn4GSAKwKdRn33Y69A3uVs/OS7k= X-Received: by 2002:a17:90a:42:b0:25b:c9ff:630b with SMTP id 2-20020a17090a004200b0025bc9ff630bmr4888890pjb.23.1686581709909; Mon, 12 Jun 2023 07:55:09 -0700 (PDT) MIME-Version: 1.0 References: <20230612132901.1727002-1-juzhe.zhong@rivai.ai> In-Reply-To: From: Kito Cheng Date: Mon, 12 Jun 2023 22:54:58 +0800 Message-ID: Subject: Re: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with decompress operation To: =?UTF-8?B?6ZKf5bGF5ZOy?= Cc: "rdapp.gcc" , gcc-patches , "kito.cheng" , palmer , palmer , Jeff Law Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I didn't take a close review yet, (and I suspect I can't find time before I start my vacation :P), but I am thinking we may adding selftests for expand_const_vector in *future*, again, not blocker for this patch :) On Mon, Jun 12, 2023 at 10:51=E2=80=AFPM =E9=92=9F=E5=B1=85=E5=93=B2 wrote: > > No. Such pattern you pointed I already supported. > The operation is very simple. > Just use a single vmv.v.i but larger SEW is enough. No need vzext. > > ________________________________ > juzhe.zhong@rivai.ai > > > From: Robin Dapp > Date: 2023-06-12 22:43 > To: juzhe.zhong; gcc-patches > CC: rdapp.gcc; kito.cheng; kito.cheng; palmer; palmer; jeffreyalaw > Subject: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization with = decompress operation > Hi Juzhe, > > seems a nice improvement, looks good to me. While reading I was wonderin= g > if vzext could help synthesize some (zero-based) patterns as well > (e.g. 0 3 0 3...). > However the sequences I could come up with were not shorter than what we > are already emitting, so probably not. > > Regards > Robin >