public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kevin Lee <kevinl@rivosinc.com>
To: Xi Ruoyao <xry111@xry111.site>
Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com,
	kito.cheng@gmail.com,  gnu-toolchain@rivosinc.com
Subject: Re: [PATCH v2] RISC-V missing __builtin_lceil and __builtin_lfloor
Date: Fri, 11 Nov 2022 10:55:15 -0800	[thread overview]
Message-ID: <CALkvSf9mHQHDfFqmtW_KD7kJed4S4KM0ds_kKgY8QqYff5F4EA@mail.gmail.com> (raw)
In-Reply-To: <969e3de24c8e674ad93854252e77e1906cde420e.camel@xry111.site>

On Wed, Nov 9, 2022 at 1:49 AM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Mon, 2022-11-07 at 20:36 -0800, Kevin Lee wrote:
> I "shamelessly copied" your idea in
> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605456.html.
> During the review we found an issue.
>

> -fno-fp-int-builtin-inexact does not allow __builtin_ceil to raise
> inexact exception.  But fcvt.l.d may raise one.

Your solution of activating only for the fp-int-builtin-inexact seems
to be a good way to handle the issue. Thank you for the example. I'll
create a new patch based on the fix.

> --
> Xi Ruoyao <xry111@xry111.site>
> School of Aerospace Science and Technology, Xidian University

      reply	other threads:[~2022-11-11 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  4:36 Kevin Lee
2022-11-09  9:48 ` Xi Ruoyao
2022-11-11 18:55   ` Kevin Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALkvSf9mHQHDfFqmtW_KD7kJed4S4KM0ds_kKgY8QqYff5F4EA@mail.gmail.com \
    --to=kevinl@rivosinc.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gnu-toolchain@rivosinc.com \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).