From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 9EFE83858C60 for ; Fri, 11 Nov 2022 18:55:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9EFE83858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-lf1-x135.google.com with SMTP id g12so9617698lfh.3 for ; Fri, 11 Nov 2022 10:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2M7O8pO3VM26lCoGEd6KRDrH+sZGlr0PDk+hmgA5ywM=; b=hYmnkOfuA+VXb4Qe9YdmDh9GK7JNTcKeNYGlKnbDmKN+PyE60oraMVWitMRNKLtUbY 0Da+QSLZWoxogcDFeaO9YlmEbAqCfcWvo/5WDRFIou0FrOtLwu39uIGhNFgooHNFKuNX 1aCOxHZwrJJR/UZWLtpiIPdAzh+hprPWDNAJWhW7FrsaO4e+M4XOkzUcZVCf/Q9Gjliz 7ntpMeBHIgMVUknLp4boXTrcaW5Bw+47TzWcXQM3oveFsEV4i1vfL9nBMQ+oUCfe52dB av91N3DIG0sUxr+x83At6kC6PD7uyRAQiEQ9pb77UInTSPSoSAzwZRiYHG9o/WTsJd7z qKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2M7O8pO3VM26lCoGEd6KRDrH+sZGlr0PDk+hmgA5ywM=; b=T3Csdi161HQOy5Rh077AxuKr1t5hZu6IO10X9CwtK1253iL12Khdx2giXmES2L98QR feYMYqy6+WILIpQIHcFBFi8953lg42CQslsxgYp+ZWcM0mh8jvh0bFYB85nqQi2rnWS/ ZCwThA0y4LB0Gb1x/a4j6iw+JFPuifMfK/6++S09vqG4SFcI95vMQBacyNRa6gVgblH+ gxwxjetkhh2RbxpKG9hEmEqUpY5Tcw4J1NOq+S69M+yoJ6o0a5T5yY8gexdA3HkO1Rcp 2SbRuhlxkbLoRKEUhtC4vja0UmO9yteNnQWWRcJ3UnzBkk+1Eou0dPnrK5h4IVrvF695 3YUA== X-Gm-Message-State: ANoB5pnL2Pyox8lhSxbk2PFpmNS8Xaims+KC2Yv3kj9ZuNjh2OO87m7N cPjS6w2PvV0sU2DDFY6D2wWOqM7NTDSBjowFb9ZeVd+3bpM= X-Google-Smtp-Source: AA0mqf4ONCujl0+adUt+ghY4GJX4/pTYzzJGv0ZatgOWyD0CDFN9JtAPe61+lrROsZH7/wbAoWEpDnx71tPE6H5Sr7g= X-Received: by 2002:ac2:51ad:0:b0:4a2:6e2e:2d17 with SMTP id f13-20020ac251ad000000b004a26e2e2d17mr1153771lfk.339.1668192926279; Fri, 11 Nov 2022 10:55:26 -0800 (PST) MIME-Version: 1.0 References: <20221108043657.2064455-1-kevinl@rivosinc.com> <969e3de24c8e674ad93854252e77e1906cde420e.camel@xry111.site> In-Reply-To: <969e3de24c8e674ad93854252e77e1906cde420e.camel@xry111.site> From: Kevin Lee Date: Fri, 11 Nov 2022 10:55:15 -0800 Message-ID: Subject: Re: [PATCH v2] RISC-V missing __builtin_lceil and __builtin_lfloor To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, kito.cheng@gmail.com, gnu-toolchain@rivosinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 9, 2022 at 1:49 AM Xi Ruoyao wrote: > > On Mon, 2022-11-07 at 20:36 -0800, Kevin Lee wrote: > I "shamelessly copied" your idea in > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605456.html. > During the review we found an issue. > > -fno-fp-int-builtin-inexact does not allow __builtin_ceil to raise > inexact exception. But fcvt.l.d may raise one. Your solution of activating only for the fp-int-builtin-inexact seems to be a good way to handle the issue. Thank you for the example. I'll create a new patch based on the fix. > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University