From: Kevin Lee <kevinl@rivosinc.com>
To: Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org>,
Kevin Lee <kevinl@rivosinc.com>,
Richard Biener <richard.guenther@gmail.com>,
collison@rivosinc.com, richard.sandiford@arm.com
Subject: Re: [PATCH v2][RFC] vect: Verify that GET_MODE_NUNITS is greater than one for vect_grouped_store_supported
Date: Wed, 12 Apr 2023 08:11:08 -0700 [thread overview]
Message-ID: <CALkvSf_bvuaFZG63kNQMTGvFx+ki6ih1h56=uUuVxP0hcL8_ow@mail.gmail.com> (raw)
In-Reply-To: <mptfs96lonb.fsf@arm.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
Thank you for the feedback Richard and Richard.
> Note the calls are guarded with
>
> && ! known_eq (TYPE_VECTOR_SUBPARTS (vectype), 1U)
Yes, I believe nelt.is_constant() wouldn't be necessary. I didn't realize
the call was guarded by this condition.
> But I think the better check for location above is:
>
> if (!multiple_p (nelt, 2))
> return false;
>
> which then guards the assert in the later exact_div (nelt, 2).
I believe this check is better than using maybe_lt because it properly
guards exact_div(nelt, 2) and vec_perm_builder sel(nelt, 2, 3).
I'll modify the patch accordingly, build, test and submit the patch. Thank
you!!
Sincerely,
next prev parent reply other threads:[~2023-04-12 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:01 Kevin Lee
2023-04-11 9:32 ` Richard Biener
2023-04-11 10:05 ` Richard Sandiford
2023-04-12 15:11 ` Kevin Lee [this message]
2023-04-17 16:38 ` [PATCH v3] vect: Verify that GET_MODE_UNITS " Kevin Lee
2023-04-18 6:08 ` Richard Biener
2023-04-18 18:43 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALkvSf_bvuaFZG63kNQMTGvFx+ki6ih1h56=uUuVxP0hcL8_ow@mail.gmail.com' \
--to=kevinl@rivosinc.com \
--cc=collison@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).