I updated the patch with a comment. Actually, Manuel handed me this patch just to help me get familiar with the process of submitting and testing. Generating this one with git diff looks different so I'm not sure if that's a problem or not. Thanks, Anthony On Sun, Oct 12, 2014 at 10:09 PM, wrote: > > > > >> On Oct 12, 2014, at 12:37 PM, Anthony Brandon wrote: >> >> Hi, >> >> I'm a new contributor and I don't yet have a copyright assignment or >> commit access. > > > Thanks for you contribution. Your new function is missing a comment before it saying what it does. Yes it might be obvious what the function does but the coding style requires it. > > Thanks, > Andrew > >> >> This is a cleanup of code duplication in c-parser. >> I bootstrapped and tested on x86_64-linux. >> >> >> gcc/c/ChangeLog: >> >> 2014-10-12 Anthony Brandon >> >> * c-parser.c (c_parser_all_labels): New function to replace >> the duplicate code. >> (c_parser_statement): Call the new function. >> -- Anthony