From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11506 invoked by alias); 13 Oct 2014 11:12:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11486 invoked by uid 89); 13 Oct 2014 11:12:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-qa0-f48.google.com Received: from mail-qa0-f48.google.com (HELO mail-qa0-f48.google.com) (209.85.216.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 13 Oct 2014 11:11:59 +0000 Received: by mail-qa0-f48.google.com with SMTP id dc16so4215728qab.21 for ; Mon, 13 Oct 2014 04:11:56 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.44.6 with SMTP id f6mr37324166qga.93.1413198716758; Mon, 13 Oct 2014 04:11:56 -0700 (PDT) Received: by 10.140.95.193 with HTTP; Mon, 13 Oct 2014 04:11:56 -0700 (PDT) In-Reply-To: <044D8CC4-A3A3-4B5A-9D9A-FB01FB845131@gmail.com> References: <044D8CC4-A3A3-4B5A-9D9A-FB01FB845131@gmail.com> Date: Mon, 13 Oct 2014 11:21:00 -0000 Message-ID: Subject: Re: [PATCH] cleanup in c-parser From: Anthony Brandon To: pinskia@gmail.com Cc: "gcc-patches@gcc.gnu.org" , "manu@gcc.gnu.org" , "joseph@codesourcery.com" Content-Type: multipart/mixed; boundary=001a113a9cd0828f8a05054bf765 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01111.txt.bz2 --001a113a9cd0828f8a05054bf765 Content-Type: text/plain; charset=UTF-8 Content-length: 1102 I updated the patch with a comment. Actually, Manuel handed me this patch just to help me get familiar with the process of submitting and testing. Generating this one with git diff looks different so I'm not sure if that's a problem or not. Thanks, Anthony On Sun, Oct 12, 2014 at 10:09 PM, wrote: > > > > >> On Oct 12, 2014, at 12:37 PM, Anthony Brandon wrote: >> >> Hi, >> >> I'm a new contributor and I don't yet have a copyright assignment or >> commit access. > > > Thanks for you contribution. Your new function is missing a comment before it saying what it does. Yes it might be obvious what the function does but the coding style requires it. > > Thanks, > Andrew > >> >> This is a cleanup of code duplication in c-parser. >> I bootstrapped and tested on x86_64-linux. >> >> >> gcc/c/ChangeLog: >> >> 2014-10-12 Anthony Brandon >> >> * c-parser.c (c_parser_all_labels): New function to replace >> the duplicate code. >> (c_parser_statement): Call the new function. >> -- Anthony --001a113a9cd0828f8a05054bf765 Content-Type: text/plain; charset=US-ASCII; name="cleanup-2.diff" Content-Disposition: attachment; filename="cleanup-2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i17pqtls0 Content-length: 3197 ZGlmZiAtLWdpdCBhL2djYy9jL2MtcGFyc2VyLmMgYi9nY2MvYy9jLXBhcnNl ci5jCmluZGV4IDBkMTU5ZmQuLjM0NjQ0OGEgMTAwNjQ0Ci0tLSBhL2djYy9j L2MtcGFyc2VyLmMKKysrIGIvZ2NjL2MvYy1wYXJzZXIuYwpAQCAtNDY1NCw2 ICs0NjU0LDE4IEBAIGNfcGFyc2VyX2NvbXBvdW5kX3N0YXRlbWVudF9ub3N0 YXJ0IChjX3BhcnNlciAqcGFyc2VyKQogICBtYXJrX3ZhbGlkX2xvY2F0aW9u X2Zvcl9zdGRjX3ByYWdtYSAoc2F2ZV92YWxpZF9mb3JfcHJhZ21hKTsKIH0K IAorLyogUGFyc2UgYWxsIGNvbnNlY3V0aXZlIGxhYmVscy4gKi8KKworc3Rh dGljIHZvaWQKK2NfcGFyc2VyX2FsbF9sYWJlbHMgKGNfcGFyc2VyICpwYXJz ZXIpCit7CisgIHdoaWxlIChjX3BhcnNlcl9uZXh0X3Rva2VuX2lzX2tleXdv cmQgKHBhcnNlciwgUklEX0NBU0UpCisJIHx8IGNfcGFyc2VyX25leHRfdG9r ZW5faXNfa2V5d29yZCAocGFyc2VyLCBSSURfREVGQVVMVCkKKwkgfHwgKGNf cGFyc2VyX25leHRfdG9rZW5faXMgKHBhcnNlciwgQ1BQX05BTUUpCisJICAg ICAmJiBjX3BhcnNlcl9wZWVrXzJuZF90b2tlbiAocGFyc2VyKS0+dHlwZSA9 PSBDUFBfQ09MT04pKQorICAgIGNfcGFyc2VyX2xhYmVsIChwYXJzZXIpOwor fQorCiAvKiBQYXJzZSBhIGxhYmVsIChDOTAgNi42LjEsIEM5OSA2LjguMSku CiAKICAgIGxhYmVsOgpAQCAtNDg1NCwxMSArNDg2Niw3IEBAIGNfcGFyc2Vy X2xhYmVsIChjX3BhcnNlciAqcGFyc2VyKQogc3RhdGljIHZvaWQKIGNfcGFy c2VyX3N0YXRlbWVudCAoY19wYXJzZXIgKnBhcnNlcikKIHsKLSAgd2hpbGUg KGNfcGFyc2VyX25leHRfdG9rZW5faXNfa2V5d29yZCAocGFyc2VyLCBSSURf Q0FTRSkKLQkgfHwgY19wYXJzZXJfbmV4dF90b2tlbl9pc19rZXl3b3JkIChw YXJzZXIsIFJJRF9ERUZBVUxUKQotCSB8fCAoY19wYXJzZXJfbmV4dF90b2tl bl9pcyAocGFyc2VyLCBDUFBfTkFNRSkKLQkgICAgICYmIGNfcGFyc2VyX3Bl ZWtfMm5kX3Rva2VuIChwYXJzZXIpLT50eXBlID09IENQUF9DT0xPTikpCi0g ICAgY19wYXJzZXJfbGFiZWwgKHBhcnNlcik7CisgIGNfcGFyc2VyX2FsbF9s YWJlbHMgKHBhcnNlcik7CiAgIGNfcGFyc2VyX3N0YXRlbWVudF9hZnRlcl9s YWJlbHMgKHBhcnNlcik7CiB9CiAKQEAgLTUwOTAsMTEgKzUwOTgsNyBAQCBj X3BhcnNlcl9pZl9ib2R5IChjX3BhcnNlciAqcGFyc2VyLCBib29sICppZl9w KQogewogICB0cmVlIGJsb2NrID0gY19iZWdpbl9jb21wb3VuZF9zdG10IChm bGFnX2lzb2M5OSk7CiAgIGxvY2F0aW9uX3QgYm9keV9sb2MgPSBjX3BhcnNl cl9wZWVrX3Rva2VuIChwYXJzZXIpLT5sb2NhdGlvbjsKLSAgd2hpbGUgKGNf cGFyc2VyX25leHRfdG9rZW5faXNfa2V5d29yZCAocGFyc2VyLCBSSURfQ0FT RSkKLQkgfHwgY19wYXJzZXJfbmV4dF90b2tlbl9pc19rZXl3b3JkIChwYXJz ZXIsIFJJRF9ERUZBVUxUKQotCSB8fCAoY19wYXJzZXJfbmV4dF90b2tlbl9p cyAocGFyc2VyLCBDUFBfTkFNRSkKLQkgICAgICYmIGNfcGFyc2VyX3BlZWtf Mm5kX3Rva2VuIChwYXJzZXIpLT50eXBlID09IENQUF9DT0xPTikpCi0gICAg Y19wYXJzZXJfbGFiZWwgKHBhcnNlcik7CisgIGNfcGFyc2VyX2FsbF9sYWJl bHMgKHBhcnNlcik7CiAgICppZl9wID0gY19wYXJzZXJfbmV4dF90b2tlbl9p c19rZXl3b3JkIChwYXJzZXIsIFJJRF9JRik7CiAgIGlmIChjX3BhcnNlcl9u ZXh0X3Rva2VuX2lzIChwYXJzZXIsIENQUF9TRU1JQ09MT04pKQogICAgIHsK QEAgLTUxMjEsMTEgKzUxMjUsNyBAQCBjX3BhcnNlcl9lbHNlX2JvZHkgKGNf cGFyc2VyICpwYXJzZXIpCiB7CiAgIGxvY2F0aW9uX3QgZWxzZV9sb2MgPSBj X3BhcnNlcl9wZWVrX3Rva2VuIChwYXJzZXIpLT5sb2NhdGlvbjsKICAgdHJl ZSBibG9jayA9IGNfYmVnaW5fY29tcG91bmRfc3RtdCAoZmxhZ19pc29jOTkp OwotICB3aGlsZSAoY19wYXJzZXJfbmV4dF90b2tlbl9pc19rZXl3b3JkIChw YXJzZXIsIFJJRF9DQVNFKQotCSB8fCBjX3BhcnNlcl9uZXh0X3Rva2VuX2lz X2tleXdvcmQgKHBhcnNlciwgUklEX0RFRkFVTFQpCi0JIHx8IChjX3BhcnNl cl9uZXh0X3Rva2VuX2lzIChwYXJzZXIsIENQUF9OQU1FKQotCSAgICAgJiYg Y19wYXJzZXJfcGVla18ybmRfdG9rZW4gKHBhcnNlciktPnR5cGUgPT0gQ1BQ X0NPTE9OKSkKLSAgICBjX3BhcnNlcl9sYWJlbCAocGFyc2VyKTsKKyAgY19w YXJzZXJfYWxsX2xhYmVscyAocGFyc2VyKTsKICAgaWYgKGNfcGFyc2VyX25l eHRfdG9rZW5faXMgKHBhcnNlciwgQ1BQX1NFTUlDT0xPTikpCiAgICAgewog ICAgICAgbG9jYXRpb25fdCBsb2MgPSBjX3BhcnNlcl9wZWVrX3Rva2VuIChw YXJzZXIpLT5sb2NhdGlvbjsK --001a113a9cd0828f8a05054bf765--