From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id B710A3858C66 for ; Mon, 13 Nov 2023 12:43:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B710A3858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B710A3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699879427; cv=none; b=Vcm5Ek6tHABKtNbRMOVJUJbchlgQJqN/CRx6tJrqQ6BCYEMTJQhCau0usPAQjYA2tSsmTBnC1i+10XIGAzKMsx+S2pARbqNCJr0N+rEYqWJg8x2yOTVkkrImZn/H8OOicM9GYdkbe0e+s0RfFk+JmTGlXfK0aCL/h1B7/aq7hXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699879427; c=relaxed/simple; bh=TYWhK/dqehC94u9ShXaRkz9hakY8f2rwjDWiogI5d7I=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ZjTQ4nuSEIQi4YnkEzAGi27ygfvGnacAbdIxglDpTIqg2A85F3gFe+k82uOp9vULDJTDIBB4g/z+pCq3Cn5QhTuuyRfpb2VY/sqkp32dXhFhhlXL+UB+l5dt8maMOvRgG4JJvQgLyQswd8b59lVP8kzNJI+6wNE/PkCrSxuz3RE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5c18a3387f5so372096a12.1 for ; Mon, 13 Nov 2023 04:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1699879426; x=1700484226; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fDRDoJFKPIRBbhKo3WYfRUu53ljUL7IMaqBLW82+ugY=; b=NxawoeVU4Dm3JCYFSamc1IPrNwn2BJfAhSSHJlwvafylclObtbS2BeeV6dyIhR/bnr LlnoIbc/yd8H2EIcyWDD5REDJ3dnT9Zglw01GFe8ixlwJY/Y3m3SFPKOoTh8hcd00V+R yJ/6Iktj2IPYaReCptua+ypsMGBhvjwlrvSHtREEKPEAkCNKao4Nzj6kSoSukiAVaixA MNk1vgJXfbFKz6ID1c5vUDp2yAE20zvhfIfnH7BvTVQByMRv46F2I37LsnCPR03BBdc/ wnBuuw8f4pagON6lMJBmJbG9twOWjeeSEmrglxx28aOe1FwSWRY+swP8YXUhcHCXdMrK 5CWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699879426; x=1700484226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fDRDoJFKPIRBbhKo3WYfRUu53ljUL7IMaqBLW82+ugY=; b=agseOX3IT6mleCwSwU4jq+NK3IBT8tWl1VoF+ATETmEJqYqvBe5SpYGEaOU5eVQ4XU uiuKk/HUfC8hZUMpmoVBtQSAH1qv/UQU2ddt7keHQISRJ7OL83KPb4iuQgTEMLHNbHye lUVXZdRqcj34JXNtL2pe1rhpKEgMEtR7RRbHwhIAjcoePLLYGyiZ3x2z03d/7Hb9qfMz ZQwzX1D82pcHdVOLXHDZKCO3jIU5CKuuqDKn6E1Huu98UUzsEGonydtYKRDnR2j3hmia V5Ki+waj49RqszK+8YA33rcKY9EgtyILbJ3TRMZrZYhUJMVVi7ApPwX1yDq5F8o+AAX1 VouA== X-Gm-Message-State: AOJu0YwtgD86T8w7XaverNHQcwpKKuXij1fZdc48/RysEXE3S1XH8kfQ K1GjjMJDTdFxG2Kcxkx/TIXWuQJHQdUbISAyucUcSA== X-Google-Smtp-Source: AGHT+IH1GwyBmoQwu2DUwVC82coLUStuiMfRpZu6e0qlvsDmK7HZdwz5a8SqHpYRvFi9h6hW+82P6kqylRO87v6iuDY= X-Received: by 2002:a17:90b:1e05:b0:27c:f1f8:2628 with SMTP id pg5-20020a17090b1e0500b0027cf1f82628mr4408720pjb.47.1699879425673; Mon, 13 Nov 2023 04:43:45 -0800 (PST) MIME-Version: 1.0 References: <20230830101400.1539313-1-manolis.tsamis@vrull.eu> <20230830101400.1539313-5-manolis.tsamis@vrull.eu> <977e60a7-4ed3-42d2-8f7e-9529d0b90eb0@gmail.com> In-Reply-To: <977e60a7-4ed3-42d2-8f7e-9529d0b90eb0@gmail.com> From: Manolis Tsamis Date: Mon, 13 Nov 2023 14:43:09 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] ifcvt: Remove obsolete code for subreg handling in noce_convert_multiple_sets To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek , Richard Sandiford Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Yes, my finding back then was that this is leftover code from the initial implementation, nothing to do with the rest of the changes. I will first re-evaluate this and test it separately from the other series. If all is good I'll let you know so we can proceed. Manolis On Sat, Nov 11, 2023 at 12:03=E2=80=AFAM Jeff Law w= rote: > > > > On 8/30/23 04:14, Manolis Tsamis wrote: > > This code used to handle register replacement issues with SUBREG before > > simplify_replace_rtx was introduced. This should not be needed anymore = as > > new_val has the correct mode and that should be preserved by > > simplify_replace_rtx. > > > > gcc/ChangeLog: > > > > * ifcvt.cc (noce_convert_multiple_sets_1): Remove old code. > So is it the case that this code is supposed to no longer be needed as a > result of your kit or it is unnecessary independent of patches 1..3? If > the latter then it's OK for the trunk now. > > Jeff