From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 942DD3858D35 for ; Tue, 21 Nov 2023 18:09:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 942DD3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 942DD3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700590161; cv=none; b=YxJRe2TeHOo2Wi1qjfRk2A4t8NeYqKVfNausAaPihcQ0U40o2cCkyhw2WME7CVAn5SWiWTS0V1htS5cE7Ol3SzkO3kGnq5VyZXZgH9T8BnfqP73OJUtRr8ooN7HVBd6gKIp85t0bU7MEeNVGJ1d4bBjzsxXTsCN1Nz373Zlijpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700590161; c=relaxed/simple; bh=F5a3i1DB/u6Yt5q/SLE1xWJKWX18NtIMZic0zBsLtoA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=FpwV+HuPKt8mO37lHMJcSyoybIrldjqvewL2rHyEgcLh6dhR+OpHycGSw9QLZm2TUk464nZf6uaXv5xZAJN+1nFuWuqDh2h+R1HZp/mvYbJeEMgJvs2qG2gumRrX0+ijVhe8DJUfCnuqTtKvq72Cjr/10u2i2P0MNRIIj5RCun8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6c396ef9a3dso4959474b3a.1 for ; Tue, 21 Nov 2023 10:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1700590159; x=1701194959; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gZyoCcoS80gtLt8pdxzY/209bM4+v4jRH2rbsTtCueY=; b=KmyRCzVU1xd4+V9nqCoFgG/rxk+W5gPoDOr/m9+JRUCJQUb12HkS7RKX4OSUnSyW0j d91m03917PPMPxcNPM3dq/EkAwLSzOlB8Qok5c1OvJrTObshZQl60V58kh9wDPGLyvg0 akvcnVSimwv9Ajg5LvtoULPgwanFOuQuAPRsV4pGCJufaKFof2jc/AJkiMvpkksP+y0J 89gj7RMyOPM4rk9uzMiOJeNRPv5REYTvjcx74htxx8Y4CgS1tiYBuPOviV029tWPZDsO Lx8DyeBxw5uq7AFEBkkH8wLsO/DFeA85AOwj2MbN5qs7faskauYAM8ZLDYOMSrxk4UDS 6yYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700590159; x=1701194959; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gZyoCcoS80gtLt8pdxzY/209bM4+v4jRH2rbsTtCueY=; b=xDq2TE+GMU8Ah32M4mtHZV9VRxim7GnNdO1SZs7rJsZjTQfN4ZkxwfSVi9yJHLMUIQ h4OcBvTvDHhUSItrbnI9C+h01cNNQ2jAN1hpCdcZrdLrqCssvQ5cDFgX6/mDCVlYgVTZ vQMwG23EDvYqm9Pog6onux+kjpa+1BrXjey3SNK/MZLuAhobO3CmZxR602iWj5hvoTbz oX6yq+3dEvkqkhWWEK1IHPyL6ClJXAQJWRWnhiawgd04tlHfiUxcw7VNo2MENMS3EkHi A133nnjiUntJ50gcrKKNZHEkDvnikqJ7bBuxRJ6HqJBsHxX0Z+Hg2xpmrVGScN3SzHZm peug== X-Gm-Message-State: AOJu0YyBsMFl/5C0WcBf17UHqwbK0778MHNV1/AMZ3kC25SMLMH8FeVh YmzwtSwnSHxMJmMhoE3pZ1O3fykAXE8PR5jnPk06QQ== X-Google-Smtp-Source: AGHT+IEqj/DFFvt6J7326O9NNe7MNG40oaXpzAGX1QLhHtLWtbtUl3QEJBMi48FYbej0dSkH/mpmlhzO467NFZk2sag= X-Received: by 2002:a05:6a20:da8a:b0:186:603b:6b4a with SMTP id iy10-20020a056a20da8a00b00186603b6b4amr12033421pzb.32.1700590159372; Tue, 21 Nov 2023 10:09:19 -0800 (PST) MIME-Version: 1.0 References: <20230830101400.1539313-1-manolis.tsamis@vrull.eu> <20230830101400.1539313-5-manolis.tsamis@vrull.eu> <977e60a7-4ed3-42d2-8f7e-9529d0b90eb0@gmail.com> In-Reply-To: From: Manolis Tsamis Date: Tue, 21 Nov 2023 20:08:43 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] ifcvt: Remove obsolete code for subreg handling in noce_convert_multiple_sets To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek , Richard Sandiford Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Retested, made independent of the rest of the series and submitted as https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637662.html. Manolis On Mon, Nov 13, 2023 at 2:43=E2=80=AFPM Manolis Tsamis wrote: > > Yes, my finding back then was that this is leftover code from the > initial implementation, nothing to do with the rest of the changes. > I will first re-evaluate this and test it separately from the other > series. If all is good I'll let you know so we can proceed. > > Manolis > > On Sat, Nov 11, 2023 at 12:03=E2=80=AFAM Jeff Law = wrote: > > > > > > > > On 8/30/23 04:14, Manolis Tsamis wrote: > > > This code used to handle register replacement issues with SUBREG befo= re > > > simplify_replace_rtx was introduced. This should not be needed anymor= e as > > > new_val has the correct mode and that should be preserved by > > > simplify_replace_rtx. > > > > > > gcc/ChangeLog: > > > > > > * ifcvt.cc (noce_convert_multiple_sets_1): Remove old code. > > So is it the case that this code is supposed to no longer be needed as = a > > result of your kit or it is unnecessary independent of patches 1..3? I= f > > the latter then it's OK for the trunk now. > > > > Jeff