From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 8AD95385781D for ; Fri, 26 Feb 2021 15:24:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8AD95385781D Received: by mail-ot1-x330.google.com with SMTP id g8so5711807otk.4 for ; Fri, 26 Feb 2021 07:24:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Md2FEYHVrBdBc7Foz4Obj1eVXPCH9PmgIeLT41cdit0=; b=RnkVm6WDOwOKZ5dp1ajsAK+p/A+6BF2ab386S7o9wY2AYlIswXzetz2LBClVFGHcjh k7tN52AoSQjMXd6mhIXztYZR9GToo4V7w9HAHOiFIvKajR7xx8UAEsbavBsyddEba4eB kH1FTPD7XYlcSwLO6LusxKBeFQMufy4K9TQCl13CS/dlYZSb1Sl11pjnCnDCoEwj44Ct UwsyotCT7WA5RBqgznD4L85WYTQJKi36sLDOEVfDI7XcayKXTP/htMC2AKIBUJDZL0DE CgQ9xh2rSPvHlONrFxR0ocLLN4StvNwTw3mHeoNXA2e9YTEd9Loa72sxzQ7kjWxNPzLS zj9A== X-Gm-Message-State: AOAM531Yt8yaAbNAVn02LQX0l3IE1wYDfSyLN1HhP12ixH6cJ/GMHThC sOuO80v2Mh9f7Vc6OUwUOIVagIJYj8sI5+s9YZ7AcNg5KaU= X-Google-Smtp-Source: ABdhPJzefLtelGOsdvz2xx0iEE0ZTBcxGfuMKJxUwW+pJX46aZRu/Hl7BUYhpV3ufRdE/2U3wAyFP2295QGKrI8oHb0= X-Received: by 2002:a9d:5d1a:: with SMTP id b26mr2686041oti.155.1614353098867; Fri, 26 Feb 2021 07:24:58 -0800 (PST) MIME-Version: 1.0 References: <20210205083527.GA6784@adacore.com> <20210205135925.GA5737@adacore.com> In-Reply-To: <20210205135925.GA5737@adacore.com> From: Mikael Pettersson Date: Fri, 26 Feb 2021 16:24:47 +0100 Message-ID: Subject: Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590) To: Arnaud Charlet Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 15:25:00 -0000 On Fri, Feb 5, 2021 at 2:59 PM Arnaud Charlet wrote: > > > > We'd rather not have PR references in the source files, so please remove it > > > (it will be there as part of the commit log and git annotate). > > > > > > OK with the comment updated. > > > > Thanks, here's the revised patch. > > OK, thanks. I forgot to mention that I don't have commit rights to gcc, so can someone please commit this for me? Thanks. > > > gcc/ada/ > > > > 2021-02-05 Mikael Pettersson > > > > PR bootstrap/98590 > > * cstreams.c: Ensure fileno_unlocked() is visible on Cygwin. > > > > diff --git a/gcc/ada/cstreams.c b/gcc/ada/cstreams.c > > index 4e00dedbbd6..7d64277110b 100644 > > --- a/gcc/ada/cstreams.c > > +++ b/gcc/ada/cstreams.c > > @@ -37,6 +37,11 @@ > > #define _FILE_OFFSET_BITS 64 > > /* the define above will make off_t a 64bit type on GNU/Linux */ > > > > +/* tell Cygwin's to expose fileno_unlocked() */ > > +#if defined(__CYGWIN__) && !defined(__CYGWIN32__) && !defined(_GNU_SOURCE) > > +#define _GNU_SOURCE > > +#endif > > + > > #include > > #include > > #include