* [Patch, microblaze]: Add -fstack-usage support
@ 2013-03-18 12:49 David Holsgrove
2013-07-15 4:50 ` David Holsgrove
2013-07-18 16:45 ` Michael Eager
0 siblings, 2 replies; 9+ messages in thread
From: David Holsgrove @ 2013-03-18 12:49 UTC (permalink / raw)
To: gcc-patches
Cc: Michael Eager, Edgar Iglesias, John Williams, Vinod Kathail,
Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
Changelog
2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
* gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
Add check for flag_stack_usage to handle -fstack-usage support
Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
[-- Attachment #2: 0004-Patch-microblaze-Add-fstack-usage-support.patch --]
[-- Type: application/octet-stream, Size: 1160 bytes --]
From 6b656bd0ec9ff26a01ababdabcec019768cbb5ef Mon Sep 17 00:00:00 2001
From: David Holsgrove <david.holsgrove@xilinx.com>
Date: Thu, 27 Sep 2012 17:08:20 +1000
Subject: [PATCH] [Patch, microblaze]: Add -fstack-usage support
Changelog
2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
* gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
Add check for flag_stack_usage to enable -fstack-usage support
Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
---
gcc/config/microblaze/microblaze.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/gcc/config/microblaze/microblaze.c b/gcc/config/microblaze/microblaze.c
index 7418e49..4417289 100644
--- a/gcc/config/microblaze/microblaze.c
+++ b/gcc/config/microblaze/microblaze.c
@@ -2790,6 +2790,9 @@ microblaze_expand_prologue (void)
fsiz = compute_frame_size (get_frame_size ());
+ if (flag_stack_usage)
+ current_function_static_stack_size = fsiz;
+
/* If this function is a varargs function, store any registers that
would normally hold arguments ($5 - $10) on the stack. */
if (((TYPE_ARG_TYPES (fntype) != 0
--
1.7.0.4
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Patch, microblaze]: Add -fstack-usage support
2013-03-18 12:49 [Patch, microblaze]: Add -fstack-usage support David Holsgrove
@ 2013-07-15 4:50 ` David Holsgrove
2013-07-20 8:20 ` Eric Botcazou
2013-07-18 16:45 ` Michael Eager
1 sibling, 1 reply; 9+ messages in thread
From: David Holsgrove @ 2013-07-15 4:50 UTC (permalink / raw)
To: gcc-patches
Cc: Michael Eager, Edgar Iglesias, John Williams, Vinod Kathail,
Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
Hi Michael,
On 18 March 2013 22:48, David Holsgrove <david.holsgrove@xilinx.com> wrote:
> Changelog
>
> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>
> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
> Add check for flag_stack_usage to handle -fstack-usage support
>
> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>
Patch remains the same, please apply when ready.
thanks,
David
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Patch, microblaze]: Add -fstack-usage support
2013-07-15 4:50 ` David Holsgrove
@ 2013-07-20 8:20 ` Eric Botcazou
2013-07-20 16:45 ` Chung-Ju Wu
0 siblings, 1 reply; 9+ messages in thread
From: Eric Botcazou @ 2013-07-20 8:20 UTC (permalink / raw)
To: gcc-patches
Cc: David Holsgrove, Michael Eager, Edgar Iglesias, John Williams,
Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
> > 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
> >
> > * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
> > Add check for flag_stack_usage to handle -fstack-usage support
> >
> > Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>
> Patch remains the same, please apply when ready.
The patch is incorrect, please adjust it to match the other architectures.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Patch, microblaze]: Add -fstack-usage support
2013-07-20 8:20 ` Eric Botcazou
@ 2013-07-20 16:45 ` Chung-Ju Wu
2013-07-23 7:18 ` David Holsgrove
0 siblings, 1 reply; 9+ messages in thread
From: Chung-Ju Wu @ 2013-07-20 16:45 UTC (permalink / raw)
To: David Holsgrove
Cc: Eric Botcazou, gcc-patches, Michael Eager, Edgar Iglesias,
John Williams, Vinod Kathail, Vidhumouli Hunsigida,
Nagaraju Mekala, Tom Shui
On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>>>
>>> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>> Add check for flag_stack_usage to handle -fstack-usage support
>>>
>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>
>> Patch remains the same, please apply when ready.
>
> The patch is incorrect, please adjust it to match the other architectures.
>
Hi, David,
Specifically speaking, what Eric meant is to check
flag_stack_usage_info rather than flag_stack_usage
due to the changes after gcc-4.7.
Best regards,
jasonwucj
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Patch, microblaze]: Add -fstack-usage support
2013-07-20 16:45 ` Chung-Ju Wu
@ 2013-07-23 7:18 ` David Holsgrove
2013-07-23 21:23 ` Michael Eager
0 siblings, 1 reply; 9+ messages in thread
From: David Holsgrove @ 2013-07-23 7:18 UTC (permalink / raw)
To: Chung-Ju Wu, Eric Botcazou
Cc: gcc-patches, Michael Eager, Edgar Iglesias, John Williams,
Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Hi Eric / Chung-Ju,
On 21 July 2013 01:33, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
> On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>>>
>>>> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>>>>
>>>> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>> Add check for flag_stack_usage to handle -fstack-usage support
>>>>
>>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>>
>>>
>>> Patch remains the same, please apply when ready.
>>
>>
>> The patch is incorrect, please adjust it to match the other architectures.
>>
>
> Hi, David,
>
> Specifically speaking, what Eric meant is to check
> flag_stack_usage_info rather than flag_stack_usage
> due to the changes after gcc-4.7.
>
Ah, thanks for the catch - patch had been sitting in my tree for quite a while,
hadn't realised the variable name had changed on trunk.
Patch attached which adjusts microblaze's usage to align with other archs.
thanks,
David
>
> Best regards,
> jasonwucj
>
[-- Attachment #2: 0001-Patch-microblaze-Update-flag_stack_usage-variable-na.patch --]
[-- Type: application/octet-stream, Size: 1063 bytes --]
From 53c430e351142a66d32e7638183e00bb70a03c03 Mon Sep 17 00:00:00 2001
From: David Holsgrove <david.holsgrove@xilinx.com>
Date: Tue, 23 Jul 2013 09:18:47 +1000
Subject: [Patch, microblaze]: Update flag_stack_usage variable name
Changelog
2013-07-23 David Holsgrove <david.holsgrove@xilinx.com>
* gcc/config/microblaze/microblaze.c: Test flag_stack_usage_info
variable instead of flag_stack_usage
Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
---
gcc/config/microblaze/microblaze.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/microblaze/microblaze.c b/gcc/config/microblaze/microblaze.c
index c8a3f50..0ce4a9e 100644
--- a/gcc/config/microblaze/microblaze.c
+++ b/gcc/config/microblaze/microblaze.c
@@ -2918,7 +2918,7 @@ microblaze_expand_prologue (void)
fsiz = compute_frame_size (get_frame_size ());
- if (flag_stack_usage)
+ if (flag_stack_usage_info)
current_function_static_stack_size = fsiz;
/* If this function is a varargs function, store any registers that
--
1.7.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Patch, microblaze]: Add -fstack-usage support
2013-07-23 7:18 ` David Holsgrove
@ 2013-07-23 21:23 ` Michael Eager
0 siblings, 0 replies; 9+ messages in thread
From: Michael Eager @ 2013-07-23 21:23 UTC (permalink / raw)
To: David Holsgrove
Cc: Chung-Ju Wu, Eric Botcazou, gcc-patches, Edgar Iglesias,
John Williams, Vinod Kathail, Vidhumouli Hunsigida,
Nagaraju Mekala, Tom Shui
On 07/22/13 22:50, David Holsgrove wrote:
> Hi Eric / Chung-Ju,
>
> On 21 July 2013 01:33, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
>> On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>>>>
>>>>> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>>>>>
>>>>> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>>> Add check for flag_stack_usage to handle -fstack-usage support
>>>>>
>>>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>>>
>>>>
>>>> Patch remains the same, please apply when ready.
>>>
>>>
>>> The patch is incorrect, please adjust it to match the other architectures.
>>>
>>
>> Hi, David,
>>
>> Specifically speaking, what Eric meant is to check
>> flag_stack_usage_info rather than flag_stack_usage
>> due to the changes after gcc-4.7.
>>
>
> Ah, thanks for the catch - patch had been sitting in my tree for quite a while,
> hadn't realised the variable name had changed on trunk.
>
> Patch attached which adjusts microblaze's usage to align with other archs.
Committed revision 201186.
Please send an updated ChangeLog when it is different from the
original.
ChangeLog:
2013-07-23 David Holsgrove <david.holsgrove@xilinx.com>
* config/microblaze/microblaze.c (microblaze_expand_prologue):
Rename flag_stack_usage to flag_stack_usage_info.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Patch, microblaze]: Add -fstack-usage support
2013-03-18 12:49 [Patch, microblaze]: Add -fstack-usage support David Holsgrove
2013-07-15 4:50 ` David Holsgrove
@ 2013-07-18 16:45 ` Michael Eager
2013-07-18 23:58 ` David Holsgrove
1 sibling, 1 reply; 9+ messages in thread
From: Michael Eager @ 2013-07-18 16:45 UTC (permalink / raw)
To: David Holsgrove
Cc: gcc-patches, Edgar Iglesias, John Williams, Vinod Kathail,
Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
On 03/18/13 05:48, David Holsgrove wrote:
> Changelog
>
> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>
> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
> Add check for flag_stack_usage to handle -fstack-usage support
>
> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
Applied revision 201035.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Patch, microblaze]: Add -fstack-usage support
2013-07-18 16:45 ` Michael Eager
@ 2013-07-18 23:58 ` David Holsgrove
2013-07-19 4:14 ` Michael Eager
0 siblings, 1 reply; 9+ messages in thread
From: David Holsgrove @ 2013-07-18 23:58 UTC (permalink / raw)
To: Michael Eager
Cc: gcc-patches, Edgar Iglesias, John Williams, Vinod Kathail,
Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
On 19 July 2013 02:42, Michael Eager <eager@eagerm.com> wrote:
> On 03/18/13 05:48, David Holsgrove wrote:
>>
>> Changelog
>>
>> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>>
>> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>> Add check for flag_stack_usage to handle -fstack-usage support
>>
>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>
>
> Applied revision 201035.
Thanks Michael - did this get applied to trunk? I can't see the commit upstream.
regards,
David
>
> --
> Michael Eager eager@eagercon.com
> 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Patch, microblaze]: Add -fstack-usage support
2013-07-18 23:58 ` David Holsgrove
@ 2013-07-19 4:14 ` Michael Eager
0 siblings, 0 replies; 9+ messages in thread
From: Michael Eager @ 2013-07-19 4:14 UTC (permalink / raw)
To: David Holsgrove
Cc: gcc-patches, Edgar Iglesias, John Williams, Vinod Kathail,
Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
On 07/18/13 16:25, David Holsgrove wrote:
> On 19 July 2013 02:42, Michael Eager <eager@eagerm.com> wrote:
>> On 03/18/13 05:48, David Holsgrove wrote:
>>>
>>> Changelog
>>>
>>> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>>>
>>> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>> Add check for flag_stack_usage to handle -fstack-usage support
>>>
>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>
>>
>> Applied revision 201035.
>
> Thanks Michael - did this get applied to trunk? I can't see the commit upstream.
Not sure what happened before, but it did not get committed.
Committed revision 201042.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-07-23 21:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-18 12:49 [Patch, microblaze]: Add -fstack-usage support David Holsgrove
2013-07-15 4:50 ` David Holsgrove
2013-07-20 8:20 ` Eric Botcazou
2013-07-20 16:45 ` Chung-Ju Wu
2013-07-23 7:18 ` David Holsgrove
2013-07-23 21:23 ` Michael Eager
2013-07-18 16:45 ` Michael Eager
2013-07-18 23:58 ` David Holsgrove
2013-07-19 4:14 ` Michael Eager
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).