* [Patch, microblaze]: Add microblaze*-*-elf target
@ 2013-01-21 5:43 David Holsgrove
2013-01-23 14:58 ` Michael Eager
0 siblings, 1 reply; 6+ messages in thread
From: David Holsgrove @ 2013-01-21 5:43 UTC (permalink / raw)
To: gcc-patches
Cc: Michael Eager, John Williams, Edgar E. Iglesias, Vinod Kathail,
Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
gcc/Changelog
2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com>
* config.gcc (microblaze*-*-elf): Add new target
libgcc/Changelog
2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com>
* config.host (microblaze*-*-elf): Add new target
[-- Attachment #2: 0002-Add-microblaze-elf-target.patch --]
[-- Type: application/octet-stream, Size: 1912 bytes --]
From f6f6c37afb171d05df07ad33216d36e7710373a7 Mon Sep 17 00:00:00 2001
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Date: Sat, 13 Aug 2011 09:16:55 +0200
Subject: [PATCH] Add microblaze*-*-elf target
gcc/Changelog
2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com>
* config.gcc (microblaze*-*-elf): Add new target
libgcc/Changelog
2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com>
* config.host (microblaze*-*-elf): Add new target
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
---
gcc/config.gcc | 6 ++++++
libgcc/config.host | 4 ++++
2 files changed, 10 insertions(+)
diff --git a/gcc/config.gcc b/gcc/config.gcc
index 7deac33..ebef93f 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -1739,6 +1739,12 @@ microblaze*-*-rtems*)
tmake_file="${tmake_file} microblaze/t-microblaze"
tmake_file="${tmake_file} t-rtems microblaze/t-rtems"
;;
+microblaze*-*-elf)
+ tm_file="${tm_file} dbxelf.h newlib-stdint.h"
+ c_target_objs="${c_target_objs} microblaze-c.o"
+ cxx_target_objs="${cxx_target_objs} microblaze-c.o"
+ tmake_file="${tmake_file} microblaze/t-microblaze"
+ ;;
microblaze*-*-*)
tm_file="${tm_file} dbxelf.h"
c_target_objs="${c_target_objs} microblaze-c.o"
diff --git a/libgcc/config.host b/libgcc/config.host
index ffd047f..f5ece59 100644
--- a/libgcc/config.host
+++ b/libgcc/config.host
@@ -715,6 +715,10 @@ mcore-*-elf)
microblaze*-linux*)
tmake_file="$tmake_file t-slibgcc-nolc-override microblaze/t-microblaze t-fdpbit"
;;
+microblaze*-*-elf)
+ tmake_file="${tmake_file} microblaze/t-microblaze t-fdpbit"
+ extra_parts="$extra_parts crtbeginS.o crtendS.o crtbeginT.o crti.o crtn.o"
+ ;;
microblaze*-*-*)
tmake_file="microblaze/t-microblaze t-fdpbit"
extra_parts="crtbegin.o crtend.o crti.o crtn.o"
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Patch, microblaze]: Add microblaze*-*-elf target 2013-01-21 5:43 [Patch, microblaze]: Add microblaze*-*-elf target David Holsgrove @ 2013-01-23 14:58 ` Michael Eager 2013-01-24 4:25 ` David Holsgrove 0 siblings, 1 reply; 6+ messages in thread From: Michael Eager @ 2013-01-23 14:58 UTC (permalink / raw) To: David Holsgrove Cc: gcc-patches, John Williams, Edgar E. Iglesias, Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui On 01/20/2013 09:42 PM, David Holsgrove wrote: > gcc/Changelog > > 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> > > * config.gcc (microblaze*-*-elf): Add new target > > libgcc/Changelog > > 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> > > * config.host (microblaze*-*-elf): Add new target > Hi David -- This appears to be identical the existing microblaze*-*-* target. Why is an -elf target needed? -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, microblaze]: Add microblaze*-*-elf target 2013-01-23 14:58 ` Michael Eager @ 2013-01-24 4:25 ` David Holsgrove 2013-01-24 15:38 ` Michael Eager 0 siblings, 1 reply; 6+ messages in thread From: David Holsgrove @ 2013-01-24 4:25 UTC (permalink / raw) To: Michael Eager Cc: gcc-patches, John Williams, Edgar E. Iglesias, Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui Hi Michael, On 24 January 2013 00:58, Michael Eager <eager@eagercon.com> wrote: > On 01/20/2013 09:42 PM, David Holsgrove wrote: >> >> gcc/Changelog >> >> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >> >> * config.gcc (microblaze*-*-elf): Add new target >> >> libgcc/Changelog >> >> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >> >> * config.host (microblaze*-*-elf): Add new target >> > > Hi David -- > > This appears to be identical the existing microblaze*-*-* target. > Why is an -elf target needed? > Its slightly different, the config.gcc -elf target adds newlib-stdint.h to the tm_file, and in libgcc/config.host we extend the extra_parts by adding crtbeginS.o, crtendS.o crtbeginT.o. It was more to keep the original generic target distinct from the developments to microblaze-*elf. thanks, David > -- > Michael Eager eager@eagercon.com > 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, microblaze]: Add microblaze*-*-elf target 2013-01-24 4:25 ` David Holsgrove @ 2013-01-24 15:38 ` Michael Eager 2013-01-25 0:38 ` David Holsgrove 0 siblings, 1 reply; 6+ messages in thread From: Michael Eager @ 2013-01-24 15:38 UTC (permalink / raw) To: David Holsgrove Cc: gcc-patches, John Williams, Edgar E. Iglesias, Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui On 01/23/2013 08:24 PM, David Holsgrove wrote: > Hi Michael, > > On 24 January 2013 00:58, Michael Eager <eager@eagercon.com> wrote: >> On 01/20/2013 09:42 PM, David Holsgrove wrote: >>> >>> gcc/Changelog >>> >>> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >>> >>> * config.gcc (microblaze*-*-elf): Add new target >>> >>> libgcc/Changelog >>> >>> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >>> >>> * config.host (microblaze*-*-elf): Add new target >>> >> >> Hi David -- >> >> This appears to be identical the existing microblaze*-*-* target. >> Why is an -elf target needed? >> > > Its slightly different, the config.gcc -elf target adds newlib-stdint.h to > the tm_file, and in libgcc/config.host we extend the extra_parts by > adding crtbeginS.o, crtendS.o crtbeginT.o. > > It was more to keep the original generic target distinct from the > developments to microblaze-*elf. The generic microblaze*-*-* target is currently used for --target=microblaze-xilinx-elf. After adding a microblaze*-*-elf target, what targets would use generic target? If there are no known configurations which would match, there's little value in keeping a target which is never built. I don't have any objection to renaming the target from microblaze*-*-* to microblaze-*-*-elf. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, microblaze]: Add microblaze*-*-elf target 2013-01-24 15:38 ` Michael Eager @ 2013-01-25 0:38 ` David Holsgrove 2013-01-26 16:41 ` Michael Eager 0 siblings, 1 reply; 6+ messages in thread From: David Holsgrove @ 2013-01-25 0:38 UTC (permalink / raw) To: Michael Eager Cc: gcc-patches, John Williams, Edgar E. Iglesias, Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui [-- Attachment #1: Type: text/plain, Size: 1457 bytes --] On 25 January 2013 01:38, Michael Eager <eager@eagercon.com> wrote: > On 01/23/2013 08:24 PM, David Holsgrove wrote: >> >> Hi Michael, >> >> On 24 January 2013 00:58, Michael Eager <eager@eagercon.com> wrote: >>> >>> On 01/20/2013 09:42 PM, David Holsgrove wrote: >>>> >>>> >>>> gcc/Changelog >>>> >>>> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >>>> >>>> * config.gcc (microblaze*-*-elf): Add new target >>>> >>>> libgcc/Changelog >>>> >>>> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >>>> >>>> * config.host (microblaze*-*-elf): Add new target >>>> >>> >>> Hi David -- > > The generic microblaze*-*-* target is currently used for > --target=microblaze-xilinx-elf. > > After adding a microblaze*-*-elf target, what targets would use > generic target? If there are no known configurations which would > match, there's little value in keeping a target which is never built. > > I don't have any objection to renaming the target from microblaze*-*-* > to microblaze-*-*-elf. > > Hi Michael, I agree, our default target would be a microblaze*-*-elf, so I can rename the target to reflect this, and update the config.gcc / config.host. I've attached an updated version of the patch for your review. I'll also reply to my patch adding Little Endian support as this will be updated also. thanks again, David > > -- > Michael Eager eager@eagercon.com > 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 > > [-- Attachment #2: 0001-Add-microblaze-elf-target.patch --] [-- Type: application/octet-stream, Size: 2097 bytes --] From 2c5d0dd2c6b9d724f42b52f5d867ed4d23f357b6 Mon Sep 17 00:00:00 2001 From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com> Date: Sat, 13 Aug 2011 09:16:55 +0200 Subject: [PATCH] Add microblaze*-*-elf target gcc/Changelog 2013-01-25 Edgar E. Iglesias <edgar.iglesias@gmail.com> * config.gcc (microblaze*-*-elf): Update existing target libgcc/Changelog 2013-01-25 Edgar E. Iglesias <edgar.iglesias@gmail.com> * config.host (microblaze*-*-elf): Update existing target Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com> --- gcc/config.gcc | 6 +++--- libgcc/config.host | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/config.gcc b/gcc/config.gcc index 7deac33..54f49b2 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -1739,11 +1739,11 @@ microblaze*-*-rtems*) tmake_file="${tmake_file} microblaze/t-microblaze" tmake_file="${tmake_file} t-rtems microblaze/t-rtems" ;; -microblaze*-*-*) - tm_file="${tm_file} dbxelf.h" +microblaze*-*-elf) + tm_file="${tm_file} dbxelf.h newlib-stdint.h" c_target_objs="${c_target_objs} microblaze-c.o" cxx_target_objs="${cxx_target_objs} microblaze-c.o" - tmake_file="${tmake_file} microblaze/t-microblaze" + tmake_file="${tmake_file} microblaze/t-microblaze" ;; mips*-*-netbsd*) # NetBSD/mips, either endian. target_cpu_default="MASK_ABICALLS" diff --git a/libgcc/config.host b/libgcc/config.host index ffd047f..ec25eb3 100644 --- a/libgcc/config.host +++ b/libgcc/config.host @@ -715,9 +715,9 @@ mcore-*-elf) microblaze*-linux*) tmake_file="$tmake_file t-slibgcc-nolc-override microblaze/t-microblaze t-fdpbit" ;; -microblaze*-*-*) - tmake_file="microblaze/t-microblaze t-fdpbit" - extra_parts="crtbegin.o crtend.o crti.o crtn.o" +microblaze*-*-elf) + tmake_file="${tmake_file} microblaze/t-microblaze t-fdpbit" + extra_parts="$extra_parts crtbeginS.o crtendS.o crtbeginT.o crti.o crtn.o" ;; mips*-*-netbsd*) # NetBSD/mips, either endian. ;; -- 1.7.9.5 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, microblaze]: Add microblaze*-*-elf target 2013-01-25 0:38 ` David Holsgrove @ 2013-01-26 16:41 ` Michael Eager 0 siblings, 0 replies; 6+ messages in thread From: Michael Eager @ 2013-01-26 16:41 UTC (permalink / raw) To: David Holsgrove Cc: gcc-patches, John Williams, Edgar E. Iglesias, Vinod Kathail, Vidhumouli Hunsigida, Nagaraju Mekala, Tom Shui On 01/24/2013 04:37 PM, David Holsgrove wrote: > On 25 January 2013 01:38, Michael Eager <eager@eagercon.com> wrote: >> On 01/23/2013 08:24 PM, David Holsgrove wrote: >>> >>> Hi Michael, >>> >>> On 24 January 2013 00:58, Michael Eager <eager@eagercon.com> wrote: >>>> >>>> On 01/20/2013 09:42 PM, David Holsgrove wrote: >>>>> >>>>> >>>>> gcc/Changelog >>>>> >>>>> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >>>>> >>>>> * config.gcc (microblaze*-*-elf): Add new target >>>>> >>>>> libgcc/Changelog >>>>> >>>>> 2013-01-21 Edgar E. Iglesias <edgar.iglesias@gmail.com> >>>>> >>>>> * config.host (microblaze*-*-elf): Add new target >>>>> >>>> >>>> Hi David -- >> >> The generic microblaze*-*-* target is currently used for >> --target=microblaze-xilinx-elf. >> >> After adding a microblaze*-*-elf target, what targets would use >> generic target? If there are no known configurations which would >> match, there's little value in keeping a target which is never built. >> >> I don't have any objection to renaming the target from microblaze*-*-* >> to microblaze-*-*-elf. >> >> > > Hi Michael, > > I agree, our default target would be a microblaze*-*-elf, so I can rename > the target to reflect this, and update the config.gcc / config.host. > > I've attached an updated version of the patch for your review. I'll also > reply to my patch adding Little Endian support as this will be updated > also. Modified Changelog: gcc: * config.gcc (microblaze*-*-*): Rename microblaze*-*-elf, update tm_file. libgcc: * config.host (microblaze*-*-*): Rename microblaze*-*-elf, update extra_parts. Committed revision 195487. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-26 16:41 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-01-21 5:43 [Patch, microblaze]: Add microblaze*-*-elf target David Holsgrove 2013-01-23 14:58 ` Michael Eager 2013-01-24 4:25 ` David Holsgrove 2013-01-24 15:38 ` Michael Eager 2013-01-25 0:38 ` David Holsgrove 2013-01-26 16:41 ` Michael Eager
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).