From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa35.google.com (mail-vk1-xa35.google.com [IPv6:2607:f8b0:4864:20::a35]) by sourceware.org (Postfix) with ESMTPS id 4AB163858D1E for ; Wed, 17 May 2023 21:14:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4AB163858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vk1-xa35.google.com with SMTP id 71dfb90a1353d-44fc78cfe9cso340576e0c.1 for ; Wed, 17 May 2023 14:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1684358098; x=1686950098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cm9GPeo3f44f7CgXfxlQXMCIa39tU00K1PmW7A/gIvI=; b=NAmEYOEKzQOdHp8FjWkVmDSN30jgjoyLsYO/SasZlwhQDddd7XffDS7tWG8zB2zJ/e FK8+34vY2iCMd0RLaYf7PoFJ1g0zuA5wvNGVy9SJ8rmolkNmeGfc6FrDqioO5KHZ6riZ TutRg9oqYWaKYStt+83OVgsd+virYbVg1f/Ts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684358098; x=1686950098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cm9GPeo3f44f7CgXfxlQXMCIa39tU00K1PmW7A/gIvI=; b=UE/xwWCRcNt3GPLSXPvGJcp64wJsdMZwJTPTwA3sohAoQxGnteDy0JtzVSvbz04a4J sMmvXlbkWlBedBY9jWOfNFCJXFBfqG5h/cZAP+oBMlNzeQbS5BlgRp1Nk6+bb3DUF+cA E6oohrBYbBH2mcgp0UR7bi+yGUbwiA1O3Fe/FiZ7+pgGeviXQYxbpfypb2FlXtUGZ1pi lL8lpMfesmRqUpRW24INay0DHlTHaC/sNeSL/xrrNnl6cuiqlxgB1MRp3tupxrDEdUg/ OnxTPUwX0EZgsyKc5wupWSKW76hA2Z44lAzREA9BFn5rIg+Muo80fFc5AG1w/dZddZyE mYHQ== X-Gm-Message-State: AC+VfDxUkCdz6dY8461lQo84AVVQZN/24R6xxKGVuPGk3e79pN138WUl 4FwoMgf3yZOlW+YtzRggb4GgHcxGSnh8lNgbxRdasQ== X-Google-Smtp-Source: ACHHUZ6O6gE899IHfZcWwVOlK/8TgLZAuPB83QDaVYsqtojK5sSBxm+40jBhlO028ZZ+6K8o4Mk32pJPBVyxNS5syjk= X-Received: by 2002:a1f:23d5:0:b0:456:5f29:e278 with SMTP id j204-20020a1f23d5000000b004565f29e278mr1261556vkj.8.1684358098433; Wed, 17 May 2023 14:14:58 -0700 (PDT) MIME-Version: 1.0 References: <20230323110608.42262-1-kmatsui@cs.washington.edu> <33d79daf-60e5-e285-6e12-d3e4abfc1b97@idea> In-Reply-To: <33d79daf-60e5-e285-6e12-d3e4abfc1b97@idea> From: Ken Matsui Date: Wed, 17 May 2023 14:14:47 -0700 Message-ID: Subject: Re: [PATCH] libstdc++: use __bool_constant instead of integral_constant To: Patrick Palka Cc: Jonathan Wakely , gcc-patches , "libstdc++" , Jonathan Wakely , Ville Voutilainen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you! On Wed, May 17, 2023 at 8:53=E2=80=AFAM Patrick Palka w= rote: > > On Fri, 12 May 2023, Ken Matsui via Libstdc++ wrote: > > > It appears that GCC 13 has been released, but I am wondering if there > > are any issues preventing this patch from being merged yet. Can you > > provide any information on this? > > Thanks for the reminder, I pushed this to trunk just now > (r14-940-g637edefc5863cf). Congrats on your first libstdc++ commit! > > > > > On Sat, Apr 8, 2023 at 2:08=E2=80=AFPM Ken Matsui wrote: > > > > > > I see. Thank you! > > > > > > On Sat, Apr 8, 2023 at 12:52=E2=80=AFAM Jonathan Wakely wrote: > > > > > > > > This looks good, thanks, but we're too close to the gcc 13 release = now, and this isn't fixing any bugs. I'll push it after the release. > > > > > > > > > > > > On Thu, 23 Mar 2023, 11:07 Ken Matsui via Libstdc++, wrote: > > > >> > > > >> In the type_traits header, both integral_constant and __bool= _constant > > > >> are used. This patch unifies those usages into __bool_constant. > > > >> > > > >> libstdc++-v3/ChangeLog: > > > >> > > > >> * include/std/type_traits: Use __bool_constant instead of > > > >> integral_constant. > > > >> > > > >> Signed-off-by: Ken Matsui > > > >> --- > > > >> libstdc++-v3/include/std/type_traits | 32 ++++++++++++++---------= ----- > > > >> 1 file changed, 16 insertions(+), 16 deletions(-) > > > >> > > > >> diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/i= nclude/std/type_traits > > > >> index 2bd607a8b8f..bc6982f9e64 100644 > > > >> --- a/libstdc++-v3/include/std/type_traits > > > >> +++ b/libstdc++-v3/include/std/type_traits > > > >> @@ -578,19 +578,19 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// is_enum > > > >> template > > > >> struct is_enum > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_enum(_Tp)> > > > >> { }; > > > >> > > > >> /// is_union > > > >> template > > > >> struct is_union > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_union(_Tp)> > > > >> { }; > > > >> > > > >> /// is_class > > > >> template > > > >> struct is_class > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_class(_Tp)> > > > >> { }; > > > >> > > > >> /// is_function > > > >> @@ -784,7 +784,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// is_trivial > > > >> template > > > >> struct is_trivial > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_trivial(_Tp)> > > > >> { > > > >> static_assert(std::__is_complete_or_unbounded(__type_identi= ty<_Tp>{}), > > > >> "template argument must be a complete class or an unbounde= d array"); > > > >> @@ -793,7 +793,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// is_trivially_copyable > > > >> template > > > >> struct is_trivially_copyable > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_trivially_copyable(_Tp)> > > > >> { > > > >> static_assert(std::__is_complete_or_unbounded(__type_identi= ty<_Tp>{}), > > > >> "template argument must be a complete class or an unbounde= d array"); > > > >> @@ -802,7 +802,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// is_standard_layout > > > >> template > > > >> struct is_standard_layout > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_standard_layout(_Tp)> > > > >> { > > > >> static_assert(std::__is_complete_or_unbounded(__type_identi= ty<_Tp>{}), > > > >> "template argument must be a complete class or an unbounde= d array"); > > > >> @@ -817,7 +817,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> struct > > > >> _GLIBCXX20_DEPRECATED_SUGGEST("is_standard_layout && is_trivi= al") > > > >> is_pod > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_pod(_Tp)> > > > >> { > > > >> static_assert(std::__is_complete_or_unbounded(__type_identi= ty<_Tp>{}), > > > >> "template argument must be a complete class or an unbounde= d array"); > > > >> @@ -831,7 +831,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> struct > > > >> _GLIBCXX17_DEPRECATED > > > >> is_literal_type > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_literal_type(_Tp)> > > > >> { > > > >> static_assert(std::__is_complete_or_unbounded(__type_identi= ty<_Tp>{}), > > > >> "template argument must be a complete class or an unbounde= d array"); > > > >> @@ -840,13 +840,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// is_empty > > > >> template > > > >> struct is_empty > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_empty(_Tp)> > > > >> { }; > > > >> > > > >> /// is_polymorphic > > > >> template > > > >> struct is_polymorphic > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_polymorphic(_Tp)> > > > >> { }; > > > >> > > > >> #if __cplusplus >=3D 201402L > > > >> @@ -855,14 +855,14 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// @since C++14 > > > >> template > > > >> struct is_final > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_final(_Tp)> > > > >> { }; > > > >> #endif > > > >> > > > >> /// is_abstract > > > >> template > > > >> struct is_abstract > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_abstract(_Tp)> > > > >> { }; > > > >> > > > >> /// @cond undocumented > > > >> @@ -873,7 +873,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> > > > >> template > > > >> struct __is_signed_helper<_Tp, true> > > > >> - : public integral_constant > > > >> + : public __bool_constant<_Tp(-1) < _Tp(0)> > > > >> { }; > > > >> /// @endcond > > > >> > > > >> @@ -1333,7 +1333,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// has_virtual_destructor > > > >> template > > > >> struct has_virtual_destructor > > > >> - : public integral_constant > > > >> + : public __bool_constant<__has_virtual_destructor(_Tp)> > > > >> { > > > >> static_assert(std::__is_complete_or_unbounded(__type_identi= ty<_Tp>{}), > > > >> "template argument must be a complete class or an unbounde= d array"); > > > >> @@ -1392,7 +1392,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> template > > > >> struct is_same > > > >> #ifdef _GLIBCXX_HAVE_BUILTIN_IS_SAME > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_same(_Tp, _Up)> > > > >> #else > > > >> : public false_type > > > >> #endif > > > >> @@ -1408,7 +1408,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > > >> /// is_base_of > > > >> template > > > >> struct is_base_of > > > >> - : public integral_constant > > > >> + : public __bool_constant<__is_base_of(_Base, _Derived)> > > > >> { }; > > > >> > > > >> #if __has_builtin(__is_convertible) > > > >> -- > > > >> 2.40.0 > > > >> > > > >