public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ken Matsui <kmatsui@cs.washington.edu>
To: gcc-patches@gcc.gnu.org
Cc: Patrick Palka <ppalka@redhat.com>, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: use new built-in trait __remove_pointer
Date: Mon, 20 Mar 2023 00:31:03 -0700	[thread overview]
Message-ID: <CAML+3pUQ3-R_6PrKGEmQUDv8C8-o+YBxWdMwF8_pH5AB83pf8Q@mail.gmail.com> (raw)
In-Reply-To: <CAML+3pW_2+9XTYMWEVHDyU8BKBpQEuGTkwmYVr+dcwUtzHVgsw@mail.gmail.com>

CCing libstdc++@gcc.gnu.org.

On Sun, Mar 19, 2023 at 7:53 PM Ken Matsui <kmatsui@cs.washington.edu> wrote:
>
> libstdc++-v3/ChangeLog:
>
> * include/std/type_traits (is_reference): Use __remove_pointer built-in trait.
>
> ---
> diff --git a/libstdc++-v3/include/std/type_traits
> b/libstdc++-v3/include/std/type_traits
> index 2bd607a8b8f..cba98091aad 100644
> --- a/libstdc++-v3/include/std/type_traits
> +++ b/libstdc++-v3/include/std/type_traits
> @@ -2025,17 +2025,23 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>
>    template<typename _Tp, typename>
>      struct __remove_pointer_helper
> -    { typedef _Tp     type; };
> +    { using type = _Tp; };
>
>    template<typename _Tp, typename _Up>
>      struct __remove_pointer_helper<_Tp, _Up*>
> -    { typedef _Up     type; };
> +    { using type = _Up; };
>
>    /// remove_pointer
> +#if __has_builtin(__remove_pointer)
> +  template<typename _Tp>
> +    struct remove_pointer
> +    { using type = __remove_pointer(_Tp); };
> +#else
>    template<typename _Tp>
>      struct remove_pointer
>      : public __remove_pointer_helper<_Tp, __remove_cv_t<_Tp>>
>      { };
> +#endif
>
>    template<typename _Tp, typename = void>
>      struct __add_pointer_helper

  reply	other threads:[~2023-03-20  7:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20  2:53 Ken Matsui
2023-03-20  7:31 ` Ken Matsui [this message]
2023-03-20  7:57   ` Jonathan Wakely
2023-03-20  8:07     ` Ken Matsui
2023-03-20  9:11       ` Jonathan Wakely
2023-03-20 13:26         ` Ken Matsui
2023-03-20 22:24           ` Ken Matsui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAML+3pUQ3-R_6PrKGEmQUDv8C8-o+YBxWdMwF8_pH5AB83pf8Q@mail.gmail.com \
    --to=kmatsui@cs.washington.edu \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ppalka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).