From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by sourceware.org (Postfix) with ESMTPS id F0EFA3857B9B for ; Mon, 4 Sep 2023 15:00:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0EFA3857B9B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vk1-xa2f.google.com with SMTP id 71dfb90a1353d-4901f5ae7caso270996e0c.3 for ; Mon, 04 Sep 2023 08:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1693839656; x=1694444456; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZW0AOkahHOayk/HPzTlnSuhM0lVnOaVOLa4J3Olm+cE=; b=B2L0/yBZfdo+Smh8Rvxfm9cz/oshIxGDaLMcnY2hoB5FoKpmUHm0WJm5dZDyi4eUaY YUIETkwVI1eHbKYloS+TamqGFRz1jVDxVc+fvtx+WTUVpS6rmv+GAJcFipYQE3hndcN7 g0UCB5xj0TyBmk34pMbeYCSyafnJSS1zr7uPY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693839656; x=1694444456; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZW0AOkahHOayk/HPzTlnSuhM0lVnOaVOLa4J3Olm+cE=; b=PatDd0f8GqOhSF8PLYMO6FoZpdm/XzhkZdWcdz+gzw8xxzeOTgwI9KrREKrS3yt303 5gGRBizmgVpOxu6oQ6V0W4+xjUIChMiH2mVynw7JanHYP5EgRDxkeCTN4CBDG+iwIDjN e1nRvNg8leFSNpq8WERTQNok+eLbh9BCwijxr3IZJOCPzh56s/foJZCJpGnYtrJIRCnK qlaSR+45sirK5SBaH6MrqjvWmDN8tOWTfDShcKW7ZYaMvGEktjYUY0WTleuc0nb5BMYx yQkj8DWvq0QqRoJV2CBs9NeadBAMRDzBq5HPyTHVR+obMP10psPn44uBMAhIT1pPL2R/ 9ABQ== X-Gm-Message-State: AOJu0YxpcgUGaBgT4GDl1YNJvEebT/XCbyT8vVQRbDWOgDO+NuSlVXO4 18wNLFFnDPqOF1bqkvWzBdlSU70EsKre9WAi2/8Fmw== X-Google-Smtp-Source: AGHT+IG/WzxDwapN7tnhsNoFakGVpoLeIbhWzjHflOn/2E5n+YiBuZ3gASVd9DGcqv4Ml4H7mwPeREwyoGRbmHzRZ98= X-Received: by 2002:a1f:6dc1:0:b0:488:23bc:6d0f with SMTP id i184-20020a1f6dc1000000b0048823bc6d0fmr8116441vkc.16.1693839656373; Mon, 04 Sep 2023 08:00:56 -0700 (PDT) MIME-Version: 1.0 References: <20230708055435.68714-1-kmatsui@gcc.gnu.org> <20230708111308.92402-1-kmatsui@gcc.gnu.org> In-Reply-To: From: Ken Matsui Date: Mon, 4 Sep 2023 08:00:00 -0700 Message-ID: Subject: [PING][PATCH v4 1/2] c++: implement __is_unsigned built-in trait To: jason@redhat.com Cc: gcc-patches , "libstdc++" , Ken Matsui Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping for __is_unsigned built-in. Sincerely, Ken Matsui On Sat, Jul 8, 2023 at 4:25=E2=80=AFAM Ken Matsui wrote: > > Hi, > > Here is the benchmark result for is_unsigned: > > https://github.com/ken-matsui/gcc-benches/blob/main/is_unsigned.md#sat-ju= l--8-041510-am-pdt-2023 > > Time: -66.908% > Peak Memory Usage: -42.5139% > Total Memory Usage: -46.3483% > > Sincerely, > Ken Matsui > > On Sat, Jul 8, 2023 at 4:13=E2=80=AFAM Ken Matsui w= rote: > > > > This patch implements built-in trait for std::is_unsigned. > > > > gcc/cp/ChangeLog: > > > > * cp-trait.def: Define __is_unsigned. > > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_UNSIGNED. > > * semantics.cc (trait_expr_value): Likewise. > > (finish_trait_expr): Likewise. > > > > gcc/testsuite/ChangeLog: > > > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_unsigned. > > * g++.dg/ext/is_unsigned.C: New test. > > > > Signed-off-by: Ken Matsui > > --- > > gcc/cp/constraint.cc | 3 ++ > > gcc/cp/cp-trait.def | 1 + > > gcc/cp/semantics.cc | 4 ++ > > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 ++ > > gcc/testsuite/g++.dg/ext/is_unsigned.C | 47 ++++++++++++++++++++++++ > > 5 files changed, 58 insertions(+) > > create mode 100644 gcc/testsuite/g++.dg/ext/is_unsigned.C > > > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > > index 8cf0f2d0974..ec8de87d1a1 100644 > > --- a/gcc/cp/constraint.cc > > +++ b/gcc/cp/constraint.cc > > @@ -3751,6 +3751,9 @@ diagnose_trait_expr (tree expr, tree args) > > case CPTK_IS_UNION: > > inform (loc, " %qT is not a union", t1); > > break; > > + case CPTK_IS_UNSIGNED: > > + inform (loc, " %qT is not an unsigned type", t1); > > + break; > > case CPTK_IS_AGGREGATE: > > inform (loc, " %qT is not an aggregate", t1); > > break; > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > > index 8b7fece0cc8..1a219243162 100644 > > --- a/gcc/cp/cp-trait.def > > +++ b/gcc/cp/cp-trait.def > > @@ -82,6 +82,7 @@ DEFTRAIT_EXPR (IS_TRIVIALLY_ASSIGNABLE, "__is_trivial= ly_assignable", 2) > > DEFTRAIT_EXPR (IS_TRIVIALLY_CONSTRUCTIBLE, "__is_trivially_constructib= le", -1) > > DEFTRAIT_EXPR (IS_TRIVIALLY_COPYABLE, "__is_trivially_copyable", 1) > > DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > > +DEFTRAIT_EXPR (IS_UNSIGNED, "__is_unsigned", 1) > > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_= from_temporary", 2) > > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from= _temporary", 2) > > /* FIXME Added space to avoid direct usage in GCC 13. */ > > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > > index 8fb47fd179e..2d48894d811 100644 > > --- a/gcc/cp/semantics.cc > > +++ b/gcc/cp/semantics.cc > > @@ -12118,6 +12118,9 @@ trait_expr_value (cp_trait_kind kind, tree type= 1, tree type2) > > case CPTK_IS_UNION: > > return type_code1 =3D=3D UNION_TYPE; > > > > + case CPTK_IS_UNSIGNED: > > + return TYPE_UNSIGNED (type1); > > + > > case CPTK_IS_ASSIGNABLE: > > return is_xible (MODIFY_EXPR, type1, type2); > > > > @@ -12296,6 +12299,7 @@ finish_trait_expr (location_t loc, cp_trait_kin= d kind, tree type1, tree type2) > > case CPTK_IS_ENUM: > > case CPTK_IS_UNION: > > case CPTK_IS_SAME: > > + case CPTK_IS_UNSIGNED: > > break; > > > > case CPTK_IS_LAYOUT_COMPATIBLE: > > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g= ++.dg/ext/has-builtin-1.C > > index f343e153e56..20bf8e6cad5 100644 > > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > > @@ -146,3 +146,6 @@ > > #if !__has_builtin (__remove_cvref) > > # error "__has_builtin (__remove_cvref) failed" > > #endif > > +#if !__has_builtin (__is_unsigned) > > +# error "__has_builtin (__is_unsigned) failed" > > +#endif > > diff --git a/gcc/testsuite/g++.dg/ext/is_unsigned.C b/gcc/testsuite/g++= .dg/ext/is_unsigned.C > > new file mode 100644 > > index 00000000000..2bb45d209a7 > > --- /dev/null > > +++ b/gcc/testsuite/g++.dg/ext/is_unsigned.C > > @@ -0,0 +1,47 @@ > > +// { dg-do compile { target c++11 } } > > + > > +#include > > + > > +using namespace __gnu_test; > > + > > +#define SA(X) static_assert((X),#X) > > +#define SA_TEST_CATEGORY(TRAIT, X, expect) \ > > + SA(TRAIT(X) =3D=3D expect); \ > > + SA(TRAIT(const X) =3D=3D expect); \ > > + SA(TRAIT(volatile X) =3D=3D expect); \ > > + SA(TRAIT(const volatile X) =3D=3D expect) > > + > > +SA_TEST_CATEGORY(__is_unsigned, void, false); > > + > > +SA_TEST_CATEGORY(__is_unsigned, bool, (bool(-1) > bool(0))); > > +SA_TEST_CATEGORY(__is_unsigned, char, (char(-1) > char(0))); > > +SA_TEST_CATEGORY(__is_unsigned, signed char, false); > > +SA_TEST_CATEGORY(__is_unsigned, unsigned char, true); > > +SA_TEST_CATEGORY(__is_unsigned, wchar_t, (wchar_t(-1) > wchar_t(0))); > > +SA_TEST_CATEGORY(__is_unsigned, short, false); > > +SA_TEST_CATEGORY(__is_unsigned, unsigned short, true); > > +SA_TEST_CATEGORY(__is_unsigned, int, false); > > +SA_TEST_CATEGORY(__is_unsigned, unsigned int, true); > > +SA_TEST_CATEGORY(__is_unsigned, long, false); > > +SA_TEST_CATEGORY(__is_unsigned, unsigned long, true); > > +SA_TEST_CATEGORY(__is_unsigned, long long, false); > > +SA_TEST_CATEGORY(__is_unsigned, unsigned long long, true); > > + > > +SA_TEST_CATEGORY(__is_unsigned, float, false); > > +SA_TEST_CATEGORY(__is_unsigned, double, false); > > +SA_TEST_CATEGORY(__is_unsigned, long double, false); > > + > > +#ifndef __STRICT_ANSI__ > > +// GNU Extensions. > > +#ifdef __SIZEOF_INT128__ > > +SA_TEST_CATEGORY(__is_unsigned, unsigned __int128, true); > > +SA_TEST_CATEGORY(__is_unsigned, __int128, false); > > +#endif > > + > > +#ifdef _GLIBCXX_USE_FLOAT128 > > +SA_TEST_CATEGORY(__is_unsigned, __float128, false); > > +#endif > > +#endif > > + > > +// Sanity check. > > +SA_TEST_CATEGORY(__is_unsigned, ClassType, false); > > -- > > 2.41.0 > >