From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id A88113858D3C for ; Sat, 23 Dec 2023 21:39:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A88113858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A88113858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703367560; cv=none; b=DkIOLmHr0qwv/MvU47FWq3h9wfKblY0+YB4remyx6VLa+zgQQBDQgENToDpWwzc5cgM2/jSXMO31XK/n+kPTxwe4A31TvDrJjSyVYiNRG9YUXLdM3cYihBllz6GKpetYLlwS6QCCIouBzyCRm6MCgMC/OF59O1KYinEk0kgrbto= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703367560; c=relaxed/simple; bh=F+GC5E0ilSQUVgLBililma6LBiLyqgpFu3SzaGLD050=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=boIIM0I2GWp1+QzzND8SqM68fwu/PAsuF3605JQodTrhpiUwdlcctwADyc0srskZJUHyJG5tCNDjczpIeZkH51slZrHvQCaIrLRpYgr69Dz+c2145mqLLpLZQakfdZWgNW3Ch+UsH34QznjeQTg/yQcOUo9hA5QUEjdcmme1IpU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-5942c83c97fso1717237eaf.1 for ; Sat, 23 Dec 2023 13:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1703367558; x=1703972358; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SH80q8hRfeUsKtw7p5iS+FhcyeOf622XZECx8X6PasE=; b=GaPdrF34oNN/lgnN7C0gzX92Ni9flB6WxFXzsyM7dpuixw3GgpyAQsdrHWNEL8+W8d /csF9opQOXoxDSEvObjUnhtexszs1Pzffr2zlkOUbiuORY/BePCQtS9fBgZqqX+Oc25h f6HvEESisMbfhwmVQRL/KUwMDG6RGB/+ve/4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703367558; x=1703972358; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SH80q8hRfeUsKtw7p5iS+FhcyeOf622XZECx8X6PasE=; b=ikR/Xt/oLvpeCsuaVZitS8TtQxaYciaTWfy7AbpsI3wUZhG+orHL7nXGKbQ5pzIZXa gmcCnq/OEygm/YGGM4r028aU5zY+VU6+GQR0mgkxmMBJec8gDRPrs87JibNsniYXeIAy 3OMto25gyq1MVedMzhL6iKbGZXltHWFX9st76taWYtTVhqtxShawCSjJ+GY9R8dH88ly R1OuD6bbgHvQF/1a/2IM4TzFjhFW9UI2SgR9VGoEQh26kdvxCDVPn68vyFF8NpxOUC6a gSUZY4Csqornr+bl8pIGG3uiw75cChyZmYd7XBnVsa1E5ZAPpHpqpzNb593kyzDwX0B5 OdAg== X-Gm-Message-State: AOJu0YxzCh4CeZBmQg6/XuGKVYIaZDqGWH90MmMxjWXvNR0gnuMP0HUT NuKMNDQ+skfZfWjf4t2+6hTDL8G6sq4AJloMRtt1bWMpN+bReLkzjyJ00DWedg== X-Google-Smtp-Source: AGHT+IFqKFm8sB3HnLOKeAu0ZG24OT8O/+FEalyYmv35gVMHy7uEjO69QN95z27+Iq6/qnhMwVFLmljnOz4XShMQg1M= X-Received: by 2002:a05:6870:c114:b0:203:f580:bd91 with SMTP id f20-20020a056870c11400b00203f580bd91mr3608529oad.42.1703367557838; Sat, 23 Dec 2023 13:39:17 -0800 (PST) MIME-Version: 1.0 References: <20231223213542.448971-1-kmatsui@gcc.gnu.org> <20231223213542.448971-2-kmatsui@gcc.gnu.org> In-Reply-To: <20231223213542.448971-2-kmatsui@gcc.gnu.org> From: Ken Matsui Date: Sat, 23 Dec 2023 13:38:42 -0800 Message-ID: Subject: Re: [PATCH 1/8] c++: Implement __is_const built-in trait To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Dec 23, 2023 at 1:36=E2=80=AFPM Ken Matsui wr= ote: > > This patch implements built-in trait for std::is_const. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_const. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_CONST. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_const. > * g++.dg/ext/is_const.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 +++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 ++++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/is_const.C | 19 +++++++++++++++++++ > 5 files changed, 30 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_const.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index eeacead52a5..f1b07aa2853 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3734,6 +3734,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_IS_CLASS: > inform (loc, " %qT is not a class", t1); > break; > + case CPTK_IS_CONST: > + inform (loc, " %qT is not a const type", t1); > + break; > case CPTK_IS_CONSTRUCTIBLE: > if (!t2) > inform (loc, " %qT is not default constructible", t1); > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 394f006f20f..36faed9c0b3 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -64,6 +64,7 @@ DEFTRAIT_EXPR (IS_ASSIGNABLE, "__is_assignable", 2) > DEFTRAIT_EXPR (IS_BASE_OF, "__is_base_of", 2) > DEFTRAIT_EXPR (IS_BOUNDED_ARRAY, "__is_bounded_array", 1) > DEFTRAIT_EXPR (IS_CLASS, "__is_class", 1) > +DEFTRAIT_EXPR (IS_CONST, "__is_const", 1) > DEFTRAIT_EXPR (IS_CONSTRUCTIBLE, "__is_constructible", -1) > DEFTRAIT_EXPR (IS_CONVERTIBLE, "__is_convertible", 2) > DEFTRAIT_EXPR (IS_EMPTY, "__is_empty", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index e6dba29ee81..364d87ee34d 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12415,6 +12415,9 @@ trait_expr_value (cp_trait_kind kind, tree type1,= tree type2) > case CPTK_IS_CLASS: > return NON_UNION_CLASS_TYPE_P (type1); > > + case CPTK_IS_CONST: > + return CP_TYPE_CONST_P (type1); > + > case CPTK_IS_CONSTRUCTIBLE: > return is_xible (INIT_EXPR, type1, type2); > > @@ -12657,6 +12660,7 @@ finish_trait_expr (location_t loc, cp_trait_kind = kind, tree type1, tree type2) > case CPTK_IS_ARRAY: > case CPTK_IS_BOUNDED_ARRAY: > case CPTK_IS_CLASS: > + case CPTK_IS_CONST: > case CPTK_IS_ENUM: > case CPTK_IS_FUNCTION: > case CPTK_IS_MEMBER_FUNCTION_POINTER: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++= .dg/ext/has-builtin-1.C > index 02b4b4d745d..e3640faeb96 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -71,6 +71,9 @@ > #if !__has_builtin (__is_class) > # error "__has_builtin (__is_class) failed" > #endif > +#if !__has_builtin (__is_const) > +# error "__has_builtin (__is_const) failed" > +#endif > #if !__has_builtin (__is_constructible) > # error "__has_builtin (__is_constructible) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/is_const.C b/gcc/testsuite/g++.dg/e= xt/is_const.C > new file mode 100644 > index 00000000000..8f2d7c2fce9 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_const.C > @@ -0,0 +1,19 @@ > +// { dg-do compile { target c++11 } } > + > +#include > + Please ignore this patch series. I should have removed testsuite_tr1.h. > +using namespace __gnu_test; > + > +#define SA(X) static_assert((X),#X) > + > +// Positive tests. > +SA(__is_const(const int)); > +SA(__is_const(const volatile int)); > +SA(__is_const(cClassType)); > +SA(__is_const(cvClassType)); > + > +// Negative tests. > +SA(!__is_const(int)); > +SA(!__is_const(volatile int)); > +SA(!__is_const(ClassType)); > +SA(!__is_const(vClassType)); > -- > 2.43.0 >