From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by sourceware.org (Postfix) with ESMTPS id 9450A3858C5E for ; Mon, 20 Mar 2023 13:22:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9450A3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vs1-xe34.google.com with SMTP id t4so10465714vsq.1 for ; Mon, 20 Mar 2023 06:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1679318569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cjMi4Y84Utr8CxtMp1T0e9eD83pIqBiyp5XrFSyYHDA=; b=BROWDISmrf/TnIUCZDRMdylLEVz6Z2N/iXldCFChG5/4NhoZ3nTYC3wkjogBuH/VN/ axi+33/tp/jRj5rLzhAXmGDNw4BdjVF1tpo76lmI3EQvSdq8sDAcalKOFcL7FZRYLUg8 FjWdUAdEwnJL0Oz3tpmfyU12fJOrg8dXtoMKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679318569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cjMi4Y84Utr8CxtMp1T0e9eD83pIqBiyp5XrFSyYHDA=; b=cj8jffPENCzmTOudkdxvTHEmqMITTM+kspBKZozsZVfo2o48x7PG71VjqjSjpN8teN Hs02HiUbfdSRpIQENdejVRDbGuKSYZWazlhaV/GQCCqEdb3EDIABSkDpPtxyk5RzJoaM tCjYS7h3ey1Jee53QcOgffWXXrCMj0ypaLWvQ84Yzvj/W+UXd0rpKoN0djQSPY2fViff L6cxKBHBKbQCCWonjNejzv+otcxCZFYf/AuHiWySLLXg+Pen2FlFfZIv05TMnDKdqbPe cIZkhfWWTGraHiLLo7g+b+Udp8e1klZCCOKQAn/QTJNgTh5yz1dcXmjxm/LcjsFE2VoJ 1x7g== X-Gm-Message-State: AO0yUKUcWR9vBtx8FvgFxJTtn1FyQkrMX4cyknI3M9NjtkEKdgx1Kh38 omXb0agXoQJuNlYFJXxhx6KSl9BEwDlr+gTi/NTHsw== X-Google-Smtp-Source: AK7set+Uhweu+TowXg8AulM4N2bCuCUbLlWo4AjBkOwVoO04kTJLtoSP/OBcIGjqcfXgmoZwfVVRT6+JMmG8E8Ce7SY= X-Received: by 2002:a67:c019:0:b0:423:e2c4:351e with SMTP id v25-20020a67c019000000b00423e2c4351emr3844138vsi.6.1679318568922; Mon, 20 Mar 2023 06:22:48 -0700 (PDT) MIME-Version: 1.0 References: <45e80ead7387ef50026922c217a33719bfc66a4a.camel@xry111.site> <830648d9293be2e7895e0b40ccac9cce16858aa3.camel@xry111.site> In-Reply-To: From: Ken Matsui Date: Mon, 20 Mar 2023 06:22:38 -0700 Message-ID: Subject: Re: [PATCH] libstdc++: use new built-in trait __is_reference To: Jonathan Wakely Cc: Xi Ruoyao , gcc-patches@gcc.gnu.org, Patrick Palka , libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It looks like I was able to use git send-email. The new patches became a series, so I couldn't figure out how to associate them with this email and another email. Please disregard this email. On Mon, Mar 20, 2023 at 2:56=E2=80=AFAM Ken Matsui wrote: > > > Does it actually make compilation faster though? > > > > Has it been measured? > > In my understanding, what I have implemented so far is so simple that > it does not affect the speed. These traits are what Partick kindly > recommended to get started. As explained on the GSoC page, some traits > might involve expensive instantiation of multiple class templates. So > IMHO, implementing built-in traits for those traits can make > compilation cheaper. > > I have not measured it, but Patrick might have done? > > On Mon, Mar 20, 2023 at 2:14=E2=80=AFAM Jonathan Wakely wrote: > > > > On Mon, 20 Mar 2023 at 08:08, Xi Ruoyao via Libstdc++ > > wrote: > > > > > > On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote: > > > > Oops, I assumed those were my email... Thank you for your heads up = and > > > > your comments! > > > > > > > > > Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, = nor > > > > > nothing) to indent the ChangeLog content. > > > > > > > > Do you mean like the following? > > > > > > > > ``` > > > > libstdc++-v3/ChangeLog: > > > > > > > > [TAB]* include/std/type_traits (is_reference): Use __is_reference > > > > built-in > > > > trait. > > > > ``` > > > > > > Yep. > > > > > > > > Is there any benefit to use a builtin, instead of the existing > > > > > implementation? I can see no but maybe I'm stupid. > > > > > > > > My patches are based on the GSoC project "C++: Implement compiler > > > > built-in traits for the standard library traits". These built-in > > > > traits basically make the compilation faster. > > > > > > > > https://gcc.gnu.org/wiki/SummerOfCode > > > > > > Ok, to me making compilation faster is a valid reason. > > > > Does it actually make compilation faster though? > > > > Has it been measured? > > > > > > > The patch fails to apply. It seems because your mail client inse= rted an > > > > > additional newline before "b/". Try to use git-send-email or con= figure > > > > > the mail client properly. > > > > > > > > Let me try to use git-send-email instead. I stupidly don't understa= nd > > > > how to use them, so I was making my patches manually... > > > > > > Or adjust the mail client correctly. You can send the patch to yours= elf > > > first and see if it's not "mangled" by the mail client when you debug > > > such an issue... > > > > > > But when you finally end up sending 10 patches in a series you'll fin= d > > > git send-email much easier :). > > > > Figuring out how to generate proper patches is an important part of > > contributing to GCC, so part of any GSoC project.