From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by sourceware.org (Postfix) with ESMTPS id 6B2903858D1E for ; Sun, 19 Mar 2023 04:08:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B2903858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-ua1-x92c.google.com with SMTP id s23so5836079uae.5 for ; Sat, 18 Mar 2023 21:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1679198884; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=7Hl95EHmtIAuK2KNFwsL6Va0QGizOXgp4425QtjjN+U=; b=O4MkqIwJYJIs9RpmkacUgKfG2l7CxmkYwG0f3CnkrV/WwqgFQhhwldH64DoodoVL0/ Mv/5gPk5FvlwYKStv3pkE4C0PmXIS42Sv+Uz5EVo4qK5My1rzUxPuCosef3NzbuIr2DJ TTIOpazVTqkMc86QYNaBzWuZflIqOwpjcW/hs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679198884; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7Hl95EHmtIAuK2KNFwsL6Va0QGizOXgp4425QtjjN+U=; b=j74IVrsslQJBpZq+vWwTGSKecoudDmAP9Yyt55uImZ5sK3/NEGKq0aEkf1cwCqMuNf PICr0DeN7uoeCM2BpTL/5niPZ+bcfx/47KRHGFYTGcy8w6FkWX/v33ll1Le9P+9IB45I p3ZCljOMomle2NG/VkcmzQ6Gf6Pt+GFDFHYEH2DfFWB918xwKSK452ywvB6V/oqNkj23 H+0Ao6XUd71lFXjWa4GkFtBQGWeFWvsQ/WJ+jPipDDg1ZkrOq4yIVvb6rlLjIpUpI2/D 5wNqWk45AE0cC785PiyRzsDNveHtXsXkoPQVFarxy48bAu/BxgsUP3RcVjKjqUm9GwSr u6/Q== X-Gm-Message-State: AO0yUKXx5sf2X+EUVBG+tXk+45girPFHx3wyM3VwjOR7hJjIIgIqXT6E /qzA9wfA1akG+waTa+QC0uIn5Pj2EEJS4T1XobhmLXmcCDftPXuU5oc= X-Google-Smtp-Source: AK7set+t9FivAd9igz/4hPQ4LiP7rHFYxv45cJulM6P8cpv5QmSzAfgjYcc1IGQ4s0iDjdVUas2GPwwBo4WSSJI39NY= X-Received: by 2002:ab0:1006:0:b0:68e:2ed3:92eb with SMTP id f6-20020ab01006000000b0068e2ed392ebmr1765257uab.1.1679198883740; Sat, 18 Mar 2023 21:08:03 -0700 (PDT) MIME-Version: 1.0 From: Ken Matsui Date: Sat, 18 Mar 2023 21:07:53 -0700 Message-ID: Subject: [PATCH] c++: implement __is_reference built-in trait To: gcc-patches@gcc.gnu.org Cc: Patrick Palka Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This patch implements built-in trait for std::is_reference. gcc/cp/ChangeLog: * cp-trait.def (names_builtin_p): Define __is_reference. * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_REFERENCE. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise. gcc/testsuite/ChangeLog: * g++.dg/ext/has-builtin-1.C: Test existence of __is_reference. * g++.dg/ext/is_reference.C: New test. --- diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc index 273d15ab097..23e5bc24dbb 100644 --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc @@ -3701,6 +3701,9 @@ diagnose_trait_expr (tree expr, tree args) case CPTK_HAS_VIRTUAL_DESTRUCTOR: inform (loc, " %qT does not have a virtual destructor", t1); break; + case CPTK_IS_REFERENCE: + inform (loc, " %qT is not a reference", t1); + break; case CPTK_IS_ABSTRACT: inform (loc, " %qT is not an abstract class", t1); break; diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def index bac593c0094..63a64152ce6 100644 --- a/gcc/cp/cp-trait.def +++ b/gcc/cp/cp-trait.def @@ -67,6 +67,7 @@ DEFTRAIT_EXPR (IS_CONVERTIBLE, "__is_convertible", 2) DEFTRAIT_EXPR (IS_EMPTY, "__is_empty", 1) DEFTRAIT_EXPR (IS_ENUM, "__is_enum", 1) DEFTRAIT_EXPR (IS_FINAL, "__is_final", 1) +DEFTRAIT_EXPR (IS_REFERENCE, "__is_reference", 1) DEFTRAIT_EXPR (IS_LAYOUT_COMPATIBLE, "__is_layout_compatible", 2) DEFTRAIT_EXPR (IS_LITERAL_TYPE, "__is_literal_type", 1) DEFTRAIT_EXPR (IS_NOTHROW_ASSIGNABLE, "__is_nothrow_assignable", 2) diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc index 87c2e8a7111..dce98af4f72 100644 --- a/gcc/cp/semantics.cc +++ b/gcc/cp/semantics.cc @@ -11995,6 +11995,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) case CPTK_IS_FINAL: return CLASS_TYPE_P (type1) && CLASSTYPE_FINAL (type1); + case CPTK_IS_REFERENCE: + return type_code1 == REFERENCE_TYPE; + case CPTK_IS_LAYOUT_COMPATIBLE: return layout_compatible_type_p (type1, type2); @@ -12139,6 +12142,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) case CPTK_HAS_TRIVIAL_COPY: case CPTK_HAS_TRIVIAL_DESTRUCTOR: case CPTK_HAS_UNIQUE_OBJ_REPRESENTATIONS: + case CPTK_IS_REFERENCE: if (!check_trait_type (type1)) return error_mark_node; break; diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C index f343e153e56..b697673790c 100644 --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C @@ -146,3 +146,6 @@ #if !__has_builtin (__remove_cvref) # error "__has_builtin (__remove_cvref) failed" #endif +#if !__has_builtin (__is_reference) +# error "__has_builtin (__is_reference) failed" +#endif diff --git a/gcc/testsuite/g++.dg/ext/is_reference.C b/gcc/testsuite/g++.dg/ext/is_reference.C new file mode 100644 index 00000000000..b4f048538e5 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/is_reference.C @@ -0,0 +1,26 @@ +// { dg-do compile { target c++11 } } + +#define SA(X) static_assert((X),#X) + +SA(!__is_reference(void)); +SA(!__is_reference(int*)); + +SA(__is_reference(int&)); +SA(__is_reference(const int&)); +SA(__is_reference(volatile int&)); +SA(__is_reference(const volatile int&)); + +SA(__is_reference(int&&)); +SA(__is_reference(const int&&)); +SA(__is_reference(volatile int&&)); +SA(__is_reference(const volatile int&&)); + +SA(!__is_reference(int[3])); +SA(!__is_reference(const int[3])); +SA(!__is_reference(volatile int[3])); +SA(!__is_reference(const volatile int[3])); + +SA(!__is_reference(int(int))); +SA(!__is_reference(int(*const)(int))); +SA(!__is_reference(int(*volatile)(int))); +SA(!__is_reference(int(*const volatile)(int)));