From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by sourceware.org (Postfix) with ESMTPS id B9C2C3858D37 for ; Tue, 21 Mar 2023 09:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9C2C3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-vs1-xe35.google.com with SMTP id h15so1661069vsh.0 for ; Tue, 21 Mar 2023 02:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1679392203; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kKZYNyxZWgjU92+YuVukXNuFRdU6jXyRGdJg+tV/lGY=; b=KH7wqxMeWet62/jcrMIZH1mvOrelLmCj90zMTXnPIsVqf+UvPtv1t0NzTuBaRo9RVL CLa35TdPHzwyD1DPkQoziX/dOBuqPCkcOyv8AEiKMXoR0xFQJA+PAcbdqLQqDwMgyjzH YPNKHIKwiwl6Ap83shqq+l8FD8H+LqvcAiHuc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679392203; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kKZYNyxZWgjU92+YuVukXNuFRdU6jXyRGdJg+tV/lGY=; b=58OmzrOqDw+e9xeAN0bbZLm6pUWThFV6C7PPzSuAhe313FQmK7ocA+XStMlx+Pq7L+ 1SqHIogujdi7O8yMH3BAiVL8DtDPPc4iccoAM+ih1Dv70xIRXX+VyJh9CgOgqHvb2BLe 9ox8mULeyXT8Qvxux0jLNM5VIt/G3y/axhHT0vhUMbVFEzzxABD3WGNg5xOMPcWuskob dshJEm30RsSrGNb2Xszlg0s+rVtjKKqo7RXoW380YIDjPemqEux4LP36tp3SWPHcT0B6 MBQYn5SQI0xo7xxt9pllLJh1oEz13DpAuSa4fy4N65TkkXrXnszy+JUhK10811Qs7jwK aYow== X-Gm-Message-State: AO0yUKX16Re3mwlzKaWixMtDAChgDMs0q6Qt81tlBa2bOAwP/mdKQgSU lGbFB7X1Eo/xoZeNphswUi7qFYrR602ekljWuYUrTnMly/2cEz9q X-Google-Smtp-Source: AK7set8N5faR2182ORrje8bpBBZVBGVOnPlkn5WcSKM6lvBxrNhr3R2gbY1riHzXNqPOikvAcLLth0B4+v5C15Lhu8A= X-Received: by 2002:a67:cb89:0:b0:425:e5e6:d1d9 with SMTP id h9-20020a67cb89000000b00425e5e6d1d9mr780727vsl.2.1679392202944; Tue, 21 Mar 2023 02:50:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ken Matsui Date: Tue, 21 Mar 2023 02:49:52 -0700 Message-ID: Subject: Re: [PATCH] c++: implement __add_pointer built-in trait To: gcc-patches@gcc.gnu.org Cc: Patrick Palka Content-Type: multipart/alternative; boundary="000000000000b2060505f765f74d" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b2060505f765f74d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Please disregard this patch. On Mon, Mar 20, 2023 at 12:44=E2=80=AFAM Ken Matsui wrote: > This patch implements built-in trait for std::add_pointer. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __add_pointer. > * semantics.cc (finish_trait_type): Handle CPTK_ADD_POINTER. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __add_pointer. > * g++.dg/ext/add_pointer.C: New test. > > --- > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index bac593c0094..07fab8db26b 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -91,6 +91,7 @@ DEFTRAIT_TYPE (REMOVE_CV, "__remove_cv", 1) > DEFTRAIT_TYPE (REMOVE_REFERENCE, "__remove_reference", 1) > DEFTRAIT_TYPE (REMOVE_CVREF, "__remove_cvref", 1) > DEFTRAIT_TYPE (UNDERLYING_TYPE, "__underlying_type", 1) > +DEFTRAIT_TYPE (ADD_POINTER, "__add_pointer", 1) > > /* These traits yield a type pack, not a type, and are represented by > cp_parser_trait as a special BASES tree instead of a TRAIT_TYPE tree. > */ > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 87c2e8a7111..3527f596983 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12273,6 +12273,10 @@ finish_trait_type (cp_trait_kind kind, tree > type1, tree type2) > if (TYPE_REF_P (type1)) > type1 =3D TREE_TYPE (type1); > return cv_unqualified (type1); > + case CPTK_ADD_POINTER: > + if (TYPE_REF_P (type1)) > + type1 =3D TREE_TYPE (type1); > + return build_pointer_type (type1); > > #define DEFTRAIT_EXPR(CODE, NAME, ARITY) \ > case CPTK_##CODE: > diff --git a/gcc/testsuite/g++.dg/ext/add_pointer.C > b/gcc/testsuite/g++.dg/ext/add_pointer.C > new file mode 100644 > index 00000000000..e35873553c8 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/add_pointer.C > @@ -0,0 +1,46 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +SA(__is_same(__add_pointer(int), int*)); > +SA(__is_same(__add_pointer(const int), const int*)); > +SA(__is_same(__add_pointer(volatile int), volatile int*)); > +SA(__is_same(__add_pointer(const volatile int), const volatile int*)); > + > +SA(__is_same(__add_pointer(int*), int**)); > +SA(__is_same(__add_pointer(const int*), const int**)); > +SA(__is_same(__add_pointer(volatile int*), volatile int**)); > +SA(__is_same(__add_pointer(const volatile int*), const volatile int**)); > + > +SA(__is_same(__add_pointer(int* const), int* const*)); > +SA(__is_same(__add_pointer(int* volatile), int* volatile*)); > +SA(__is_same(__add_pointer(int* const volatile), int* const volatile*)); > + > +SA(__is_same(__add_pointer(int&), int*)); > +SA(__is_same(__add_pointer(const int&), const int*)); > +SA(__is_same(__add_pointer(volatile int&), volatile int*)); > +SA(__is_same(__add_pointer(const volatile int&), const volatile int*)); > + > +SA(__is_same(__add_pointer(int&&), int*)); > +SA(__is_same(__add_pointer(const int&&), const int*)); > +SA(__is_same(__add_pointer(volatile int&&), volatile int*)); > +SA(__is_same(__add_pointer(const volatile int&&), const volatile int*)); > + > +SA(__is_same(__add_pointer(int[3]), int(*)[3])); > +SA(__is_same(__add_pointer(const int[3]), const int(*)[3])); > +SA(__is_same(__add_pointer(volatile int[3]), volatile int(*)[3])); > +SA(__is_same(__add_pointer(const volatile int[3]), const volatile > int(*)[3])); > + > +SA(__is_same(__add_pointer(int(*)[3]), int(**)[3])); > +SA(__is_same(__add_pointer(const int(*)[3]), const int(**)[3])); > +SA(__is_same(__add_pointer(volatile int(*)[3]), volatile int(**)[3])); > +SA(__is_same(__add_pointer(const volatile int(*)[3]), const volatile > int(**)[3])); > + > +SA(__is_same(__add_pointer(int(* const)[3]), int(* const*)[3])); > +SA(__is_same(__add_pointer(int(* volatile)[3]), int(* volatile*)[3])); > +SA(__is_same(__add_pointer(int(* const volatile)[3]), int(* const > volatile*)[3])); > + > +SA(__is_same(__add_pointer(int(int)), int(*)(int))); > +SA(__is_same(__add_pointer(int(* const)(int)), int(* const*)(int))); > +SA(__is_same(__add_pointer(int(* volatile)(int)), int(* volatile*)(int))= ); > +SA(__is_same(__add_pointer(int(* const volatile)(int)), int(* const > volatile*)(int))); > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index f343e153e56..bed4f932bfa 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -146,3 +146,6 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__add_pointer) > +# error "__has_builtin (__add_pointer) failed" > +#endif > --000000000000b2060505f765f74d--