From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) by sourceware.org (Postfix) with ESMTPS id 9C77D3858C2F for ; Mon, 20 Mar 2023 08:32:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C77D3858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-ua1-x929.google.com with SMTP id g9so2820477uam.9 for ; Mon, 20 Mar 2023 01:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1679301177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UG8LCDeEPVCXvVQwqm/++k9CeTvNlgZz0dJQCPdR3H0=; b=Vgrzf1QvCmzd/LFHprxwvX8SGs4yqIow4X8Eb2hhKffzMHlUiD6yWS+s2Sz8EzliL0 YrETLeof3PgM7b+YaLwOuEmZPi/ZTiIwsXliOqWCbv6ZP9mFOl9cLkrbbRZURmoV59/S tDZycli0QyyT3IwZt4eap0l4/jQzdvLQwv5Ys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679301177; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UG8LCDeEPVCXvVQwqm/++k9CeTvNlgZz0dJQCPdR3H0=; b=h2jdIJLVeaugEJoEJGnwuXUlKXJOa/v3Mougju88Z8t4q0US12ZucDmHtr7ApAx1bQ KI9oLaeL32az66XkqZhkV/oFVewZ179LdZ/NpkVNzFMQnH9jXmWsilTN5a5LUAAOpCeS wboKpMZd/kCDNb9Ee0hT1ZGCfp0zW6nXpwXalgJRaMfXtudc5SR5D1hoXJUt5R4zp6Pf vOKjOILAjapM+sAPa344UC3AYif40uLyx0sDpYRMotGj8dFDohFK0VOCf+gqoZPhXVyf Ot0mbSaTuMXo6ybSZjIqS/NHgupCMmpaFhnIZUb1qnz9ZqeugxUXHUph3mlA5aPbME7d 8kiw== X-Gm-Message-State: AO0yUKVVuRLumbiEFOZMYFBaCqfO7UQFQjul1nyt243eHC5V9HAyLX6K VinAoREZcADTXImyo9V6d5+iK2XYjy5mBZR5V7+aww== X-Google-Smtp-Source: AK7set+woqV2XV5pMWsY4yTnKxBMiMiWMzqyLUWpeKxOAcXJzGCiEgGsefoyNdBJj/PQpe7kjlUzeOlWg/AI8K0DtRE= X-Received: by 2002:a1f:17cd:0:b0:41d:acb5:6c1c with SMTP id 196-20020a1f17cd000000b0041dacb56c1cmr3258786vkx.2.1679301176906; Mon, 20 Mar 2023 01:32:56 -0700 (PDT) MIME-Version: 1.0 References: <45e80ead7387ef50026922c217a33719bfc66a4a.camel@xry111.site> <830648d9293be2e7895e0b40ccac9cce16858aa3.camel@xry111.site> In-Reply-To: <830648d9293be2e7895e0b40ccac9cce16858aa3.camel@xry111.site> From: Ken Matsui Date: Mon, 20 Mar 2023 01:32:46 -0700 Message-ID: Subject: Re: [PATCH] libstdc++: use new built-in trait __is_reference To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, Patrick Palka , libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you! On Mon, Mar 20, 2023 at 1:07=E2=80=AFAM Xi Ruoyao wrot= e: > > On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote: > > Oops, I assumed those were my email... Thank you for your heads up and > > your comments! > > > > > Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, nor > > > nothing) to indent the ChangeLog content. > > > > Do you mean like the following? > > > > ``` > > libstdc++-v3/ChangeLog: > > > > [TAB]* include/std/type_traits (is_reference): Use __is_reference > > built-in > > trait. > > ``` > > Yep. > > > > Is there any benefit to use a builtin, instead of the existing > > > implementation? I can see no but maybe I'm stupid. > > > > My patches are based on the GSoC project "C++: Implement compiler > > built-in traits for the standard library traits". These built-in > > traits basically make the compilation faster. > > > > https://gcc.gnu.org/wiki/SummerOfCode > > Ok, to me making compilation faster is a valid reason. > > > > The patch fails to apply. It seems because your mail client inserted= an > > > additional newline before "b/". Try to use git-send-email or configu= re > > > the mail client properly. > > > > Let me try to use git-send-email instead. I stupidly don't understand > > how to use them, so I was making my patches manually... > > Or adjust the mail client correctly. You can send the patch to yourself > first and see if it's not "mangled" by the mail client when you debug > such an issue... > > But when you finally end up sending 10 patches in a series you'll find > git send-email much easier :). > > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University