From: Alex Henrie <alexhenrie24@gmail.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, msebor@gcc.gnu.org
Subject: Re: [PATCH] PR c/86407 - Add option to ignore fndecl attributes on function pointers
Date: Sat, 25 May 2019 17:20:00 -0000 [thread overview]
Message-ID: <CAMMLpeRK8h4_N-vRrBCD1ypjdeRK0HuGgCUU_EgQtq8fvCC_zw@mail.gmail.com> (raw)
In-Reply-To: <3E00946D-43BA-42AA-A7C5-58F958FABFDE@suse.de>
On Sat, May 25, 2019 at 12:34 AM Richard Biener <rguenther@suse.de> wrote:
>
> On May 24, 2019 5:49:38 PM GMT+02:00, Alex Henrie <alexhenrie24@gmail.com> wrote:
> >As far as I can tell, "fndecl" is a misnomer: these attributes are
> >more accurately called "function definition attributes", i.e.
> >attributes that affect the assembly code of the function but do not
> >affect its calling convention.
>
> Yes. The others are attributes also applicable to function types to properly support attributed indirect calls.
I'm happy to rename ix86_handle_fndecl_attribute to
ix86_handle_fndef_attribute then. Should I do that in this patch or a
separate patch?
-Alex
next prev parent reply other threads:[~2019-05-25 17:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 3:57 Alex Henrie
2019-05-24 8:01 ` Richard Biener
2019-05-24 15:49 ` Alex Henrie
2019-05-25 6:34 ` Richard Biener
2019-05-25 17:20 ` Alex Henrie [this message]
2019-05-27 7:26 ` Richard Biener
2019-05-28 19:41 ` Martin Sebor
2019-05-29 7:16 ` Richard Biener
2019-05-30 8:28 ` Alex Henrie
2019-05-31 1:09 ` Joseph Myers
2019-05-31 5:58 ` Alex Henrie
2019-05-31 8:23 ` Richard Biener
2019-05-31 20:47 ` Alex Henrie
2019-06-03 8:25 ` Richard Biener
2019-06-03 15:17 ` Joseph Myers
2019-05-24 15:23 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMMLpeRK8h4_N-vRrBCD1ypjdeRK0HuGgCUU_EgQtq8fvCC_zw@mail.gmail.com \
--to=alexhenrie24@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).