From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 83AE8386583C for ; Mon, 15 Jan 2024 19:34:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83AE8386583C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83AE8386583C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705347300; cv=none; b=uWyOVnrQy/pQ+1sfuhgI64wK6K2Zqp4wUYSS3LbdZO1/XKh29LhEumvZvDxDeN0GUHHzVRP15fBeYqhGNAVF/W5NgOylbo7m2z9DACVSHxikOTVgmQozI44e78cC+JbWcaapghjpp0DOOLw2rJ9Nr9Gp+QXtHvx5t0Ewt37PTxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705347300; c=relaxed/simple; bh=Gj5Mxli1jA+d8rn+JAaiYgmHqlBEtIG8ZSAgUy8ydzs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=nIEGPFxb9UGd/O/CWOyK4jZXX8A8yKoX/vb1HIuMR7W14gyjxGmaJ0Byh61tkOOXnvR5h3SGxLXboKavKZ1qQKN6mFtHQ+n9MVg6eDSLv22j/iv18x2NnNmqdwZXj4i/GCXfUVTJerTz7R/Na78Fh/tWeSt7v4FGRRgY+Wf4vW4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705347298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gLdj1w4g18zMoMvDi16hsc1QHSq0habAK1ktqI4feCc=; b=fwG5kcqzs+q58zvEBzQZouYSPTJ3Yd09GUTIvkjtxOaAon3dbNVfrvWzh4TJBSJRrODwzn NY+g2lr0UNl8EigfOsyamFRrKqyzPe0UoQFExDA43Ui10xe62BqRLqvLiKPOnoB0uaDJn2 FbyIzh3uZI7M7K9VQf2lx6RGdcZLH6o= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-bIme3aUUMOyhkj1MyEQrOw-1; Mon, 15 Jan 2024 14:34:55 -0500 X-MC-Unique: bIme3aUUMOyhkj1MyEQrOw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2cce9488687so81772701fa.2 for ; Mon, 15 Jan 2024 11:34:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705347293; x=1705952093; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gLdj1w4g18zMoMvDi16hsc1QHSq0habAK1ktqI4feCc=; b=HuQkAWpr/wTM8PPIA77MO60/0pg0+S4mh3YkrORxCM0+hwmJv3sITteAKRtn/m9G9a fF3FgivO7Kg/0NpjyeSH3rKTmNHOrU2fL4hWkuGULDUgbO/f/+iGGyxatBFmdov3PbYk bJHHYuQjTTpGX2sKalHSYti+Hkrcfml7D/R8QNTiRWptUnCGsMzdtSjWU922K70w2hL/ 4uQq++nPnGPL6zapaPyriXUq2N+7qvH2pD0tJcY5rmMT9Tq6TTiJbZv84WHqAC1jXOMd mc2p4uJkG/BlE6v5dXc64bQiuFA07x4Bq/9ow3bFfaLDpOzjbkt09t+WYQL3va2PRi7A pGVA== X-Gm-Message-State: AOJu0YwEaUz9RyF6iJMyrmF1Mgehhl+C24qdAIzYJdZnw5K+oSftl39e +zGG99diOU8WV1VrFyrrInXCp1B8pMDIKiCxy5dJOyf+Il4jYeBlccUbf6+5LWfh4JDGhaoRO2d 8FTcj+Q/P5EwEezX6KZ5sPSwH9w1h4uchkwBkxnZpdoqbaVZqEQ== X-Received: by 2002:a2e:964c:0:b0:2cd:4c1e:fdcb with SMTP id z12-20020a2e964c000000b002cd4c1efdcbmr2620782ljh.93.1705347293201; Mon, 15 Jan 2024 11:34:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpliOE/G6DhdiArUhXCX0n8mt0dqiVb4px2Ir+IFHMoBzsdnJsFY2cxxQsekrtnjL2/BP2zKDwTwiE+3CWV/k= X-Received: by 2002:a2e:964c:0:b0:2cd:4c1e:fdcb with SMTP id z12-20020a2e964c000000b002cd4c1efdcbmr2620779ljh.93.1705347292915; Mon, 15 Jan 2024 11:34:52 -0800 (PST) MIME-Version: 1.0 References: <20240105165056.571235-1-ppalka@redhat.com> In-Reply-To: <20240105165056.571235-1-ppalka@redhat.com> From: Patrick Palka Date: Mon, 15 Jan 2024 14:34:42 -0500 Message-ID: Subject: Re: [PATCH] c++: address of NTTP object as targ [PR113242] To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 5, 2024 at 11:50=E2=80=AFAM Patrick Palka w= rote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK > for trunk and perhaps 13? Ping. > > -- >8 -- > > invalid_tparm_referent_p was rejecting using the address of a class NTTP > object as a template argument, but this should be fine. > > PR c++/113242 > > gcc/cp/ChangeLog: > > * pt.cc (invalid_tparm_referent_p) : Suppress > DECL_ARTIFICIAL rejection test for class NTTP objects. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp2a/nontype-class61.C: New test. > --- > gcc/cp/pt.cc | 3 ++- > gcc/testsuite/g++.dg/cpp2a/nontype-class61.C | 27 ++++++++++++++++++++ > 2 files changed, 29 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/cpp2a/nontype-class61.C > > diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc > index 154ac76cb65..8c7d178328d 100644 > --- a/gcc/cp/pt.cc > +++ b/gcc/cp/pt.cc > @@ -7219,7 +7219,8 @@ invalid_tparm_referent_p (tree type, tree expr, tsu= bst_flags_t complain) > * a string literal (5.13.5), > * the result of a typeid expression (8.2.8), or > * a predefined __func__ variable (11.4.1). */ > - else if (VAR_P (decl) && DECL_ARTIFICIAL (decl)) > + else if (VAR_P (decl) && !DECL_NTTP_OBJECT_P (decl) > + && DECL_ARTIFICIAL (decl)) > { > if (complain & tf_error) > error ("the address of %qD is not a valid template argument= ", > diff --git a/gcc/testsuite/g++.dg/cpp2a/nontype-class61.C b/gcc/testsuite= /g++.dg/cpp2a/nontype-class61.C > new file mode 100644 > index 00000000000..90805a05ecf > --- /dev/null > +++ b/gcc/testsuite/g++.dg/cpp2a/nontype-class61.C > @@ -0,0 +1,27 @@ > +// PR c++/113242 > +// { dg-do compile { target c++20 } } > + > +struct wrapper { > + int n; > +}; > + > +template > +void f1() { > + static_assert(X.n =3D=3D 42); > +} > + > +template > +void f2() { > + static_assert(X->n =3D=3D 42); > +} > + > +template > +void g() { > + f1(); > + f2<&X>(); > +} > + > +int main() { > + constexpr wrapper X =3D {42}; > + g(); > +} > -- > 2.43.0.254.ga26002b628 >