From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CB5713858D1E for ; Wed, 2 Aug 2023 16:52:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB5713858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690995131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Dnu9x65AshBhQc0iDnjALDSQbLCQ/SMwGv5TmVBsgo=; b=AYGyNeAHID79FYd93Ie6n3zW+fD01s9ki144AoB5lKWFabfr3U+bmxYIcPlRdKmuLN5R+c QjYlZBE3GSMKqg0n8Rwf0QmIF/UqhLH4Om4ZNWHS3otvIQrNSY+6ZnzDpAbndSBf/zJQ3F KgIDmiNTXpFMtXBrdhXIq9rnkCiuhOc= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-HEcKlf-0OP-SGOymz6XCrw-1; Wed, 02 Aug 2023 12:52:10 -0400 X-MC-Unique: HEcKlf-0OP-SGOymz6XCrw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b9e9a85a42so38448011fa.3 for ; Wed, 02 Aug 2023 09:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690995128; x=1691599928; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5Dnu9x65AshBhQc0iDnjALDSQbLCQ/SMwGv5TmVBsgo=; b=OaVhROrjX3iPz3F/MDb6v3CmTNX7/3DSRaPYSBwBBHEjLJnnb07p68jznVQvd+hYiv FUfjusW20tUnW0d8voS8ep5QJTn1H1mLqWYeMpfNdiHbzNWo3fnvHW0MGIDhoRuDRDQe h97t9qAKnXjDf6+ij3tzTPZitJ+vReHrBd0oqoAcz8V/fQd9zPlHmOR3Fa0o2n7tEfkf OjITMC/geS66VQBjMpydLQjsTtKF+IKWUYj+uOgHTIL/duHx8lim+Hul7Hf4lVh4VZo8 iAxfKi0F3mSR8GWknFNdbyih8ep1HKDalVlU5XT6a0tT9I8xwTcngGfkAQ8CSibhgu08 KqBg== X-Gm-Message-State: ABy/qLZTVqiUVL0pTZioiJy3eEN667ePZrhwFys5jYgD/nYujccoLUC7 6ydyivxgw1ilWFtpm/CPZ9SKcsccbpdrT+Xl0wp1IasdhM0583yQFPubCBbR1blx3RZPndt6Fa2 SSJIFDNrTZ2wfh+WB6852UeEO8Fu1BLSCZg== X-Received: by 2002:a2e:9ec1:0:b0:2b9:acad:b4b8 with SMTP id h1-20020a2e9ec1000000b002b9acadb4b8mr4973925ljk.52.1690995128744; Wed, 02 Aug 2023 09:52:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlGk8pM9VXO5/GMJ5L/APz1kanrKzvohyL9bIwg+18WX+eyN2NRkuDdgn2BrMyhsbgbj5fFcFvH7fsamnL3u+Z8= X-Received: by 2002:a2e:9ec1:0:b0:2b9:acad:b4b8 with SMTP id h1-20020a2e9ec1000000b002b9acadb4b8mr4973909ljk.52.1690995128407; Wed, 02 Aug 2023 09:52:08 -0700 (PDT) MIME-Version: 1.0 References: <20230513232321.279733-1-rep.dot.nop@gmail.com> <20230513232321.279733-5-rep.dot.nop@gmail.com> <20230601183346.71664610@nbbrfq.loc> <20230601201007.28f7ca15@nbbrfq.loc> In-Reply-To: <20230601201007.28f7ca15@nbbrfq.loc> From: Patrick Palka Date: Wed, 2 Aug 2023 12:51:57 -0400 Message-ID: Subject: Re: [PATCH 04/14] c++: use _P() defines from tree.h To: Bernhard Reutner-Fischer Cc: David Malcolm , gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 1, 2023 at 2:11=E2=80=AFPM Bernhard Reutner-Fischer wrote: > > Hi David, Patrick, > > On Thu, 1 Jun 2023 18:33:46 +0200 > Bernhard Reutner-Fischer wrote: > > > On Thu, 1 Jun 2023 11:24:06 -0400 > > Patrick Palka wrote: > > > > > On Sat, May 13, 2023 at 7:26=E2=80=AFPM Bernhard Reutner-Fischer via > > > Gcc-patches wrote: > > > > > > diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc > > > > index 131b212ff73..19dfb3ed782 100644 > > > > --- a/gcc/cp/tree.cc > > > > +++ b/gcc/cp/tree.cc > > > > @@ -1173,7 +1173,7 @@ build_cplus_array_type (tree elt_type, tree i= ndex_type, int dependent) > > > > } > > > > > > > > /* Avoid spurious warnings with VLAs (c++/54583). */ > > > > - if (TYPE_SIZE (t) && EXPR_P (TYPE_SIZE (t))) > > > > + if (CAN_HAVE_LOCATION_P (TYPE_SIZE (t))) > > > > > > Hmm, this change seems undesirable... > > > > mhm, yes that is misleading. I'll prepare a patch to revert this. > > Let me have a look if there were other such CAN_HAVE_LOCATION_P changes > > that we'd want to revert. > > Sorry for that! > I'd revert the hunk above and the one in gcc-rich-location.cc > (maybe_range_label_for_tree_type_mismatch::get_text), please see > attached. Bootstrap running, ok for trunk if it passes? LGTM! > > thanks,