From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by sourceware.org (Postfix) with ESMTPS id BE14F3858D35 for ; Sun, 25 Jun 2023 01:23:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE14F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-570002c9b38so20148707b3.1 for ; Sat, 24 Jun 2023 18:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687656201; x=1690248201; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K6x9+GmT+SXmtfFpuMI4CMZCgyf3kaD/9/hyApVk55c=; b=fYwrK8E/QUpQ/XXVozbU/u9yom0vUy6X5N3Sa+YC9g6RmESQ1255ZN+hvLNg0JEmMe 4nD9uMVM15Zt4zSkCE9f7R/oc8Yic34m4lB9Xyt19Q+m44mRRIBLV/CiO1OiDyZzPUqs Qrs7f2GJK9GpkZ6tEKP6gSFpFBVLa7ZeTpTJBbQBk7AUEj0n7iB3+/LqPimDiz4Jf8Mt 7LWE6o4JEJrX6FVsy39JxGvTGgOuSZp7PxA8HZtGiBfYo+54R8bwAK3FmtKepItOE1to k1LzmMNeMTfEAKT4ihVptyCu+emu7fnfbLbYmJDiWURWM7YXD3WhDrhuCgJI9P0trm// YqOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687656201; x=1690248201; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K6x9+GmT+SXmtfFpuMI4CMZCgyf3kaD/9/hyApVk55c=; b=ldXnI6hqzLm9dN98Y2IpbBkFA8UyOw0Q5u1i1wGXDGue29dRBe5SvPMdX3t94VCdLK Oyae/KrQg3jyr5b/yuVkdgh/muTTIHNpesj3b/ApkqpfYgsGJ0UlzvfgCGIVD+cf5doR TUdBe3h+1NjRmFiXWN11DvBqIvH5YPFes9we8wP8wP6hBr2XN3oBGZDp53AvMe1/+Tsk p4zbhDfvUKm1eVJI5MgGwCDM4+N5ocZpNBZ6GTy4Cjk6ZQi/eHqnyBoDdmQk6NrbDl4G gvwiBXu4hmdmY7XYoQrkCyGIeG+C/AcAHSKwP9VMBhzIU0hitUhKckaNDaBRvvgtG3nR 338g== X-Gm-Message-State: AC+VfDxJ/DCoGACXJ9mGpnhxD9V2jL9s+REe5yPsgCnVdgQTo/+46Mpb TvZctVIMTfBEhDbOjnvaO9f9euTseolHxHdtEhM= X-Google-Smtp-Source: ACHHUZ6HFT0QY8ZZK5LNXBz2EDfIsKb0lTBtUF/OC1Ue59OsgsOPL3+yhKM8pYCwAs1WgLet+RsbUYPJM7A76W9jCNo= X-Received: by 2002:a0d:ccd5:0:b0:571:a4c8:c403 with SMTP id o204-20020a0dccd5000000b00571a4c8c403mr21360760ywd.26.1687656201015; Sat, 24 Jun 2023 18:23:21 -0700 (PDT) MIME-Version: 1.0 References: <87531fc5-1663-fd2f-7ea4-22a8d916949a@suse.com> In-Reply-To: From: Hongtao Liu Date: Sun, 25 Jun 2023 09:23:10 +0800 Message-ID: Subject: Re: [PATCH v2] x86: make better use of VBROADCASTSS / VPBROADCASTD To: "Liu, Hongtao" Cc: "Beulich, Jan" , "gcc-patches@gcc.gnu.org" , Kirill Yukhin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jun 25, 2023 at 9:17=E2=80=AFAM Liu, Hongtao wrote: > > > > > -----Original Message----- > > From: Jan Beulich > > Sent: Wednesday, June 21, 2023 8:40 PM > > To: Hongtao Liu > > Cc: gcc-patches@gcc.gnu.org; Kirill Yukhin ; L= iu, > > Hongtao > > Subject: Re: [PATCH v2] x86: make better use of VBROADCASTSS / > > VPBROADCASTD > > > > On 21.06.2023 09:44, Jan Beulich wrote: > > > On 21.06.2023 09:37, Hongtao Liu wrote: > > >> On Wed, Jun 21, 2023 at 2:06=E2=80=AFPM Jan Beulich via Gcc-patches > > >> wrote: > > >>> > > >>> Isn't prefix_extra use bogus here? What extra prefix does > > >>> vbroadcastss > > >> According to comments, yes, no extra prefix is needed. > > >> > > >> ;; There are also additional prefixes in 3DNOW, SSSE3. > > >> ;; ssemuladd,sse4arg default to 0f24/0f25 and DREX byte, ;; > > >> sseiadd1,ssecvt1 to 0f7a with no DREX byte. > > >> ;; 3DNOW has 0f0f prefix, SSSE3 and SSE4_{1,2} 0f38/0f3a. > > > > > > Right, that's what triggered my question. I guess dropping these > > > "prefix_extra" really wants to be a separate patch (or maybe even > > > multiple, but it's hard to see how to split), dealing with all of the > > > instances which likely have accumulated simply via copy-and-paste. > > > > Or wait - I'm altering those lines anyway, so I could as well drop them= right > > away (and slightly shrink patch size), if that's okay with you. Of cour= se I > > should then not forget to also mention this in the changelog entry. > > > Yes. >Would you be okay for me to fold in that adjustment, or do you >insist on a separate patch? Also for this, no need for a separate patch. > > Jan --=20 BR, Hongtao