From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by sourceware.org (Postfix) with ESMTPS id 922423851AB8 for ; Thu, 20 Oct 2022 09:20:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 922423851AB8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb33.google.com with SMTP id e62so23893704yba.6 for ; Thu, 20 Oct 2022 02:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J4/ROuWtpm5XjL6QuerHZgwa8aufmIbGDrqQlep/nmo=; b=csceETIBoqA4w6zkOt8HCU+bXxyAOrklx1v+83VRjMx66iRgK1jh6slkphdBBKVDtI z33CexijInyiBFuwfmAUKVpis/vwlBdS/MJ5ysCMu/+T7WsxBf+AsLIjxJX2Eg3gPsj6 skMek8tqvHQyQmvDTxfpshxYMEcpVlslWXInOtDvgXjA3Cp5feG/DMDzWPv1dx7nHYPh SoLdBUrUL0cIIwYx06mbTwPkJkeNpKrshVTwT+YTd9iw4tGJvtzLbLHoJN/KpwSIbItJ F+XJgu867h55mi/Qe0Iqr0OtFtQckOq9WSHqqp85pUbvTmrZFlBjxNMPfjBrj3INdrdl wODA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J4/ROuWtpm5XjL6QuerHZgwa8aufmIbGDrqQlep/nmo=; b=L2nZBHZyQqAdyzTvzEzUCy8VIq5zgJBb9STG11lz8Ay2Cm34JCgscmWFJosP5X10XQ J2OgL/iaB50GHmRksDdA0/PjMVvbGWzAvZMEAThoBnApHW9DOC15sFtqeFjcRT259Qux rolLTkNTWa0Ji/nrE4/RA11RZaw12J1TjvTED34DBK8lLnW+jA1rzeU1ktk8auw91i2e z7VjxHrC8Y/PRk0hbsxRRvYVvX1rzOmgCXk7H2QT61bedshThehvNxa17PuKQ4FPtd4o CauJZc5xhe/jI66ODc1Vg43+7iMlKzALkkco7UMwq2cSCafnMDt9+BnktlzPyW6LIz4q wT1A== X-Gm-Message-State: ACrzQf0pnt345OazWjzS56p7QgX0ndiytLemFYPmYUe+DrPrue/glDCw rII4W0pAYOX4sx1FjNQfVAGVx/f9KlCbbkG5KfI= X-Google-Smtp-Source: AMsMyM7PYtP1leyWKOabFvAyqL3txJfgyW8p46NwzZx5huf1UT9rvIdUs+PxLqFulOTLTYXXe0n2x4MQvscOfLphG6Y= X-Received: by 2002:a05:6902:1145:b0:6bf:aab0:fcb with SMTP id p5-20020a056902114500b006bfaab00fcbmr10563397ybu.251.1666257614584; Thu, 20 Oct 2022 02:20:14 -0700 (PDT) MIME-Version: 1.0 References: <20221014075445.7938-1-haochen.jiang@intel.com> <59C4B6AD-CC12-4D2A-9F9E-E44404BDF41A@googlemail.com> <4D6C9639-D637-454C-82DF-925830604EEC@googlemail.com> In-Reply-To: <4D6C9639-D637-454C-82DF-925830604EEC@googlemail.com> From: Hongtao Liu Date: Thu, 20 Oct 2022 17:20:03 +0800 Message-ID: Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions To: Iain Sandoe Cc: "Lu, Hongjiu" , hongtao.liu@intel.com, GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 20, 2022 at 5:17 PM Iain Sandoe wrote= : > > > > > On 20 Oct 2022, at 10:09, Hongtao Liu via Gcc-patches wrote: > > > > On Thu, Oct 20, 2022 at 9:11 AM Hongtao Liu wrote: > >> > >> On Wed, Oct 19, 2022 at 7:09 PM Iain Sandoe = wrote: > >>> > >>> Hi Hongtao > >>> > >>>> On 17 Oct 2022, at 02:56, Hongtao Liu wrote: > >>>> > >>>> On Mon, Oct 17, 2022 at 9:30 AM Bernhard Reutner-Fischer > >>>> wrote: > >>>>> > >>>>> On 17 October 2022 03:02:22 CEST, Hongtao Liu via Gcc-patches > >>>>> > >>>>>>>>> Do you have this series as a branch somewhere that I can try on= one of the > >>>>>>>>> like affected platforms? > >>>>>>>> > >>>>>>>> Not yet. > >>>>>>>> Do we have any external place to put those patches so folks from= the > >>>>>>>> community can validate before it's committed, HJ? > >>>>> > >>>>> > >>>>> https://gcc.gnu.org/gitwrite.html#vendor > >>>>> > >>>>> Not sure where in cgit the user branches are visible, though? But t= hey can certainly be cloned and worked with. > >>>> Thanks for the reminder, I've pushed to remotes/vendors/ix86/ise046. > >>>> * [new ref] refs/vendors/ix86/heads/ise046 -> > >>>> vendors/ix86/ise046 > >>> > >>> thanks for pushing this branch, much better to test these things befo= re committing rather than a panic > >>> to fix after=E2=80=A6 > >>> > >>> > >>> with > >>> f90df941532 (HEAD -> ise046, vendors/ix86/ise046) Add m_CORE_ATOM for= atom cores > >>> > >>> - on x86_64 Darwin19 I get the following bootstrap fail: > >>> > >>> In file included from /src-local/gcc-master/gcc/config/i386/driver-i3= 86.cc:31: > >>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h: In function = =E2=80=98const char* get_intel_cpu(__processor_model*, __processor_model2*,= unsigned int*)=E2=80=99: > >>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h:532:32: error:= this statement may fall through [-Werror=3Dimplicit-fallthrough=3D] > >>> 532 | cpu_model->__cpu_subtype =3D INTEL_COREI7_GRANITERAPIDS; > >>> | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >>> /src-local/gcc-master/gcc/common/config/i386/cpuinfo.h:533:5: note: h= ere > >>> 533 | case 0xb6: > >>> | ^~~~ > >>> cc1plus: all warnings being treated as errors > >>> > >>> =3D=3D=3D=3D > >>> Will try to look later, if that does not immediately ring some bell. > >> This should a bug, thanks! > > I've updated the branch, please try that. > > I had made the same fix locally (adding the =E2=80=9Cbreak=E2=80=9D, righ= t?) and testing is ongoing Yes, please go ahead. > > it would not be surprising if some tests failed (asm matches for differen= t ABIs are rarely > identical) - a few tests to be fixed in stage 3 is fine ... > > ... but what I wanted to avoid was the case like the bf16 changes where e= very > single new test fails (I have a draft patch to fix the bf16 stuff to be p= osted soon). Understand. > > thanks > Iain > > --=20 BR, Hongtao