From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe42.google.com (mail-vs1-xe42.google.com [IPv6:2607:f8b0:4864:20::e42]) by sourceware.org (Postfix) with ESMTPS id C704B38708AC; Tue, 26 May 2020 05:22:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C704B38708AC Received: by mail-vs1-xe42.google.com with SMTP id b28so9070563vsa.5; Mon, 25 May 2020 22:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nhPSFXWRMAa4Cty8iTdkABOWbVIuF5zUFu6nwmd8T9s=; b=JzU7drobm8Cf/VByRJO2mvGJpas0rPZdZwD+p4QsfbwX7JG/V0fWFPRa48irnbR5SC auG0CZcQqhmS6r+ZBjw0e2efGExUaRT5QoDYQtf2jdmT4NLpNFs2+VU8PG/tZmcJ4NOA 5JfEs9Hlzxb2ypbcWf43iArHBCyBgjD5ek5yx9Fk6z5aceVfU2SVBgboLV1FdZz7+jNd takCznBWsWGnrLBKaG2IIDhd6lq+hg9x60nKoXjPjIEThMtI5J5iyLugP0Do+q8rXhEj TDwZwLFyKPNWplfY2axe/mfrVaSnczMW76ddQ9RMKeN9EqrAU898kqpgYsSZsqWZFiPK T6tQ== X-Gm-Message-State: AOAM533vdlbRdX+xc3Hoo3YcpA52COkJOb5Ld4KTAmqYYBb9ESxv2ZLA taS9Cnlxwb8LQQUxuAzHB7wrcTqwfuGCE49xVyQ= X-Google-Smtp-Source: ABdhPJzZCrgX3mEBCyvFSsUv4OK/RDZ/KAksV/Q9sgSHrObEJayV6afXC6m1NI3F9g06C37hwUjJc7G+4QJqQltIOAU= X-Received: by 2002:a67:ec58:: with SMTP id z24mr17672622vso.200.1590470569404; Mon, 25 May 2020 22:22:49 -0700 (PDT) MIME-Version: 1.0 References: <20200525224858.GO8462@tucnak> In-Reply-To: <20200525224858.GO8462@tucnak> From: Hongtao Liu Date: Tue, 26 May 2020 13:22:31 +0800 Message-ID: Subject: Re: [IMPORTANT] ChangeLog related changes To: Jakub Jelinek Cc: gcc@gcc.gnu.org, GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 05:22:50 -0000 On Tue, May 26, 2020 at 6:49 AM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > I've turned the strict mode of Martin Li=C5=A1ka's hook changes, > which means that from now on no commits to the trunk or release branches > should be changing any ChangeLog files together with the other files, > ChangeLog entry should be solely in the commit message. > The DATESTAMP bumping script will be updating the ChangeLog files for you= . Oh, no wonder my patch was rejected by git hook with error message --- ChangeLog files, DATESTAMP, BASE-VER and DEV-PHASE can be modified only separately from other files --- > If somebody makes a mistake in that, please wait 24 hours (at least until i commit a separate patch alone only for ChangeLog files, should i revert i= t? > after 00:16 UTC after your commit) so that the script will create the > ChangeLog entries, and afterwards it can be fixed by adjusting the Change= Log > files. But you can only touch the ChangeLog files in that case (and > shouldn't write a ChangeLog entry for that in the commit message). > > If anything goes wrong, please let me, other RMs and Martin Li=C5=A1ka kn= ow. > > Jakub > --=20 BR, Hongtao