From: Hongtao Liu <crazylht@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: liuhongt <hongtao.liu@intel.com>,
gcc-patches@gcc.gnu.org, hjl.tools@gmail.com
Subject: Re: [PATCH] [ICE] Support vpcmov for V4HF/V4BF/V2HF/V2BF under TARGET_XOP.
Date: Thu, 14 Dec 2023 09:31:07 +0800 [thread overview]
Message-ID: <CAMZc-bwTcv91OggzUU=_tR3QGrgHO0RHCrz=r7UNtrTGsXx+zA@mail.gmail.com> (raw)
In-Reply-To: <ZXmcmsC9UY7lTCqD@tucnak>
On Wed, Dec 13, 2023 at 7:59 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Fri, Dec 08, 2023 at 03:12:00PM +0800, liuhongt wrote:
> > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}.
> > Ready push to trunk.
> >
> > gcc/ChangeLog:
> >
> > PR target/112904
> > * config/i386/mmx.md (*xop_pcmov_<mode>): New define_insn.
> >
> > gcc/testsuite/ChangeLog:
> >
> > * g++.target/i386/pr112904.C: New test.
>
> The new test FAILs on i686-linux and even on x86_64-linux I think
> it doesn't actually test what was reported, unless one performs testing
> with -march= for some XOP enabled CPU or -mxop.
>
> The following patch fixes that, tested on x86_64-linux with
> make check-g++ RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-mno-sse/-mno-mmx,-m64\} i386.exp=pr112904.C'
> Ok for trunk?
Ok.
Sorry for the inconvenience, I must have missed something in my tester.
>
> 2023-12-13 Jakub Jelinek <jakub@redhat.com>
>
> * g++.target/i386/pr112904.C: Add dg-do compile, dg-options -mxop
> and for ia32 also dg-additional-options -mmmx.
>
> --- gcc/testsuite/g++.target/i386/pr112904.C.jj 2023-12-11 08:31:59.001938798 +0100
> +++ gcc/testsuite/g++.target/i386/pr112904.C 2023-12-13 12:54:50.318521637 +0100
> @@ -1,3 +1,8 @@
> +// PR target/112904
> +// { dg-do compile }
> +// { dg-options "-mxop" }
> +// { dg-additional-options "-mmmx" { target ia32 } }
> +
> typedef _Float16 v4hf __attribute__((vector_size(8)));
> typedef short v4hi __attribute__((vector_size(8)));
> typedef _Float16 v2hf __attribute__((vector_size(4)));
>
>
> Jakub
>
--
BR,
Hongtao
prev parent reply other threads:[~2023-12-14 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 7:12 liuhongt
2023-12-13 11:59 ` Jakub Jelinek
2023-12-14 1:31 ` Hongtao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZc-bwTcv91OggzUU=_tR3QGrgHO0RHCrz=r7UNtrTGsXx+zA@mail.gmail.com' \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hongtao.liu@intel.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).