From: Hongtao Liu <crazylht@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Hongtao Liu <hongtao.liu@intel.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [PATCH 2/2] x86: slightly correct / simplify *vec_extractv2ti
Date: Wed, 5 Jul 2023 18:22:02 +0800 [thread overview]
Message-ID: <CAMZc-bwUcotCD19T5g-CHPSspSs1sCPt-z4hpJSY3jJbaHBtVQ@mail.gmail.com> (raw)
In-Reply-To: <e3fab3c3-dd11-1fd1-64c9-0d388a9d3799@suse.com>
On Wed, Jul 5, 2023 at 5:03 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 05.07.2023 10:47, Hongtao Liu wrote:
> > On Wed, Jul 5, 2023 at 4:01 PM Jan Beulich via Gcc-patches
> > <gcc-patches@gcc.gnu.org> wrote:
> >>
> >> V2TImode values cannot appear in the upper 16 YMM registers without
> >> AVX512VL being enabled. Therefore forcing 512-bit mode (also not
> >> reflected in the "mode" attribute) is pointless.
> > Please set isa attribute for alternative 1 to avx512vl.
>
> Since that looks redundant to me (as per the description), would you
> mind explaining why that's necessary / wanted? It also feels orthogonal
> to the change I'm making, as there was no "isa" attribute so far (which
> would have wanted to be "avx512f" as per what you ask for, prior to the
> change I'm making). Again me asking back is primarily to properly
> describe the changes I'm making, of course along with me still needing
> to properly understand when what attribute needs specifying explicitly.
I checked ix86_hard_regno_ok, TImode/V2TImode will be allocated
with evex sse register only under TARGET_AVX512VL. otherwise
alternative 0 is matched.
So yes, no need to set isa attribute here, patch LGTM.
>
> Jan
--
BR,
Hongtao
next prev parent reply other threads:[~2023-07-05 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:59 [PATCH 0/2] x86: vec_extract_* adjustments Jan Beulich
2023-07-05 8:00 ` [PATCH 1/2] x86: correct / simplify @vec_extract_hi_<mode> and vec_extract_hi_v32qi Jan Beulich
2023-07-05 8:40 ` Hongtao Liu
2023-07-05 8:54 ` Jan Beulich
2023-07-05 10:13 ` Hongtao Liu
2023-07-05 8:00 ` [PATCH 2/2] x86: slightly correct / simplify *vec_extractv2ti Jan Beulich
2023-07-05 8:47 ` Hongtao Liu
2023-07-05 9:03 ` Jan Beulich
2023-07-05 10:22 ` Hongtao Liu [this message]
2023-07-05 10:32 ` Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZc-bwUcotCD19T5g-CHPSspSs1sCPt-z4hpJSY3jJbaHBtVQ@mail.gmail.com \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=jbeulich@suse.com \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).