From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id A054B3858D28 for ; Tue, 21 May 2024 06:17:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A054B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A054B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716272247; cv=none; b=N+W8R9Jm2QM/cHVcII4zOugpoQ+ZmGTLto9Wwclpt8kQdh6LmJ8xdG/RBPJN10lcfsFdy3skNefaOe3B3L554V2nv2NcrMErzmLO0PZxQvvU8Mm4ynd0pDU4mXlWFDTvgYx6ueJSsAYvpcTJCm0PrzVPMN6ubNsdz4SjfUJXtgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716272247; c=relaxed/simple; bh=o0gp6kOUkh2dE2+HSRABWkdVQ4ZI69OUNhtXm+1jNkQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=B7i69YpiUbMT94+BlRb6QIwBSvHhgZh1/ZitWLY9iFggdLUA42KLRmPpMRZy1E1TTmDzBAWhKA7b/8+UfZx5H/mJiTtt7S0dmIsZulVfAflShRu6QTq5FQYzAp2CQgv4owEf96d8Frw1YvrUdFvWyZTE6rViycnmE8bElcysH/0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-69b514d3cf4so36397816d6.0 for ; Mon, 20 May 2024 23:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716272245; x=1716877045; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nUNvqp1Wmarr8ubU+RqJPmwQpLeiZzUGpL5GI/TV00c=; b=aS+sDvrpm7ivbf4laHUdGZ09ZiQSFnXOJQIFPP+W8wDTX0gC4d3FPn+A1FnD/GatlR 6SzK+YTh6PB40gh08roafzoIWaqpaL+lyvZH/LCyZ1txVZ5rnzfNkYmrP00YeP9FllMV hpUhrwK4SIFnRO7rhxRZ5FP86h/p/mX1TXB2cj5zYwmX72Bjf+by6KoQOBQd/tw51udk RkouE1ePwmopBEUpYyDwsvutu2tD6WGlvGtP5/YKORQgb8NsqSpXVxyjYkv5rD9uSnkf Skw3kRSNAa1wuY5SLcY7XZ2lB+Y66H+naFhZYVczf2zpFzoApfKst4ydl2S7LMWGwdxj H96w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716272245; x=1716877045; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nUNvqp1Wmarr8ubU+RqJPmwQpLeiZzUGpL5GI/TV00c=; b=LjjwTdIu1k3zWk4kphNLsbv0p8qkB2/yaZVs3CS1caepIJvchACH5JDErxGjKfLzO/ YbFOenC8i0sJIQ0lOrNzPoIcsgriEg+rsl6gAOe8wK0PjyblELwHrqhZi9TFUtXWMOvp nmIzpHheEyEyTR6eCixvYq8l8no41OjESHM1jogWuCkX0LX0UvuSiCWTiRKtYDldzJfZ mvm3aZhD7PGf22SsBkUd2M7uGaF9mlSN5VCous0tgHyr6VxMgmsXAq0B8UqphwxYJ/0o uVfJYQD8r/RdU6JXUr17+6pDOhbmh/Jy0N40mrOXO3PRI0HYIjbUidmTj50wiIefYpLw 0eMA== X-Gm-Message-State: AOJu0YwuRcNp+4M532GC6wgyYE3KdL7tfl8Fkr/xH98zhI75vzZZfIR9 Hq3L+Ofauhxzhh9bth30jiMcir93V23dzfwuiSgSpzuGsdOaCv8cDAGxnqztxqQTKzu2uVqdwPM 1aQ/QB3dgE4tFOk7DawfzCFmwwfk= X-Google-Smtp-Source: AGHT+IG4sqocrC/uSkafN//ONTTIUq9YjLe0Mftc5G0CeDofHbhzyt0R+m9hTWDrojye2RCAij+z/STgPLB6LkFJkBA= X-Received: by 2002:a05:6214:449d:b0:6a9:9a62:d18e with SMTP id 6a1803df08f44-6a99a62d1a1mr65214366d6.16.1716272244889; Mon, 20 May 2024 23:17:24 -0700 (PDT) MIME-Version: 1.0 References: <20240521061617.667442-1-haochen.jiang@intel.com> In-Reply-To: <20240521061617.667442-1-haochen.jiang@intel.com> From: Hongtao Liu Date: Tue, 21 May 2024 14:17:13 +0800 Message-ID: Subject: Re: [PATCH] i386: Disable ix86_expand_vecop_qihi2 when !TARGET_AVX512BW To: Haochen Jiang Cc: gcc-patches@gcc.gnu.org, hongtao.liu@intel.com, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, May 21, 2024 at 2:16=E2=80=AFPM Haochen Jiang wrote: > > Hi all, > > Since vpermq is really slow, we should avoid using it when it is > the only instruction could be used for ix86_expand_vecop_qihi2. > > Bootstrapped and regtested on x86_64-pc-linux-gnu. Ok for trunk? Please add a testcase for it. > > Thx, > Haochen > > gcc/ChangeLog: > > PR target/115069 > * config/i386/i386-expand.cc (ix86_expand_vecop_qihi2): > Do not enable the optimization when AVX512BW is not enabled. > --- > gcc/config/i386/i386-expand.cc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gcc/config/i386/i386-expand.cc b/gcc/config/i386/i386-expand= .cc > index a6132911e6a..f24c800bb4f 100644 > --- a/gcc/config/i386/i386-expand.cc > +++ b/gcc/config/i386/i386-expand.cc > @@ -24323,6 +24323,11 @@ ix86_expand_vecop_qihi2 (enum rtx_code code, rtx= dest, rtx op1, rtx op2) > bool op2vec =3D GET_MODE_CLASS (GET_MODE (op2)) =3D=3D MODE_VECTOR_INT= ; > bool uns_p =3D code !=3D ASHIFTRT; > > + /* vpermq is slow and we should not fall into the optimization when > + it is the only instruction to be selected. */ > + if (!TARGET_AVX512BW) > + return false; > + > if ((qimode =3D=3D V16QImode && !TARGET_AVX2) > || (qimode =3D=3D V32QImode && (!TARGET_AVX512BW || !TARGET_EVEX51= 2)) > /* There are no V64HImode instructions. */ > -- > 2.31.1 > --=20 BR, Hongtao