From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id 11ABD3858D28 for ; Mon, 6 Nov 2023 13:48:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11ABD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11ABD3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699278519; cv=none; b=VuufxMxoBS7QLQEMbkHDep3FccY8uojljrhgRKkvw9PXUdJu5VLqEwNRMNmKJm1loPYh71bVqgpF8u0Sm4KSZ+BzI/XqJmzvPaUirrMKL2gmpoBhy23jxBBDWskWDeFOAxiR86Zf21LwNHmeZDwyjsUrIp3xOn4ggaST0NZWkl4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699278519; c=relaxed/simple; bh=Iab5vuJyie04Un+hzgs2f2Q6HJ1TB0MPfgYQu//I8vA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=BTtgfWyyeEplo4GCm3pctFyVAmDkPNXotfyZcIral7LDr6b4Wl0HJBCbhbclLAZ+jA1Rj3lsFHl1BEKuWIKeoxR18OimNTZ6AHFIzABW9j/o1P/ci6SWk3rlNZKMoJkhmW4gxITU+0nmwhHNd/wECxJUw+S7buuzvvKU+yOT9E0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d865854ef96so4527390276.2 for ; Mon, 06 Nov 2023 05:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699278517; x=1699883317; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Iab5vuJyie04Un+hzgs2f2Q6HJ1TB0MPfgYQu//I8vA=; b=X5UQ8q/Oo7JXsoOgRHCQyq5zFtJc2AzmXlwY6p75A0MlpKUDY9He4jcU1ikFXTDVYS DKZiXp1j+UPbh6ImaASnv3t3bhafW+sZV7bymsQNs9QieI9ZSFbhcNQKUZU06HqyGG/Q l6bjbx1oiKGaEhfJu4EeJ7S0O93XPYXh8hNfXEccTATAJHY2Au4Z7D6P5hoZjtwsWifV g+y+A4l77CBpPaainL8B+G39gkENTEYJFiMHhvGfEHUiVCa7oXlmUoyjkxr2rIKfwVMO aJmsMeJXTydtYLmGKZ15EOP3anYNvkOWfzIorTGAzWbi6ogLQh5vbpenQ53qgp3DZc+b K0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699278517; x=1699883317; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iab5vuJyie04Un+hzgs2f2Q6HJ1TB0MPfgYQu//I8vA=; b=pzQzhBGomj6EQrRnV3VeBIFILDsaXGF3a/eKQ3hF6P99gGj2+e8t+2LkrbznsD7nDf nZr3lgeXaa4zZlTTE6ziAjsPIQ1JA9V7zPv33y3vR/aMO2aG7tW/niOozVK9/FMzZV+6 nSPdXL9ElPHSYR4GgZXDC+kXH+MKk586eh+Xv5vYwwhyCPJ4CwMtXht9P3ELQ528lE8k IcSzoL/5Rm3riOHd+ko+hMPWGcVdDZ4tzSBCJsQv8kYX/GY5vCuZSG77O6OI4txn3MHX 1jFR8l8RvQmwPgSdlOSbpP1LxD8Ff2rTXJVT9LQAZRNvZCay6QrSGsxz0Lb0HIRU7bdO dUIg== X-Gm-Message-State: AOJu0YwfGZhvdezUMto8gTeIh5oXleId2aiEHdknblz3ZLxQkaC+IfzB v9Ns6MymrQQkhdO5QLKb3w+m93f35Cyt37ov8uM= X-Google-Smtp-Source: AGHT+IGQr2kfaYVCC2Mcjq2PGT4/Uh1ZFtAeQ46pCMPz5dv98e/aGzOtC/RfxKKN2MVDQArGqMsXKXwPPUuuh9oz5Ig= X-Received: by 2002:a05:6902:1209:b0:da0:52e4:b5aa with SMTP id s9-20020a056902120900b00da052e4b5aamr33998155ybu.8.1699278517308; Mon, 06 Nov 2023 05:48:37 -0800 (PST) MIME-Version: 1.0 References: <04f99abe-a563-d093-23b7-4abf0f91633d@suse.com> <0075f542-9dc0-33db-4cf9-cdd3ba502122@suse.com> <460e0857-2ee9-d946-4067-9569fa767420@suse.com> <54cd054c-003a-fee7-bfbc-3246058ae2b7@suse.com> In-Reply-To: <54cd054c-003a-fee7-bfbc-3246058ae2b7@suse.com> From: Hongtao Liu Date: Mon, 6 Nov 2023 21:48:25 +0800 Message-ID: Subject: Re: [PATCH 5/5] x86: yet more PR target/100711-like splitting To: Jan Beulich Cc: "gcc-patches@gcc.gnu.org" , Hongtao Liu , Kirill Yukhin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 6, 2023 at 7:10=E2=80=AFPM Jan Beulich wrot= e: > > On 25.06.2023 08:41, Hongtao Liu wrote: > > On Sun, Jun 25, 2023 at 2:35=E2=80=AFPM Hongtao Liu wrote: > >> > >> On Sun, Jun 25, 2023 at 2:25=E2=80=AFPM Jan Beulich wrote: > >>> > >>> On 25.06.2023 07:12, Hongtao Liu wrote: > >>>> On Wed, Jun 21, 2023 at 2:29=E2=80=AFPM Jan Beulich via Gcc-patches > >>>> wrote: > >>>>> > >>>>> --- > >>>>> For the purpose here (and elsewhere) bcst_vector_operand() (really: > >>>>> bcst_mem_operand()) isn't permissive enough: We'd want it to allow > >>>>> 128-bit and 256-bit types as well irrespective of AVX512VL being > >>>>> enabled. This would likely require a new predicate > >>>>> (bcst_intvec_operand()?) and a new constraint (BR? Bi?). (Yet for n= ame > >>>>> selection it will want considering that this is applicable to certa= in > >>>>> non-calculational FP operations as well.) > >>>> I think so. > >>> > >>> Any preference towards predicate and constraint naming? > >> something like bcst_mem_operand_$suffiix, $suffix indicates the > >> pattern may use zmm instruction for 128/256-bit operand. > >> maybe just bcst_mem_operand_zmm? > > For constraint, maybe we can reuse Br, relax Br to match bcst_mem_opera= nd_zmm. > > For those original patterns with bcst_mem_operand, it should be ok > > since it's already guarded by the predicate, the constraint must be > > valid. > > Hmm, I wanted to get back to this, but then I started wondering about thi= s > reply of yours vs your request to not go farther with the use of "oversiz= ed" > insns (i.e. acting in 512-bit registers in lieu of AVX512VL being enabled= , > when no FP exceptions can be raised on the otherwise unused elements). Si= nce > iirc the latter came later, am I right in assuming we then also shouldn't= go > the route outlined above? No, we shouldn't. This reply is just an answer on how to do it technically, but we don't really want to do it (considering that all AVX512 processors after SKX will all support AVX512VL) > > Jan --=20 BR, Hongtao