From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <crazylht@gmail.com>
Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com
 [IPv6:2607:f8b0:4864:20::935])
 by sourceware.org (Postfix) with ESMTPS id 8A2C43850401
 for <gcc-patches@gcc.gnu.org>; Fri,  8 Jan 2021 03:30:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8A2C43850401
Received: by mail-ua1-x935.google.com with SMTP id k47so3020318uad.1
 for <gcc-patches@gcc.gnu.org>; Thu, 07 Jan 2021 19:30:19 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=y/mGwKqiVo9Zl8OsRu/zsLcRZ5PL4/MtiqhnZAuWHfA=;
 b=AiZO7TceaepxYgA3GvbJSXT5fNHT1p82gMNf55BjpoIaqriZL4ONdEGOufB006n4xz
 iB/L5N1YO5tm/UmobuuQGI+tP8vLy0fJZHEv0ZGGm5u2tmmrAobQzHwDNyxz+p6G4Uxa
 Ur1Uxm5QXT0rt/1Nj+G6vR8oFk+7tAvSp0E8WUgPYHw/c3yAvc1L8Nu+3sIhaOWM+GB9
 +ZK0UOnD64Zt7aBfqS5i4dNK4AxDZrqlYc8od0JFpQC1XNU1jG4KlwS6a7h/D8PTKxYl
 bforJ/byp2V2c9dzLuHewhieQTMu8gUeNBHFckppaRPh8onEggVMHViKuslYJFiChC18
 iVnw==
X-Gm-Message-State: AOAM533S9t7AAYCdu+fHzF3wgqrSxZvATp1BXUnOMjli1xoaXunxK450
 eIRh9I4j5Nxk7HqEqIozN/OSDSKlyjFY2ozD6qM=
X-Google-Smtp-Source: ABdhPJyhxM1mWFFBttAE0uXjXEwgBPEP203mHXs3qVnmKX+L2EFj7hxdHlrhqprzUu9QGCGVrTaqHLlUab3tOaO2Xow=
X-Received: by 2002:ab0:310:: with SMTP id 16mr1428586uat.33.1610076619157;
 Thu, 07 Jan 2021 19:30:19 -0800 (PST)
MIME-Version: 1.0
References: <CAFULd4anVTaBKdaQBx2XkM-rqXKZRBtDuQ=sbDHLqC36mcmgSg@mail.gmail.com>
In-Reply-To: <CAFULd4anVTaBKdaQBx2XkM-rqXKZRBtDuQ=sbDHLqC36mcmgSg@mail.gmail.com>
From: Hongtao Liu <crazylht@gmail.com>
Date: Fri, 8 Jan 2021 11:33:01 +0800
Message-ID: <CAMZc-bwhqBL92PoNuHMAbzaRKhMzcaZc1ipMTAtq=Rzk5q+bJg@mail.gmail.com>
Subject: Re: [PATCH] i386: Merge various insn name mapping code attributes
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jan 2021 03:30:20 -0000

On Thu, Jan 7, 2021 at 9:43 PM Uros Bizjak via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> 2021-01-07  Uro=C5=A1 Bizjak  <ubizjak@gmail.com>
>
> No functional changes.
>
> gcc/
>     * config/i386/i386.md (insn): Merge from plusminus_insn, shift_insn,
>     rotate_insn and optab code attributes.
>     Update all uses to merged code attribute.
>     * config/i386/sse.md: Update all uses to merged code attribute.
>     * config/i386/mmx.md: Update all uses to merged code attribute.
>
> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>
> Uros.

BTW, I'm thinking of putting all define_mode/code/int_iterator(also
corresponding attribute) into a new file name "iterators.md".
Also do some refactoring for those iterators, some of them seem duplicated.


--=20
BR,
Hongtao