From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id 01D52385E82F for ; Thu, 12 Aug 2021 04:40:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01D52385E82F Received: by mail-vk1-xa2c.google.com with SMTP id d30so1156039vkl.12 for ; Wed, 11 Aug 2021 21:40:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2i3OioJqVRFYoRbFMWu/aEtUQd48xT01aw4rFdHgrCE=; b=tzJiWmE+lJS7fRVIQ5+qqCcSTXMlqmSXAswQYKIFeva4bpfLe3nsNpGSFQk5FAgT90 kpBqiRMhEEUrkUQi1FuhaADp854i9wP5XG8OUUoODNV15yR8R4xFXKN0BEajaizXWPWb WUA1VR43D3pFgPMQImkq1dsYmgTY5Gdp+V2oHmiT+YBCUZsmPfVzr/7jETkpxhATSbs7 g4Gck2688JSbah5n8HHJIjfr/SniAcBQolIj/22F1zLcVsaPtrgRutkTnyKm2CtddmKe P2bzjed4SwVW88TWteGn5dja5L7J3ctftkDj45w5aJWuaZfAxL4BlshTkNGJ2I8jKHlJ erKg== X-Gm-Message-State: AOAM533rNYGpXRxrRxavj+nnYkb7pnosYeIG+9f3sakQusqmiNZfzVXi r4gyBDNlYLzLaS4x1PXyHBEvbQLiYhAUvJyC5eA= X-Google-Smtp-Source: ABdhPJw11dyBxdOy/pYu9Lr7Rzf/GeQsoI8rGMRWR3XBYJNHHIIbR5LbFCxxkB7rkfeNM5pQbpH2hY2ISrBBOblYxY0= X-Received: by 2002:a05:6122:549:: with SMTP id y9mr1717713vko.7.1628743242665; Wed, 11 Aug 2021 21:40:42 -0700 (PDT) MIME-Version: 1.0 References: <20210810121315.3409758-1-hongtao.liu@intel.com> In-Reply-To: From: Hongtao Liu Date: Thu, 12 Aug 2021 12:46:25 +0800 Message-ID: Subject: Re: [PATCH] Extend ldexp{s, d}f3 to vscalefs{s, d} when TARGET_AVX512F and TARGET_SSE_MATH. To: Uros Bizjak Cc: liuhongt , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 04:40:53 -0000 On Wed, Aug 11, 2021 at 7:16 PM Uros Bizjak wrote: > > On Wed, Aug 11, 2021 at 8:36 AM Uros Bizjak wrote: > > > > On Tue, Aug 10, 2021 at 2:13 PM liuhongt wrote: > > > > > > Hi: > > > AVX512F supported vscalefs{s,d} which is the same as ldexp except the second operand should be floating point. > > > Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. > > > > > > gcc/ChangeLog: > > > > > > PR target/98309 > > > * config/i386/i386.md (ldexp3): Extend to vscalefs[sd] > > > when TARGET_AVX512F and TARGET_SSE_MATH. > > > > > > gcc/testsuite/ChangeLog: > > > > > > PR target/98309 > > > * gcc.target/i386/pr98309-1.c: New test. > > > * gcc.target/i386/pr98309-2.c: New test. > > > > OK. > > Actually, we should introduce a scalar version of avx512f_vmscalef, so > we can avoid all subreg conversions with the vector-merge (VM) > version, and will also allow memory in operand 2. > > Please test the attached incremental patch. > Bootstrapped and regtested on x86_64-linux-gnu{-m32,} on CLX. tests is fine. > Uros. -- BR, Hongtao