From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by sourceware.org (Postfix) with ESMTPS id D1BEE3858D3C for ; Mon, 29 Aug 2022 00:24:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1BEE3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-3376851fe13so160197077b3.6 for ; Sun, 28 Aug 2022 17:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=zQpRo1InLVMKSDtheP5UyDiRRloznAjYvbHEE/fP9Kg=; b=Q4cphOp3kIMZ2Btbk8OmFFnxllley1LCa7CQqJB6u7PTWHmZL7rC6yn6uxnYv+9gYS VZoRwBXiLMcIpXHQvlMLFtS0sbDvjdUr7QgFjiwvhcCRkpHheBl/LYjWUTmLmXdOvUAP KU0Y0RQzElI0k4XbIF/512OzeAMBCsPVdn2PQwQSi5ckLVoA/8hIu4v1W7bfQOyWMFkB ZvErWyq97y3CgXA3KyS4CextGX7sjN6vqcUDAEHRCcAFcXYjdLBCiNWpPdcTGmf1vYxR QxqDBbzam0HywOW2kjeC1VFs08dfmd4F03eWP0NvtbzlZ8WU2pETw9kB3F6SfgmlvfUs znzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=zQpRo1InLVMKSDtheP5UyDiRRloznAjYvbHEE/fP9Kg=; b=q1iIacB/W5R33WiiGXL8oQDYEK22PygTqjEGZTq7ahBRM62tCu0pzIbx6hPzRGhtZR FWb31QcVpIH5FjNBPU78HblFnHgmXdM2lhkcH0519cTA9HPzn3vZIRdI68xwdIOzuJCI 6TFLs8WyrkCr83SW30iMwF2y02XRb6gdikrOzP7t/5pcXyL5r+uvFI+tsWropKmk2qCh N7IgYxdAgB4L3pgOBMhkFn/X5b4pUW6sa5hBFm5PU0Qbb+ZDKLTG/tU19mylMI19GJ9+ 4nO2Na4EM2yRnaQ3aQP2UwLn18lcVzUXdWPa83Ymqx0+yj907ai/9tMRBUAyhQKO7CtH e7JQ== X-Gm-Message-State: ACgBeo3jIvoBiVxISU8qkPinFZ1u4ox0vIu5x4S2VvnNjinVOysUHJSl FbeNuQr1yjXpR8g9IEWARTertZDfNsHAVSoRqGSQ6NUS8GM= X-Google-Smtp-Source: AA6agR7rqVhvLNKR3XGyxuLLJTI4SUKpYJBFsboTPWrKg+wtbdSLK8a+uXXqNxh92AMtjywb5542yZdISO0HPeFnggU= X-Received: by 2002:a5b:489:0:b0:655:be22:4757 with SMTP id n9-20020a5b0489000000b00655be224757mr6743605ybp.92.1661732676556; Sun, 28 Aug 2022 17:24:36 -0700 (PDT) MIME-Version: 1.0 References: <20220822170244.670691-1-hjl.tools@gmail.com> In-Reply-To: From: Hongtao Liu Date: Mon, 29 Aug 2022 08:24:25 +0800 Message-ID: Subject: Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics To: "H.J. Lu" Cc: GCC Patches , Uros Bizjak Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Aug 27, 2022 at 12:51 AM H.J. Lu wrote: > > On Mon, Aug 22, 2022 at 7:05 PM Hongtao Liu wrote: > > > > On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu wrote: > > > > > > On 64-bit Windows, long is 32 bits and can't be used as stride in memory > > > operand when base is a pointer which is 64 bits. Cast stride to > > > __PTRDIFF_TYPE__, instead of long. > > Ok. > > > > > > PR target/106714 > > > * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to > > > __PTRDIFF_TYPE__. > > > (_tile_stream_loadd_internal): Likewise. > > > (_tile_stored_internal): Likewise. > > > --- > > > gcc/config/i386/amxtileintrin.h | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h > > > index 7b5a39eba72..06f18aa9bfb 100644 > > > --- a/gcc/config/i386/amxtileintrin.h > > > +++ b/gcc/config/i386/amxtileintrin.h > > > @@ -62,7 +62,7 @@ _tile_release (void) > > > #define _tile_loadd_internal(dst,base,stride) \ > > > __asm__ volatile \ > > > ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \ > > > - :: "r" ((const void*) (base)), "r" ((long) (stride))) > > > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride))) > > > > > > #define _tile_stream_loadd(dst,base,stride) \ > > > _tile_stream_loadd_internal (dst, base, stride) > > > @@ -70,7 +70,7 @@ _tile_release (void) > > > #define _tile_stream_loadd_internal(dst,base,stride) \ > > > __asm__ volatile \ > > > ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \ > > > - :: "r" ((const void*) (base)), "r" ((long) (stride))) > > > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride))) > > > > > > #define _tile_stored(dst,base,stride) \ > > > _tile_stored_internal (dst, base, stride) > > > @@ -78,7 +78,7 @@ _tile_release (void) > > > #define _tile_stored_internal(src,base,stride) \ > > > __asm__ volatile \ > > > ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \ > > > - :: "r" ((void*) (base)), "r" ((long) (stride)) \ > > > + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \ > > > : "memory") > > > > > > #define _tile_zero(dst) \ > > > -- > > > 2.37.2 > > > > > > > > > -- > > BR, > > Hongtao > > OK to backport it to GCC 12 branch? Ok. > > > -- > H.J. -- BR, Hongtao