From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by sourceware.org (Postfix) with ESMTPS id C788D3858C53 for ; Wed, 14 Jun 2023 06:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C788D3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-bd20beffda6so345853276.1 for ; Tue, 13 Jun 2023 23:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686724214; x=1689316214; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VpTTvjgucZ1rLNm28bsXFghliNaCnArSrQttaqtS8PA=; b=pjW+ZwDc3lWNOg+QGPoURw0Hdlk2abrrVNSeeWZI2LpcPNelSPlisrIErnNYTlHyg/ epF8fwrKrENuHjRKQ+JW6b7iC02HyxeA659r2pVwgfQJrVF77FaQK3MVl1zYNnk9O/SD JmaCrsL68gzRhtEw6allwlf/oS+kvPeYQ3xv44zlLHFiR3m83kekDD54oVttLz+/L0cW Be8oSMIU6ejMO6AgW5Cv8pm+myI29mLIENMwUu0A1auj+bS2uRgvwmmyN6ty7pZl/a3c nJ7u8v0f0M/6HNlTjXlcWzyxP/Tf/+87+Zi9jrkM3u7opZ13/GYUcRZLgtdtrspa+bq9 hCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686724214; x=1689316214; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VpTTvjgucZ1rLNm28bsXFghliNaCnArSrQttaqtS8PA=; b=eXpOaCJUtAfuIUMzg8c16qdMypNRU/GbK9QYLaC6T3XRMvPerYjwncose0ta2nwTt5 5XE6XbhXYdgM+9KuXgxdhUDmrERHO+ukjLwZ1h4cofuBXNHiV/S8INs+xqTZxtrn6V/U /dWUZXGrLGDupd6GcZIfGEnIrWTgk67X6TVIQV1Pekmz8LRt3XSZvpx5vdywihSMXEdI i02YUhGuPUvJoMddTHAb3bXK5xtgZTegBwbNUUuYjTikMhWU3N0Gw7EQt+kZ45grRzA2 porU/baemp/2eaZv0HCt4rXamVC0jab+Gg12UaAy2RS6iGxyK5HvrNdyUACbQ4shmS/T dn8g== X-Gm-Message-State: AC+VfDw9KvVR7eL9zp3oAJIzTrU2v4CzocKlpdhPbb5CvhEfivpyJ5hO wSea4U2+UsVaHKKr8tZpnaaCzE3E/On+8E92eyM= X-Google-Smtp-Source: ACHHUZ477o7ktiIJ3DCVgMiVo35mfqrZGEc+ZlyicMX0YPhkF1ezpbG+upxqbLoGSLhRQPGMPLd4nI+bb5i4BTsBS2M= X-Received: by 2002:a25:c5ce:0:b0:bc7:60cb:5cb4 with SMTP id v197-20020a25c5ce000000b00bc760cb5cb4mr1238411ybe.12.1686724214101; Tue, 13 Jun 2023 23:30:14 -0700 (PDT) MIME-Version: 1.0 References: <1901e956-dc34-cc03-0419-8d4338174384@suse.com> In-Reply-To: <1901e956-dc34-cc03-0419-8d4338174384@suse.com> From: Hongtao Liu Date: Wed, 14 Jun 2023 14:30:03 +0800 Message-ID: Subject: Re: [PATCH] x86/AVX512: use VMOVDDUP for broadcast to V2DF To: Jan Beulich Cc: "gcc-patches@gcc.gnu.org" , Kirill Yukhin , Hongtao Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 14, 2023 at 1:55=E2=80=AFPM Jan Beulich via Gcc-patches wrote: > > Like is already the case for the AVX/AVX2 form, VMOVDDUP - acting on > double precision floating values - is more appropriate to use here, and > it can also result in shorter insn encodings when source is memory or > %xmm0...%xmm7, and no masking is applied (in allowing a 2-byte VEX > prefix then instead of a 3-byte one). > > gcc/ > > * config/i386/sse.md (_vec_dup): Use > vmovddup. Ok for trunk. > > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -25724,9 +25724,9 @@ > "TARGET_AVX512F" > { > /* There is no DF broadcast (in AVX-512*) to 128b register. > - Mimic it with integer variant. */ > + Mimic it with vmovddup, just like vec_dupv2df does. */ > if (mode =3D=3D V2DFmode) > - return "vpbroadcastq\t{%1, %0|%0, %q1}= "; > + return "vmovddup\t{%1, %0|%0, %q1}"; > > return "vbroadcast\t{%1, %0|%0, %1}"; > } --=20 BR, Hongtao