From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id 09F703858419 for ; Wed, 28 Sep 2022 01:42:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09F703858419 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb35.google.com with SMTP id p69so14374979yba.0 for ; Tue, 27 Sep 2022 18:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=SQRCVY+EhlLvWpDAT4mqlAH66XL1MYNNL9jJLQRlaD4=; b=c0YZ++ejAuJzIEWa08zpknoGcJWD0K3lKZYAf0eT/t2Rl4OaLVwte3YE1IBFZM47iD Cgpm0KptZSydiG4v0pnr9Xjct13QkHYXZGyASI/k647POPcHPRZ1SxtnYHaqFERJN/By WVOamx3YJ7bveSwyJMri1bzVgPQ1YcSAizh2DhoxCc6X8zxHT+ffZi8QYQ4qMTbCUHkt cihUK6EVIpY6cxBFvrxWzTk6BqrCgKlKEs//yLPkK+/uZLYXMO83Y72M3VXMjPxPg5QP jXJK+GFBXThmnhNaUcdsnF6XHTNyMBoCFcfrMS4E7X70I9HciJ4OXDZdkzthwrWB69Jc CuEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=SQRCVY+EhlLvWpDAT4mqlAH66XL1MYNNL9jJLQRlaD4=; b=mgXqMy25jt34g0yqKvGz8vloE9ObpDObV96Ns/Y68cA9lBcG1cLMuRa7zm5LsBLWc2 Y6EagH8bD5tzX35+KwN2PvPcc8q4C21lQHQKYcozGS0pH1MBeb/mp9CWW1jV6wyKmrhl H+0G0rv2DFJVqhdv0f0BfmB4cREkSQZX1SXj4fLDCzq7dTQmNpJpBOpZZGtqX32/Pwm7 MQG8ARfIcA3uqEfxKF6PbJ3qJ5p/wLsmjZf6j1eEOm2dMEzm2s6BCZLpvbVwwaitcOdh tdZCdol+wwllK0ypJxzYHKa9Un9TC3NNtFL51zdubqW4aHHsk+yH5aCFgYb7VYIVdrkh 9xnw== X-Gm-Message-State: ACrzQf0YOHe1HrpU5f4TL4CU/28ZynIrAMavmg19FFhLmyWs0Rrh+8g3 al4i+kxYYluCifxxYPeKXPP5tYhna4aQ1epjeQw= X-Google-Smtp-Source: AMsMyM7zIezqHsnPUSM+oG9xunAbn0UqqfVHYXmyPzI5NJwS46Ph/6iLO9zEky8VuuCI930cEA38UROzmL8mMAIyhBo= X-Received: by 2002:a25:af49:0:b0:6af:fbf5:92d5 with SMTP id c9-20020a25af49000000b006affbf592d5mr28416084ybj.624.1664329326272; Tue, 27 Sep 2022 18:42:06 -0700 (PDT) MIME-Version: 1.0 References: <20220927233454.144656-1-hjl.tools@gmail.com> In-Reply-To: <20220927233454.144656-1-hjl.tools@gmail.com> From: Hongtao Liu Date: Wed, 28 Sep 2022 09:41:54 +0800 Message-ID: Subject: Re: [PATCH] i386: Mark XMM4-XMM6 as clobbered by encodekey128/encodekey256 To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org, Hongtao Liu , Hongyu Wang Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 28, 2022 at 7:35 AM H.J. Lu via Gcc-patches wrote: > > encodekey128 and encodekey256 operations clear XMM4-XMM6. But it is > documented that XMM4-XMM6 are reserved for future usages and software > should not rely upon them being zeroed. Change encodekey128 and Indeed. Ok for trunk and backport. > encodekey256 to clobber XMM4-XMM6. > > gcc/ > > PR target/107061 > * config/i386/predicates.md (encodekey128_operation): Check > XMM4-XMM6 as clobbered. > (encodekey256_operation): Likewise. > * config/i386/sse.md (encodekey128u32): Clobber XMM4-XMM6. > (encodekey256u32): Likewise. > > gcc/testsuite/ > > PR target/107061 > * gcc.target/i386/keylocker-encodekey128.c: Don't check > XMM4-XMM6. > * gcc.target/i386/keylocker-encodekey256.c: Likewise. > --- > gcc/config/i386/predicates.md | 20 +++++++++---------- > gcc/config/i386/sse.md | 4 ++-- > .../gcc.target/i386/keylocker-encodekey128.c | 1 - > .../gcc.target/i386/keylocker-encodekey256.c | 1 - > 4 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a/gcc/config/i386/predicates.md b/gcc/config/i386/predicates.md > index 655eabf793b..c4141a96735 100644 > --- a/gcc/config/i386/predicates.md > +++ b/gcc/config/i386/predicates.md > @@ -2107,11 +2107,11 @@ (define_predicate "encodekey128_operation" > for(i = 4; i < 7; i++) > { > elt = XVECEXP (op, 0, i); > - if (GET_CODE (elt) != SET > - || GET_CODE (SET_DEST (elt)) != REG > - || GET_MODE (SET_DEST (elt)) != V2DImode > - || REGNO (SET_DEST (elt)) != GET_SSE_REGNO (i) > - || SET_SRC (elt) != CONST0_RTX (V2DImode)) > + if (GET_CODE (elt) != CLOBBER > + || GET_MODE (elt) != VOIDmode > + || GET_CODE (XEXP (elt, 0)) != REG > + || GET_MODE (XEXP (elt, 0)) != V2DImode > + || REGNO (XEXP (elt, 0)) != GET_SSE_REGNO (i)) > return false; > } > > @@ -2157,11 +2157,11 @@ (define_predicate "encodekey256_operation" > for(i = 4; i < 7; i++) > { > elt = XVECEXP (op, 0, i + 1); > - if (GET_CODE (elt) != SET > - || GET_CODE (SET_DEST (elt)) != REG > - || GET_MODE (SET_DEST (elt)) != V2DImode > - || REGNO (SET_DEST (elt)) != GET_SSE_REGNO (i) > - || SET_SRC (elt) != CONST0_RTX (V2DImode)) > + if (GET_CODE (elt) != CLOBBER > + || GET_MODE (elt) != VOIDmode > + || GET_CODE (XEXP (elt, 0)) != REG > + || GET_MODE (XEXP (elt, 0)) != V2DImode > + || REGNO (XEXP (elt, 0)) != GET_SSE_REGNO (i)) > return false; > } > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > index 5c189635124..076064f97e6 100644 > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -29015,7 +29015,7 @@ (define_expand "encodekey128u32" > > for (i = 4; i < 7; i++) > XVECEXP (operands[2], 0, i) > - = gen_rtx_SET (xmm_regs[i], CONST0_RTX (V2DImode)); > + = gen_rtx_CLOBBER (VOIDmode, xmm_regs[i]); > > XVECEXP (operands[2], 0, 7) > = gen_rtx_CLOBBER (VOIDmode, gen_rtx_REG (CCmode, FLAGS_REG)); > @@ -29072,7 +29072,7 @@ (define_expand "encodekey256u32" > > for (i = 4; i < 7; i++) > XVECEXP (operands[2], 0, i + 1) > - = gen_rtx_SET (xmm_regs[i], CONST0_RTX (V2DImode)); > + = gen_rtx_CLOBBER (VOIDmode, xmm_regs[i]); > > XVECEXP (operands[2], 0, 8) > = gen_rtx_CLOBBER (VOIDmode, gen_rtx_REG (CCmode, FLAGS_REG)); > diff --git a/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c b/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > index 805e0628673..57fa9bdc831 100644 > --- a/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > +++ b/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > @@ -6,7 +6,6 @@ > /* { dg-final { scan-assembler "(?:movdqu|movups)\[ \\t\]+\[^\\n\]*%xmm0,\[^\\n\\r\]*" } } */ > /* { dg-final { scan-assembler "(?:movdqu|movups)\[ \\t\]+\[^\\n\]*%xmm1,\[^\\n\\r\]*16\[^\\n\\r\]*" } } */ > /* { dg-final { scan-assembler "(?:movdqu|movups)\[ \\t\]+\[^\\n\]*%xmm2,\[^\\n\\r\]*32\[^\\n\\r\]*" } } */ > -/* { dg-final { scan-assembler "(?:movdqa|movaps)\[ \\t\]+\[^\\n\]*%xmm\[4-6\],\[^\\n\\r\]*" } } */ > > #include > > diff --git a/gcc/testsuite/gcc.target/i386/keylocker-encodekey256.c b/gcc/testsuite/gcc.target/i386/keylocker-encodekey256.c > index 26f04dcf014..a9398b4e7a2 100644 > --- a/gcc/testsuite/gcc.target/i386/keylocker-encodekey256.c > +++ b/gcc/testsuite/gcc.target/i386/keylocker-encodekey256.c > @@ -8,7 +8,6 @@ > /* { dg-final { scan-assembler "(?:movdqu|movups)\[ \\t\]+\[^\\n\]*%xmm1,\[^\\n\\r\]*16\[^\\n\\r\]*" } } */ > /* { dg-final { scan-assembler "(?:movdqu|movups)\[ \\t\]+\[^\\n\]*%xmm2,\[^\\n\\r\]*32\[^\\n\\r\]*" } } */ > /* { dg-final { scan-assembler "(?:movdqu|movups)\[ \\t\]+\[^\\n\]*%xmm3,\[^\\n\\r\]*48\[^\\n\\r\]*" } } */ > -/* { dg-final { scan-assembler "(?:movdqa|movaps)\[ \\t\]+\[^\\n\]*%xmm\[4-6\],\[^\\n\\r\]*" } } */ > > #include > > -- > 2.37.3 > -- BR, Hongtao