From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by sourceware.org (Postfix) with ESMTPS id 5EA173858D32 for ; Tue, 20 Jun 2023 09:34:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5EA173858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-bd744ffc263so4582225276.3 for ; Tue, 20 Jun 2023 02:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687253679; x=1689845679; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ai9CCUi9yzc5pv/AV6IF1DqNdlVSh0qgHYd86k3s5LM=; b=XzexZkd3Eow17mRev0GYpuAn1LAz2J0cf9OOT8sc+fCvd4D67pqzW0AVpzmkVN9FAG yw73GQe38YeO0CIJoAKZhn4JYaDGULMKqYWJvI0y0kUSG0jE9WynhbJlmjKTMz+Af63t IKW9xXbY83WJNY590mF1WOnc0VCmWXRfp5PMSR5Q9vaCIXIDIuh7MgV+1/22ab6uPEsN 4YN6S7NWmAyHevxRwU+h3713sO7m8xuUTzQLCpcKZLW6oIIrzIjZlhcBnBn0axl4Mb0S bJ4NoGQX6ZQwUoO+X3Hes1eTG0/wZy5QZgG7o4LuHE997BX3TmC0MlVuFfK8zJTN6Gru MDCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687253679; x=1689845679; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ai9CCUi9yzc5pv/AV6IF1DqNdlVSh0qgHYd86k3s5LM=; b=VZAcKVTkMEtjh/SSMr7x1Enhto0R/M0zDUrBd6zmBol+ksx2ZuqFisdIbmmzaY5ujs 7y9uT2mq54KcDfy5MwwCXjUd9e7aGcUW2D9awGfITDKov6UJ5n3cyupBPJmgtC0g+30o 6HQQimUe0ZVHKcxEs2+xWL3il3qUBeWZPsqZl45aVLAWzybTz4XNzGzZNCQRmMkvv24j cipTmBa5LcajOcwSuK6C39utSOd5/Exvqj10SwL4X2sgxsjFZCCXEaLKWjXGNSNIMKLk nqrJsAf6gqdjD8e+BvlQSleOusfHn14799b8+0pHR1YMBq91RVlRIzMv63OdyTso6gXU 6Hmw== X-Gm-Message-State: AC+VfDxs2Dmz/HxRHOqVcUpYPF3OiVDB4KgeU3XXFbRuriJ9RacGN3/d owNr+lGFXpT6hp+OBxqHLW2Xgwm+MVodmbjrtGE= X-Google-Smtp-Source: ACHHUZ6MqpcvtsJ63A56KfYB6WWHBfF5oRNZHM50jk9Xc1EmxiVlcINBhhnZZuF1iUFZB8Dgu3LBY/f02LiRLdiUZUs= X-Received: by 2002:a25:4085:0:b0:bca:d619:8ccf with SMTP id n127-20020a254085000000b00bcad6198ccfmr8998979yba.55.1687253678731; Tue, 20 Jun 2023 02:34:38 -0700 (PDT) MIME-Version: 1.0 References: <169ca252-3828-b466-4d47-a8fe720ec4ef@suse.com> <7a8c5593-c53d-9c45-ffcd-c48cdd3ef911@suse.com> In-Reply-To: <7a8c5593-c53d-9c45-ffcd-c48cdd3ef911@suse.com> From: Hongtao Liu Date: Tue, 20 Jun 2023 17:34:27 +0800 Message-ID: Subject: Re: [PATCH v3] x86: make VPTERNLOG* usable on less than 512-bit operands with just AVX512F To: Jan Beulich Cc: "gcc-patches@gcc.gnu.org" , Kirill Yukhin , Hongtao Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 20, 2023 at 5:03=E2=80=AFPM Jan Beulich wro= te: > > On 20.06.2023 10:33, Hongtao Liu wrote: > > On Tue, Jun 20, 2023 at 3:07=E2=80=AFPM Jan Beulich via Gcc-patches > > wrote: > >> > >> I guess the underlying pattern, going along the lines of what > >> one_cmpl2 uses, can be applied elsewher= e > >> as well. > > That should be guarded with !TARGET_PREFER_AVX256, let's handle that > > in a separate patch. > > Sure, and as indicated there are more places where similar things could > be done. > > >> --- /dev/null > >> +++ b/gcc/testsuite/gcc.target/i386/avx512f-copysign.c > >> @@ -0,0 +1,32 @@ > >> +/* { dg-do compile } */ > >> +/* { dg-options "-mavx512f -mno-avx512vl -O2" } */ > > Please explicitly add -mprefer-vector-width=3D512, our tester will also > > test unix{-m32 \-march=3Dcascadelake,\ -march=3Dcascadelake} which set = the > > - mprefer-vector-width=3D256, -mprefer-vector-width=3D512 in dg-options > > can overwrite that. > > Oh, I see. Will do. And I expect I then also need to adjust the newly > added avx512f-dupv2di.c from the earlier patch. I guess I could commit > that option addition there as obvious? Still need to send out the patch, and commit as an obvious fix. > > > Others LGTM. > > May I take this as "okay with that change", or should I submit v4? Okay. no need for a v4 version. > > Jan --=20 BR, Hongtao