From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id DB529393D033 for ; Fri, 5 Feb 2021 01:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DB529393D033 Received: by mail-io1-xd33.google.com with SMTP id n14so5475467iog.3 for ; Thu, 04 Feb 2021 17:53:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jrT7us3VIXnCQoFnQxYDN/lRwYCuMLhv7TgVk5FA9xM=; b=NkiEe2hGCHCOqr4JrGPQg+LGyLGtyn+1FEhSJTlEjHnTdOADWpgllTksh0zRvc6Gl/ 4vqySbp74H37RDMX3jKkDfPPCaZKJASikRKCmaMPMlKYu2w8MjE81vQsgyMVN8bNDoQ9 cxiT0IZavlTkg72Xr+AAFvyGnM8WBlWXB/r89shz2wkR7Ymz3UHss6wwcU03J40xq9J0 OLxl2dk7Y8mvVZmhX0UeYQIhFptAY06nck+rTP8pQRGTXMGqvA8cEKqhfDyhFxcFc88w AzoluG5wgJzvnVCRfv+PKeWkJ3beYMc5pcERjIytzsuh41PfTyco94IL+0zXgISQ3ZU8 9/Dg== X-Gm-Message-State: AOAM5328MX0HV4GEzpbLw+YSRkzpdm4BZ4aqsz5Pdf28M6vvC6cMaF7j yws5Ee8A2thX+dBBzdkeYK8KSzRB2hKLJs4iah8= X-Google-Smtp-Source: ABdhPJwDtazpEbGXKAKm7+5sKLaJvVA76h7+bQe2EnDdsVeTAuLOqlQvVrChcat2gCokzLMc90QkVPJ/acdYzDcBJ0s= X-Received: by 2002:a05:6638:235:: with SMTP id f21mr2536168jaq.32.1612489985365; Thu, 04 Feb 2021 17:53:05 -0800 (PST) MIME-Version: 1.0 References: <20210106143931.GC725145@tucnak> <20210204120028.GM4020736@tucnak> In-Reply-To: <20210204120028.GM4020736@tucnak> From: Hongtao Liu Date: Fri, 5 Feb 2021 09:52:52 +0800 Message-ID: Subject: Re: [PATCH] [AVX512] Fix ICE: Convert integer mask to vector in ix86_expand_fp_vec_cmp/ix86_expand_int_vec_cmp [PR98537] To: Jakub Jelinek Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 01:53:07 -0000 On Thu, Feb 4, 2021 at 8:00 PM Jakub Jelinek wrote: > > On Thu, Feb 04, 2021 at 01:31:52PM +0800, Hongtao Liu via Gcc-patches wrote: > * gcc.target/i386/avx512vl-pr92686-vpcmp-1.c: This test is > used to guard code generation of integer mask comparison, but > for vector comparison to vector dest, integer mask comparison > is disliked, so detele this useless test. > * gcc.target/i386/avx512vl-pr92686-vpcmp-2.c: Ditto. > * gcc.target/i386/avx512vl-pr92686-vpcmp-intelasm-1.c: Ditto. > > s/detele/delete/; but I'd say just write : Remove. > for all 3 tests, the explanation should go into the commit message, not > ChangeLog. > + /* When op_true is NULL, op_flase must be NULL, vice either. */ > > s/flase/false/ > s/vice either/or vice versa/ > > + gcc_assert (!op_true == !op_false); > + > + /* When op_true/op_false is NULL or cmp_mode is not valid mask cmp mode, > + vector dest is required. */ > + if (!op_true || !ix86_valid_mask_cmp_mode (cmp_mode)) > + return false; > + > + /* Exclude those could be optimized in ix86_expand_sse_movcc. */ > > s/those/those that/ > > Otherwise LGTM. > Ok for backport? > Jakub > -- BR, Hongtao