From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by sourceware.org (Postfix) with ESMTPS id AD51E3854160 for ; Fri, 14 Oct 2022 08:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD51E3854160 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2b.google.com with SMTP id 203so4767363ybc.10 for ; Fri, 14 Oct 2022 01:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FVA29+ssVJOtfUzku2eJpvktb9/s/GFZceP5C41w5PM=; b=l9paZGvaiPiqJw2x4Rc/URmLFcVMIITArpRcmmTma6EQFRBXC6yshAaABBhWrSQyZ9 WRSfElcVQZxB7X5KOAm+QacqAFYpVLdejGoQoxoHRamp5RCcjIMRVEVph0m9R2QXonYU D/5/5dQLTNwP7CTLNJccO/F3+Fb63n3DbETS0YRXmW+39QqTHWq61Tn/4eIdsbc/UmNM pQgnLqKXQwDg7Nopms04APHmL0keYqNNX48hlcCysdUzadgJ4io4Wf/ZlCO4MX+gqC4G ufCVJ6x9p+djex5lQckdBYviyflsMZWCdFSO+C7+SSdLD8aH4A/ouU2pu+ksvLNCZEjM ql1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FVA29+ssVJOtfUzku2eJpvktb9/s/GFZceP5C41w5PM=; b=ubSRqw6TYrUqMAIkrkg6Mveb8wGeJ/G8CpBkoyCSKFUP0ra9QXnd0Uq6ib/l7zygIg e+dO7YJebbN0hD4OsGlQPFuBMWxeGbniBeJn/pVeI43q5efDUcIJq+LSM5sL3/1q9SZ9 M3PfqwO+g/MHrZDRng1AGYAkgt9lSET9fzPkyxyUYQeBhlAdG/e/f9fuWF/TP0z3zVMX /WYO9LHgtxAtMOKKCG6Y2ahe1//zdce7FqVpDm3iKwb1lnojbwKXPoalySAvif+z3fl9 QgiX/PqY0R1TuMOvDjWC8CtjvWSstABNo7RkLYgZ6j+5xiZ1wAv2b6aRFsvphJjl5a5Z KuTg== X-Gm-Message-State: ACrzQf2+jKWuqWu0labpa3mczjBULlwjtmzM7sF8eKBVTHDZOr6LvQia CQKyfOcOOdtKX9biq1RbY3PazN4WiQtRktMiR1+iXhicDFl7DA== X-Google-Smtp-Source: AMsMyM5nYSOdRO+codNU7eRaKD9sj2Gtbl6ImhLR3FkbiHOmWpyC7w4bAKSeY1tXBcbcqb4ubwXKOqgDsp/rneqIyls= X-Received: by 2002:a25:be87:0:b0:67a:7054:c7bc with SMTP id i7-20020a25be87000000b0067a7054c7bcmr3255955ybk.601.1665735625760; Fri, 14 Oct 2022 01:20:25 -0700 (PDT) MIME-Version: 1.0 References: <20221014075445.7938-1-haochen.jiang@intel.com> In-Reply-To: From: Hongtao Liu Date: Fri, 14 Oct 2022 16:20:14 +0800 Message-ID: Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions To: Iain Sandoe Cc: Haochen Jiang , hongtao.liu@intel.com, GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 14, 2022 at 4:14 PM Iain Sandoe via Gcc-patches wrote: > > Hi Haochen > > > On 14 Oct 2022, at 08:54, Haochen Jiang via Gcc-patches wrote: > > > > > These six patches aimed to add Intel Sierra Forest instructions, including > > AVX-IFMA, AVX-VNNI0INT8, AVX-NE-CONVERT, CMPccXADD. We also added intrinsic > > for vector __bf16 in this series of patch and Sierra Forest Support. > > > > The information is based on newly released > > Intel Architecture Instruction Set Extensions and Future Features. > > > > The document comes following: > > https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html > > > > Regtested on x86_64-pc-linux-gnu. Ok for trunk? > > Have you tested that the testcases work on older platforms that do not have support > for the new instructions in their assemblers? > > I could not see any target-requires changes in the testcases .. hence my question. > Guess you are looking at compile tests? For runtime test, we have add assembler check(target-requires changed) plus runtime check(builtin_cpu_supports) .i.e. +++ b/gcc/testsuite/gcc.target/i386/avx-ifma-vpmaddhuq-2.c @@ -0,0 +1,72 @@ +/* { dg-do run } */ +/* { dg-options "-O2 -mavxifma" } */ +/* { dg-require-effective-target avxifma } */ Do I miss some? > (otherwise we end up with a lot of spurious test fails on these older platforms). > > thanks > Iain -- BR, Hongtao