From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by sourceware.org (Postfix) with ESMTPS id EEC42385843A for ; Tue, 23 Aug 2022 02:05:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEC42385843A Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-3375488624aso314160147b3.3 for ; Mon, 22 Aug 2022 19:05:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=MBZuvlEpMG+cW8oNuRPmSM9K59qywEe16AFwRTlwrcg=; b=ETOjt/M8JfEvtUkHTn3bRvEo4WP+a/yN+0ZuRUCZBknHLQTOGkpmthIUE4x0uxj+cu +Ekf8H2xM9IhheZdd4NLBF01VWVlocjxtICbnYUWLrHiw5luwgfepkM8zyXVAVQ+nWMd ISY+0F9wpu1V6WPpWlOjcHMR7/M+oWzBbsApESu6ruHE+T5YC2p2HzKW5z6YAMPg6eAW LbgiXTrhs1VsqWYp3NX8Dh+XZcKrgvs4nXD0i4iojAOnv85CSsSkE1+WLoDM3uWNDTFf pwIugtBV/gAnUcoSgVCNlgrkOSA/SRPAGhZNw1SWyM4H7G2hLZDkHQdTVwrOBm3wOOtK T/fw== X-Gm-Message-State: ACgBeo0rUyE5rrsELTTfsQfB0azwyHm2Yj1E+7HWmuNEWD/9h7+Ov3lN A/OyzSjhfTXZJ6cECAoorZy3MQd43bYxrcoL+Yo= X-Google-Smtp-Source: AA6agR5bxXcVB1qMd0bP+OnKrUr51la0OffDcEkXeGzpv66SpHlkNejLHybji8xMPCqD/fKecxhAL5IH7UOTlLlQWIQ= X-Received: by 2002:a81:6c96:0:b0:334:b7a0:4242 with SMTP id h144-20020a816c96000000b00334b7a04242mr23433103ywc.475.1661220328289; Mon, 22 Aug 2022 19:05:28 -0700 (PDT) MIME-Version: 1.0 References: <20220822170244.670691-1-hjl.tools@gmail.com> In-Reply-To: <20220822170244.670691-1-hjl.tools@gmail.com> From: Hongtao Liu Date: Tue, 23 Aug 2022 10:05:16 +0800 Message-ID: Subject: Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org, Uros Bizjak Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 02:05:30 -0000 On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu wrote: > > On 64-bit Windows, long is 32 bits and can't be used as stride in memory > operand when base is a pointer which is 64 bits. Cast stride to > __PTRDIFF_TYPE__, instead of long. Ok. > > PR target/106714 > * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to > __PTRDIFF_TYPE__. > (_tile_stream_loadd_internal): Likewise. > (_tile_stored_internal): Likewise. > --- > gcc/config/i386/amxtileintrin.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h > index 7b5a39eba72..06f18aa9bfb 100644 > --- a/gcc/config/i386/amxtileintrin.h > +++ b/gcc/config/i386/amxtileintrin.h > @@ -62,7 +62,7 @@ _tile_release (void) > #define _tile_loadd_internal(dst,base,stride) \ > __asm__ volatile \ > ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \ > - :: "r" ((const void*) (base)), "r" ((long) (stride))) > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride))) > > #define _tile_stream_loadd(dst,base,stride) \ > _tile_stream_loadd_internal (dst, base, stride) > @@ -70,7 +70,7 @@ _tile_release (void) > #define _tile_stream_loadd_internal(dst,base,stride) \ > __asm__ volatile \ > ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \ > - :: "r" ((const void*) (base)), "r" ((long) (stride))) > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride))) > > #define _tile_stored(dst,base,stride) \ > _tile_stored_internal (dst, base, stride) > @@ -78,7 +78,7 @@ _tile_release (void) > #define _tile_stored_internal(src,base,stride) \ > __asm__ volatile \ > ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \ > - :: "r" ((void*) (base)), "r" ((long) (stride)) \ > + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \ > : "memory") > > #define _tile_zero(dst) \ > -- > 2.37.2 > -- BR, Hongtao