From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by sourceware.org (Postfix) with ESMTPS id 66D2B385E00A for ; Tue, 28 Jun 2022 06:22:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66D2B385E00A Received: by mail-yb1-xb35.google.com with SMTP id p7so19109495ybm.7 for ; Mon, 27 Jun 2022 23:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nmS6yn0XrPEmrzM/rOkP1pDlnFPGmPwUvy+sIinYj8k=; b=xbyEgw/adTff6lzCa0p1PIn4baU03yriJGWu9g3kPnVQ8ul+TL9o6GHxdYxMpr2ifd 8Dsa6QhZ48/oucYaeH0ROUqttMZFmldh2zZYrLFws8ww6l27lyUkNXL4dh1z6AaRlPs8 ehT0Ywcyvv4v/D+2iaDWdvZHVtIUoZBPFoEsJZKXVVH+JJr4lZWJSgCaGJa5zYftvYMR blq2fbK97c9kxxs+lEXmbBzgEheI5YpnfVtmmBkgSvYvBAPNj4jWyoSUH97STmRDkoQP M+qHMX6rNWII5ewtqC31eK0t+Cdpaw/rMb8ciG7s3RQN5SROt1be2qYkHhNe36QTr/OS jnsQ== X-Gm-Message-State: AJIora/GyzoqWn6YK4bbZheUk0SS/WvCBkBfvbeVj/1BVKK85OR5DVt/ lIWtohDzhW7mOygJYErn7t6fqT5E2ELCGgIH+lM= X-Google-Smtp-Source: AGRyM1tD8i0GdDJlGrhuYZWWomxsJNdl1GWp8qZLDccfmKZTPQq/O1WwekHtwBJ4DAA+DDSlqxCNxfcOb8cN6td5qgg= X-Received: by 2002:a25:ca0a:0:b0:66b:4e6c:e094 with SMTP id a10-20020a25ca0a000000b0066b4e6ce094mr19254473ybg.296.1656397336769; Mon, 27 Jun 2022 23:22:16 -0700 (PDT) MIME-Version: 1.0 References: <165637956824.13615.7247999336313533072-0@git.sr.ht> In-Reply-To: <165637956824.13615.7247999336313533072-0@git.sr.ht> From: Hongtao Liu Date: Tue, 28 Jun 2022 14:22:05 +0800 Message-ID: Subject: Re: [PATCH gcc 0/1] [PATCH] target: Fix asm generation for AVX builtins when using -masm=intel [PR106095] To: "~antoyo" Cc: GCC Patches , "~antoyo" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 06:22:18 -0000 On Tue, Jun 28, 2022 at 9:26 AM ~antoyo via Gcc-patches wrote: > > Hi. > > This fixes the following bug: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106095 The patch LGTM, thanks for handling this. > > It's the first time I work outside of the jit component, so please tell > me if I forgot anything. > > Here are the results of running the test: > > === gcc Summary === > > # of expected passes 182481 > # of unexpected failures 91 > # of unexpected successes 20 > # of expected failures 1475 > # of unsupported tests 2535 > > === g++ Summary === > > # of expected passes 231596 > # of unexpected failures 1 > # of expected failures 2083 > # of unsupported tests 9948 > > === jit Summary === > > # of expected passes 14542 > # of unexpected failures 1 > > === libstdc++ Summary === > > # of expected passes 15538 > # of expected failures 95 > # of unsupported tests 653 > > === libgomp Summary === > > # of expected passes 5012 > # of expected failures 33 > # of unsupported tests 323 > > === libitm Summary === > > # of expected passes 44 > # of expected failures 3 > # of unsupported tests 1 > > === libatomic Summary === > > # of expected passes 54 > > It's the first time I run the whole testsuite, so I'm not sure if those > failures are normal. I got more unexpected failures for the gcc tests > than what is shown in https://gcc.gnu.org/pipermail/gcc- > testresults/2022-June/764154.html. In any case, I get the same failures > when running the testsuite on master. Perhaps my configure command is > wrong? I used the following: You can use ./contrib/compare_tests to see if there's no failure or new pass. ./contrib/compara_tests is under gcc top directory. > > ../../gcc/configure --enable-host-shared --enable- > languages=c,jit,c++,lto --enable-checking=release > --prefix=(pwd)/../install > --enable-checking=release will give up some internal checks to increase the compilation speed, for the development trunk, it is better not to use release. > Thanks for the review. > > Antoni Boucher (1): > target: Fix asm generation for AVX builtins when using -masm=intel > [PR106095] > > gcc/config/i386/sse.md | 10 ++--- > gcc/testsuite/gcc.target/i386/pr106095.c | 47 ++++++++++++++++++++++++ > 2 files changed, 52 insertions(+), 5 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/pr106095.c > > -- > 2.34.2 -- BR, Hongtao