From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by sourceware.org (Postfix) with ESMTPS id 7524C3858D33 for ; Tue, 27 Jun 2023 05:11:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7524C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-576918f4cf7so33096757b3.3 for ; Mon, 26 Jun 2023 22:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687842718; x=1690434718; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5v1s/13gcgL/LFFFGWRIATWmmoholheZiP3XNxPIyaw=; b=PTjWnYkbO5+Ia/cQujcXWXHYz8p28tp1yqT25toLJufPxlCrSHAovdrfMoV794JZoz f305KREkjdP1PPGlLhDnFVbZWxQDxRYVpOflySph1A5PT1i4M1ki+dl9dPq8P58Yf35o yIVqvn/o8/hYO/rq/lanLx6A0ASllWA2sQ9wCJgA7wuR2rYRar/0KIq2temszKMm2kTJ k69SCkGfNL+5P2Gp3yFFerSZDgt57eVO1qBejGAiTkDANsBRCTtiCJ5dN1Bko2A79dGe bUcomHvYS1umLbi/HrSxUoxuiULhuE0UGK7ryXtzsSfSBRUtEQG2RQrMr8AfKVxW128S yWTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687842718; x=1690434718; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5v1s/13gcgL/LFFFGWRIATWmmoholheZiP3XNxPIyaw=; b=jNJX23hYzPFrDzABKmYV55tgAW/4NExtTPgL6L6uiYmrjWqDXp8HF0oy3sN0ourqec Gjesr8MXcgwuEV9/BsU0EHX4NVuriO9pfsKUQODmsqWjnKnlqt+95Au49H/2wbeeUaQ2 8CQirKT5Lc754JA4COeQ6vVx5OzETormbbfg71/6zkc1d0oQJ7Yuo+ddhtSFjXxXihDX uOiohmog4NWUhiryj6U/sFxnENBmZel9CaqX5cvUtZSBW9Rnc6OpAoxdXFBY/A9CjH8V nZyihCqewYHBk2JZ3LzS6EsgVFkJmi5Qt7LhgyNTzaCmJhANndHNXjYIEckA4ErD9ng6 xl4A== X-Gm-Message-State: AC+VfDwgVzx61STyDhQbb0zbdmjz8EqFiyA4rsKw4CTqXsCUCd2BTOLX 1gmOfT8/ZlhUxxMUIyWLNXfnKXuVdV5Iw/pp5vU= X-Google-Smtp-Source: ACHHUZ4MxQ9lYovw5WePyUcSApL1BUoDD8ONirdGjzi/g6u15pG9mPJuSROEmmxpKLIAYRBXYUt6QpxO4HBp6guXLac= X-Received: by 2002:a25:74c3:0:b0:c00:10a5:4c6a with SMTP id p186-20020a2574c3000000b00c0010a54c6amr15447176ybc.57.1687842717746; Mon, 26 Jun 2023 22:11:57 -0700 (PDT) MIME-Version: 1.0 References: <169ca252-3828-b466-4d47-a8fe720ec4ef@suse.com> <7a8c5593-c53d-9c45-ffcd-c48cdd3ef911@suse.com> In-Reply-To: From: Hongtao Liu Date: Tue, 27 Jun 2023 13:11:46 +0800 Message-ID: Subject: Re: [PATCH v3] x86: make VPTERNLOG* usable on less than 512-bit operands with just AVX512F To: Jan Beulich Cc: "gcc-patches@gcc.gnu.org" , Kirill Yukhin , Hongtao Liu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 20, 2023 at 5:34=E2=80=AFPM Hongtao Liu wr= ote: > > On Tue, Jun 20, 2023 at 5:03=E2=80=AFPM Jan Beulich w= rote: > > > > On 20.06.2023 10:33, Hongtao Liu wrote: > > > On Tue, Jun 20, 2023 at 3:07=E2=80=AFPM Jan Beulich via Gcc-patches > > > wrote: > > >> > > >> I guess the underlying pattern, going along the lines of what > > >> one_cmpl2 uses, can be applied elsewh= ere > > >> as well. > > > That should be guarded with !TARGET_PREFER_AVX256, let's handle that > > > in a separate patch. > > > > Sure, and as indicated there are more places where similar things could > > be done. > > > > >> --- /dev/null > > >> +++ b/gcc/testsuite/gcc.target/i386/avx512f-copysign.c > > >> @@ -0,0 +1,32 @@ > > >> +/* { dg-do compile } */ > > >> +/* { dg-options "-mavx512f -mno-avx512vl -O2" } */ > > > Please explicitly add -mprefer-vector-width=3D512, our tester will al= so > > > test unix{-m32 \-march=3Dcascadelake,\ -march=3Dcascadelake} which se= t the > > > - mprefer-vector-width=3D256, -mprefer-vector-width=3D512 in dg-optio= ns > > > can overwrite that. > > > > Oh, I see. Will do. And I expect I then also need to adjust the newly > > added avx512f-dupv2di.c from the earlier patch. I guess I could commit > > that option addition there as obvious? > Still need to send out the patch, and commit as an obvious fix. > > > > > Others LGTM. > > > > May I take this as "okay with that change", or should I submit v4? > Okay. no need for a v4 version. > > avx512f-copysign.c failed for -m32, we need to add -mfpmath=3Dsse to dg-opt= ions. cs_df: .LFB0: .cfi_startproc fldl 12(%esp) fxam fnstsw %ax fstp %st(0) fldl 4(%esp) fabs testb $2, %ah je .L1 fchs .L1: ret .cfi_endproc .LFE0: .size cs_df, .-cs_df .p2align 4 .globl cs_sf .type cs_sf, @function cs_sf: .LFB1: .cfi_startproc flds 8(%esp) fxam fnstsw %ax fstp %st(0) flds 4(%esp) testb $2, %ah fabs fld %st(0) fchs fcmove %st(1), %st fstp %st(1) ret .cfi_endproc .LFE1: .size cs_sf, .-cs_sf .p2align 4 .globl cs_v2df .type cs_v2df, @function > > Jan > > > > -- > BR, > Hongtao --=20 BR, Hongtao