From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by sourceware.org (Postfix) with ESMTPS id 20FED3858C56 for ; Fri, 14 Oct 2022 08:30:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20FED3858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb33.google.com with SMTP id e20so4813756ybh.2 for ; Fri, 14 Oct 2022 01:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OSu59PY+MH5+m0zTeoE/396jPYBYb+hqpoVRFqhv4j4=; b=lUD9xXwEPhEVHm8uEty/aQKRDqa0P4Tp4QdlWLsI5EbTPj978vU+zJ7gtCINhyKEBF ypBvn1lG+zK1n/JZV/esJIig7qsjhIUj7BAsB651rv0lrSk5AX30Dgo9Y6bPRaMxaB1k oqUncOBnCnABsuP44az6C34VO4N4zEgoYBi0OgYjjin8J7KYcJVBfP3e9pTeDLZANRLH 1BvrE+5IkZuyBkBK8rcd7Fh6eun62oL3vXhPzTUsNDzphUDwKn+mxeMo4jjUN5YhH+vQ iFrkr3ThJYargVwWpxzCt+aosnXVIC2G/iJiKEBi/tUsi9RLk3gdaqYYCW+lXO5iHUB6 0Xuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OSu59PY+MH5+m0zTeoE/396jPYBYb+hqpoVRFqhv4j4=; b=mVRoeNqIScwUQ6U9m3JaB2AIZDWlbpYKitUM1ogk8N+V8HlJMnsLPcqmdEE3knsM6v SffkPcJEIW8tM+xgrqoujVa8qey9eBqL+8B8hj290c7p5QJB5B+s9yoyFRy60Uto9hNF sAxppVg0mkVIHkVMVOdZywK+Sz95kWrgBtOKCBpVr5vdRKrom0DPWAfQb4e7ZRRrcvFd IAUzqLEjLQeUiacbLigdEMUHMon1vO1EmWAmesp/6YOTXdSo7HRRLdqMsGp/CjZsnsdc z430Df8+aGNQzObWJLEezZckUIhn15vkaVs/AEPtN0sHbjvh3GxgRk4Y6JwXSHkg/aab wxjg== X-Gm-Message-State: ACrzQf2KjV+MUHHduCVFL18I44PRt13ZHiiMvz3WEkmCH6Ri9yZY793j q9IXT8fhpHeFfd0TjV1ddHDXr9JU6kSwQIYBwR4= X-Google-Smtp-Source: AMsMyM5WWRjJQcdvzdTiPQc4168fE5139ccPQUp1tHlygseuqJiz0l86oqCGo4GYJumNZEKKn2af8hS8hTnwfunjiMs= X-Received: by 2002:a25:ab2c:0:b0:6c0:fec7:ae78 with SMTP id u41-20020a25ab2c000000b006c0fec7ae78mr3821583ybi.296.1665736218500; Fri, 14 Oct 2022 01:30:18 -0700 (PDT) MIME-Version: 1.0 References: <20221014075445.7938-1-haochen.jiang@intel.com> In-Reply-To: From: Hongtao Liu Date: Fri, 14 Oct 2022 16:30:07 +0800 Message-ID: Subject: Re: [PATCH 0/6] Add Intel Sierra Forest Instructions To: "Lu, Hongjiu" Cc: Haochen Jiang , hongtao.liu@intel.com, GCC Patches , Iain Sandoe Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Oct 14, 2022 at 4:24 PM Iain Sandoe wrote: > > > > > On 14 Oct 2022, at 09:20, Hongtao Liu wrote: > > > > On Fri, Oct 14, 2022 at 4:14 PM Iain Sandoe via Gcc-patches > > wrote: > >> > >> Hi Haochen > >> > >>> On 14 Oct 2022, at 08:54, Haochen Jiang via Gcc-patches wrote: > >>> > >> > >>> These six patches aimed to add Intel Sierra Forest instructions, including > >>> AVX-IFMA, AVX-VNNI0INT8, AVX-NE-CONVERT, CMPccXADD. We also added intrinsic > >>> for vector __bf16 in this series of patch and Sierra Forest Support. > >>> > >>> The information is based on newly released > >>> Intel Architecture Instruction Set Extensions and Future Features. > >>> > >>> The document comes following: > >>> https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html > >>> > >>> Regtested on x86_64-pc-linux-gnu. Ok for trunk? > >> > >> Have you tested that the testcases work on older platforms that do not have support > >> for the new instructions in their assemblers? > >> > >> I could not see any target-requires changes in the testcases .. hence my question. > >> > > Guess you are looking at compile tests? > > yes, compile tests would need support from the assembler. > > > > For runtime test, we have add assembler check(target-requires changed) > > plus runtime check(builtin_cpu_supports) > > .i.e. > > > > +++ b/gcc/testsuite/gcc.target/i386/avx-ifma-vpmaddhuq-2.c > > @@ -0,0 +1,72 @@ > > +/* { dg-do run } */ > > +/* { dg-options "-O2 -mavxifma" } */ > > +/* { dg-require-effective-target avxifma } */ > > > > Do I miss some? > > I would need to look at the sources after patching (perhaps they already have > suitable target-requires that did not show up in the patch). > > Do you have this series as a branch somewhere that I can try on one of the > like affected platforms? Not yet. Do we have any external place to put those patches so folks from the community can validate before it's committed, HJ? > > Iain > -- BR, Hongtao