From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by sourceware.org (Postfix) with ESMTPS id 15A703858C74 for ; Sat, 26 Mar 2022 06:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 15A703858C74 Received: by mail-vk1-xa29.google.com with SMTP id d7so5332797vkd.11 for ; Fri, 25 Mar 2022 23:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UqMX8BhgFbO1Qq/EUElMf3w9erj+Erlj3nB0hHBvc1U=; b=GOGH6zONg1gTnu27gy2PipwzrtSBV+z3A+axDkb57CwAEVEDNRvVNMPCEa0eAv2h0E pJgicQkp977y1qm+50rlgX+NL2WPFLbzC5CGsRBQAc3giEjn7uKb5/NszCLPdw6Tg5Xy 4h6Or3Mb2n0DEJ9iz1yqyCFAXGVhiNhVBPBxpJtnzf9RqxK8s77Pp59whlSUIEWeqtsg 05V34TrnMuQeRtKzoh1ez/zb3aDa56g6Ia9ycGhu/WV7T4/tNiUAvmbtPPXUih6cAzCF ht7ku1oir5DKxNi3NqfO1EFBvrpPcvSOSk5EoNXgPPCbqYU98pST7dbLq37e215skPBX p1hA== X-Gm-Message-State: AOAM5339roYCDXTjBluX5qR2tmE7YqJ8L+T67Val4kCe7XAGrvi3YedS UQHe87/+fUMN5asslUYKdNP4GOltyIjIfCBqhWTKzzAzfC5GOQ== X-Google-Smtp-Source: ABdhPJwZi5FfZHTUgyPHKzu8vTf4yld1nwKRZB3z74SoVKkaevunXl2JuOIrU4ANcLNoBKnc4MkYZ4wAiN/X0JcEBLU= X-Received: by 2002:a1f:cac4:0:b0:336:e9ff:7e42 with SMTP id a187-20020a1fcac4000000b00336e9ff7e42mr6973289vkg.14.1648277490390; Fri, 25 Mar 2022 23:51:30 -0700 (PDT) MIME-Version: 1.0 References: <20220325205014.32895-1-hjl.tools@gmail.com> In-Reply-To: From: Hongtao Liu Date: Sat, 26 Mar 2022 14:51:19 +0800 Message-ID: Subject: Re: [PATCH] x86: Use x constraint on KL patterns To: Hongyu Wang Cc: "H.J. Lu" , liuhongt , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2022 06:51:32 -0000 On Sat, Mar 26, 2022 at 10:05 AM Hongyu Wang via Gcc-patches wrote: > > > > Is it possible to create a test case that gas would throw an error fo= r > > > invalid operands? > > > > You can use -ffix-xmmN to disable XMM0-15. > > I mean can we create an intrinsic test for this PR that produces xmm16-31= ? > And the -ffix-xmmN is an option for assembler or compiler? I didn't > find it in document. Can be reproduced by below testcase. #include unsigned int ctrl; __m128i k1, k2, k3; void test_keylocker_11 (void) { register __m128i k4 __asm ("xmm16") =3D k2; asm volatile ("" : "+v" (k4)); _mm_loadiwkey (ctrl, k1, k4, k3); } /tmp/ccy9VHP9.s: Assembler messages: /tmp/ccy9VHP9.s:13: Error: unsupported instruction `loadiwkey' > > H.J. Lu =E4=BA=8E2022=E5=B9=B43=E6=9C=8826=E6=97=A5= =E5=91=A8=E5=85=AD 09:22=E5=86=99=E9=81=93=EF=BC=9A > > > > On Fri, Mar 25, 2022 at 6:08 PM Hongyu Wang wr= ote: > > > > > > Is it possible to create a test case that gas would throw an error fo= r > > > invalid operands? > > > > You can use -ffix-xmmN to disable XMM0-15. > > > > > H.J. Lu via Gcc-patches =E4=BA=8E2022=E5=B9= =B43=E6=9C=8826=E6=97=A5=E5=91=A8=E5=85=AD 04:50=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > > Since KL instructions have no AVX512 version, replace the "v" regis= ter > > > > constraint with the "x" register constraint. > > > > > > > > PR target/105058 > > > > * config/i386/sse.md (loadiwkey): Replace "v" with "x". > > > > (aesu8): Likewise. > > > > --- > > > > gcc/config/i386/sse.md | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > > > > index 29802d00ce6..33bd2c4768a 100644 > > > > --- a/gcc/config/i386/sse.md > > > > +++ b/gcc/config/i386/sse.md > > > > @@ -28364,8 +28364,8 @@ (define_insn "avx512f_dpbf16ps__mask" > > > > > > > > ;; KEYLOCKER > > > > (define_insn "loadiwkey" > > > > - [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand"= "v") > > > > - (match_operand:V2DI 1 "register_operand" = "v") > > > > + [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand"= "x") > > > > + (match_operand:V2DI 1 "register_operand" = "x") > > > > (match_operand:V2DI 2 "register_operand" = "Yz") > > > > (match_operand:SI 3 "register_operand" = "a")] > > > > UNSPECV_LOADIWKEY) > > > > @@ -28498,7 +28498,7 @@ (define_int_attr aesklvariant > > > > (UNSPECV_AESENC256KLU8 "enc256kl")]) > > > > > > > > (define_insn "aesu8" > > > > - [(set (match_operand:V2DI 0 "register_operand" "=3Dv") > > > > + [(set (match_operand:V2DI 0 "register_operand" "=3Dx") > > > > (unspec_volatile:V2DI [(match_operand:V2DI 1 "register_oper= and" "0") > > > > (match_operand:BLK 2 "memory_opera= nd" "m")] > > > > AESDECENCKL)) > > > > -- > > > > 2.35.1 > > > > > > > > > > > > -- > > H.J. --=20 BR, Hongtao