From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id CCA1C385803D for ; Tue, 30 Nov 2021 09:47:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCA1C385803D Received: by mail-ua1-x934.google.com with SMTP id p2so40014228uad.11 for ; Tue, 30 Nov 2021 01:47:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3jXtEtWQBeGRjA0Cux4+9ADRpr/wxyh7KD5fwY/0y1g=; b=QtU8Oik0A2WE/OfSz335En/7N22WuZy+981LQv8VYkzNo3qvA9ooEGZP5BDLMIB1P/ K087RPWRBboe+jcoFjyhHBhbfKZyTeO+FzmxZi2f7mCSDBn4pK4OjL7RcTSYVuNQPM8Q eRIwk3gJ8WI5eKkLY3hCJ1bIrXDElTpFdVxVvFzLCHROpFQPnX1KxsT0AW4ojl8nJTHh yOfiDbEjW9p9XJAPRD0Ssvyzz3SOtZQMSzUvH7H1qkkqWQtzKo7EXrflN1KeekncTfmg yaIxlC/yPqqMOToBN3LSDKaMbH0fQX5u1Wvew8E9IqshilyOB5VMQeBrMnitn/YC09KU a4cQ== X-Gm-Message-State: AOAM5322lC+5a75+3GvT3dgIHbnj/XKT6eJhFzaZahpOuP4aJSctpCqU QltPq2JA+tguDj7zVp38LVMvt6PtwuuTm5lEnTa+lGZk X-Google-Smtp-Source: ABdhPJy9z7kuopUp/iQbd87DFR4KUXVsR7gCZap34lZOG/xxy6oRZKkZNIIg8LwwPvoW6ij5JvG+d/afUrDbBjyEjp8= X-Received: by 2002:ab0:6354:: with SMTP id f20mr55865295uap.116.1638265623400; Tue, 30 Nov 2021 01:47:03 -0800 (PST) MIME-Version: 1.0 References: <20211130094329.22379-1-hongtao.liu@intel.com> In-Reply-To: <20211130094329.22379-1-hongtao.liu@intel.com> From: Hongtao Liu Date: Tue, 30 Nov 2021 17:54:19 +0800 Message-ID: Subject: Re: [PATCH] [i386] Fix ICE in ix86_attr_length_immediate_default. To: Uros Bizjak Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 09:47:05 -0000 On Tue, Nov 30, 2021 at 5:44 PM liuhongt via Gcc-patches wrote: > > ix86_attr_length_immediate_default assume TYPE ishift only have 1 > constant operand, > but *x86_64_shld_1/*x86_shld_1/*x86_64_shrd_1/*x86_shrd_1 has 2, with > condition: INTVAL (operands[3]) == 32 - INTVAL (operands[2]) or > INTVAL (operands[3]) == 64 - INTVAL (operands[2]), and hit > gcc_assert. > Explicitly set_attr length_immediate for these patterns. > > Bootstrapped and regtested on x86_64-pc-linux-gnu{-m32,}. > Ok for trunk? > > > gcc/ChangeLog: > > PR target/103463 > PR target/103484 > * config/i386/i386.md (*x86_64_shld_1): Set_attr > length_immediate to 1. > (*x86_shld_1): Ditto. > (*x86_64_shrd_1): Ditto. > (*x86_shrd_1): Ditto. > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/pr103463.c: New test. > * gcc.target/i386/pr103463-2.c: New test. > --- > gcc/config/i386/i386.md | 4 ++++ > gcc/testsuite/gcc.target/i386/pr103463-2.c | 14 ++++++++++++++ > gcc/testsuite/gcc.target/i386/pr103463.c | 13 +++++++++++++ > 3 files changed, 31 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/i386/pr103463-2.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr103463.c > > diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md > index c88374c9d2b..4e9fae80479 100644 > --- a/gcc/config/i386/i386.md > +++ b/gcc/config/i386/i386.md > @@ -11512,6 +11512,7 @@ (define_insn "*x86_64_shld_1" > [(set_attr "type" "ishift") > (set_attr "prefix_0f" "1") > (set_attr "mode" "DI") > + (set_attr "length_immediate" "1") > (set_attr "athlon_decode" "vector") > (set_attr "amdfam10_decode" "vector") > (set_attr "bdver1_decode" "vector")]) > @@ -11573,6 +11574,7 @@ (define_insn "*x86_shld_1" > "shld{l}\t{%2, %1, %0|%0, %1, %2}" > [(set_attr "type" "ishift") > (set_attr "prefix_0f" "1") > + (set_attr "length_immediate" "1") > (set_attr "mode" "SI") > (set_attr "pent_pair" "np") > (set_attr "athlon_decode" "vector") > @@ -12384,6 +12386,7 @@ (define_insn "*x86_64_shrd_1" > "shrd{q}\t{%2, %1, %0|%0, %1, %2}" > [(set_attr "type" "ishift") > (set_attr "prefix_0f" "1") > + (set_attr "length_immediate" "1") > (set_attr "mode" "DI") > (set_attr "athlon_decode" "vector") > (set_attr "amdfam10_decode" "vector") > @@ -12446,6 +12449,7 @@ (define_insn "*x86_shrd_1" > "shrd{l}\t{%2, %1, %0|%0, %1, %2}" > [(set_attr "type" "ishift") > (set_attr "prefix_0f" "1") > + (set_attr "length_immediate" "1") > (set_attr "mode" "SI") > (set_attr "pent_pair" "np") > (set_attr "athlon_decode" "vector") > diff --git a/gcc/testsuite/gcc.target/i386/pr103463-2.c b/gcc/testsuite/gcc.target/i386/pr103463-2.c > new file mode 100644 > index 00000000000..9c29b70bbd8 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr103463-2.c > @@ -0,0 +1,14 @@ > +/* { dg-do compile { target { ! ia32 } } } */ > +/* { dg-options "-O2 -fno-tree-bit-ccp" } */ > + > +int foo_u64_1; > +unsigned __int128 foo_u128_1; > + > +void > +foo (void) > +{ > + foo_u128_1 <<= 127; > + foo_u64_1 += __builtin_sub_overflow_p (0, (long) foo_u128_1, 0); > + foo_u128_1 = > + foo_u128_1 >> (foo_u128_1 & 127) | foo_u128_1 << (-foo_u128_1 & 127); > +} > diff --git a/gcc/testsuite/gcc.target/i386/pr103463.c b/gcc/testsuite/gcc.target/i386/pr103463.c > new file mode 100644 > index 00000000000..faae9a858e5 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/i386/pr103463.c > @@ -0,0 +1,13 @@ > +/* { dg-do compile { target { ! ia32 } } } */ > +/* { dg-options "-Os -fno-tree-dominator-opts -fno-tree-vrp" } */ > + > +int bar0_u8_0, bar0_u16_0, bar0_u32_0, bar0_u16_1, bar0_u32_1; > +unsigned __int128 bar0_u128_0; > + > +int > +bar0() { > + bar0_u16_1 *= > + __builtin_add_overflow_p(bar0_u16_0, bar0_u32_1, (long)bar0_u8_0); > + bar0_u128_0 = bar0_u128_0 >> bar0_u16_1 | bar0_u128_0 << (-bar0_u16_1 & 127); > + bar0_u128_0 += __builtin_mul_overflow_p(bar0_u32_0, 20, 0); > +} > -- > 2.18.1 > -- BR, Hongtao