From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by sourceware.org (Postfix) with ESMTPS id 90DF73857027 for ; Thu, 4 May 2023 05:36:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90DF73857027 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-b9d7659d89fso143705276.1 for ; Wed, 03 May 2023 22:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683178582; x=1685770582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RrtqQh2Om+4C0QolZx/E6u4GuI0+Kai3K8VppVmAhww=; b=H4WShk9iboGdPzTs3IQZVgAjc+ypFX/dlKeNQrW4GzJrJfBcL4J3j6HcjOf4M0zQzK dCSrfqPxMl3dP1LEcczznoQD5l7KkzLAIiiNB+khvUjfIesT2fTUKQZTeGr2khWPSC4C D90zNnrqyMwjYW39cjfBe0NwrJTIh5x/ewuvLBWqzWZ9pnPjpDSX3+JxcplPeTauZke1 c1nw61sRVupPIZy4eGvyPPqva4kW1KPrPZYx75ZSjsgGo60IKi6Oqqfm0mNMONu7Gm/L 1jSPkKI6fKTrPnSCZxrJWHK68rYyaJzDWKvHQ4WqbPihD+4erFLqe4jUfx5QtduUzzqf 75xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683178582; x=1685770582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RrtqQh2Om+4C0QolZx/E6u4GuI0+Kai3K8VppVmAhww=; b=mC2IbffF8idMyTpTK1Vx3b48Pl6vWtxjW7Q4SAoN2fk/HuvYNFxJQoLtcKHJnsHihY 9ZUNtbShDWw+Ny+9v3Fq8QvS1FB5ptJjd8ySmVzHSiiCAEp0gTjla6PxqpQ6JrnMb76A ZA0pJQb8UlHTUn0jFTaL99UMCUNJYXdV7dyGQCme2+TVfgqcOijk1Nu/2vKElGtducg7 Be+TP+RJrRE1AGNkjo+ShWuWf559xOHYDqqukVLrLXKL5t7/xBWSsMl5bnOwmUE30h8B VZfP3AK9wsFgUM5IW39IDR3/69uz+DMDn8FsVT7mxzJAFWfPYVjsV/YisLTGGyW6GWwo Earg== X-Gm-Message-State: AC+VfDwZdvHxtmRI25Jjcn/5bxdzUsb0gONWZ/NwP11gZNo/yC78pgxZ FN6HfoyzKjtpAcoDSEuU+t8CSKUfdyc+kaeDNzs= X-Google-Smtp-Source: ACHHUZ4sgDg/2eqApQF7V3QRgcgY7au7H6B7pbwf+CyKB7jmHyh8Hd1hn6OjEDpe5LpH3HBm/ZZHFH9dfBLQlDb/A1Y= X-Received: by 2002:a25:cd89:0:b0:b8b:e98b:cbb with SMTP id d131-20020a25cd89000000b00b8be98b0cbbmr20256583ybf.38.1683178581943; Wed, 03 May 2023 22:36:21 -0700 (PDT) MIME-Version: 1.0 References: <20221215062137.3128845-1-hongtao.liu@intel.com> <20221215062137.3128845-2-hongtao.liu@intel.com> In-Reply-To: From: Hongtao Liu Date: Thu, 4 May 2023 13:36:11 +0800 Message-ID: Subject: Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR. To: Uros Bizjak Cc: "H.J. Lu" , gcc-patches@gcc.gnu.org, Jakub Jelinek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 4, 2023 at 1:35=E2=80=AFPM Hongtao Liu wro= te: > > On Thu, Dec 22, 2022 at 4:04=E2=80=AFPM Uros Bizjak w= rote: > > > > On Thu, Dec 22, 2022 at 5:40 AM Hongtao Liu wrote: > > > > > > On Thu, Dec 22, 2022 at 6:46 AM Jakub Jelinek wrot= e: > > > > > > > > On Wed, Dec 21, 2022 at 02:43:43PM -0800, H.J. Lu wrote: > > > > > > > > > > > Target RejectNegative > > > > > > > > > > > Set 80387 floating-point precision to 80-bit. > > > > > > > > > > > > > > > > > > > > > > +mdaz-ftz > > > > > > > > > > > +Target > > > > > > > > > > > > > > > > > > > > s/Target/Driver/ > > > > > > > > > Change to Driver and Got error like:cc1: error: command-l= ine option > > > > > > > > > =E2=80=98-mdaz-ftz=E2=80=99 is valid for the driver but n= ot for C. > > > > > > > > Hi Jakub: > > > > > > > > I didn't find a good solution to handle this error after = changing > > > > > > > > *Target* to *Driver*, Could you give some hints how to solv= e this > > > > > > > > problem? > > > > > > > > Or is it ok for you to mark this as *Target*(there won't be= any save > > > > > > > > and restore in cfun since there's no variable defined here.= ) > > > > > > > > > > > > > > Since all -m* options are passed to cc1, -mdaz-ftz can't be m= arked > > > > > > > as Driver. We need to give it a different name to mark it as= Driver. > > > > > > > > > > > > It is ok like that. > > > > > > > > > > > > Jakub > > > > > > > > > > > > > > > > The GCC driver handles -mno-XXX automatically for -mXXX. Use > > > > > a different name needs to handle the negation. Or we can do som= ething > > > > > like this to check for CL_DRIVER before passing it to cc1. > > > > > > > > I meant I'm ok with -m{,no-}daz-ftz option being Target rather than= Driver. > > > > > > > Thanks. > > > Uros, Is the patch for you? > > > > The original patch is then OK. > Some users found the -mdaz-ftz option to be very useful, and want it > to be backport to GCC12 and GCC11. > But the patch is not a bugfix one, so i'd like to ask options from s/options/opinions/g > other maintainers, if the patch is suitable for backport? > > The backport patches include both this one and [1] which apply > -mdaz-ftz to all other x86 targets. > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610053.html > > > > > Thanks, > > Uros. > > > > -- > BR, > Hongtao --=20 BR, Hongtao