From: Hongtao Liu <crazylht@gmail.com>
To: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Fix up testcase.
Date: Wed, 9 Dec 2020 18:24:55 +0800 [thread overview]
Message-ID: <CAMZc-bxtHdnYhD63gCpQG-yW07Q7u40x=Sd0Ys9q6O5kQzJ3Uw@mail.gmail.com> (raw)
In-Reply-To: <CAAgBjMnAsJq7vQQqHBAnfr_2E3A2Yizxw7eyrAcPN5jwy12XNQ@mail.gmail.com>
On Wed, Dec 9, 2020 at 5:22 PM Prathamesh Kulkarni via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Wed, 9 Dec 2020 at 00:29, sunil.k.pandey <skpandey@sc.intel.com> wrote:
> >
> > On Linux/x86_64,
> >
> > 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1 is the first bad commit
> > commit 3a6e3ad38a17a03ee0139b49a0946e7b9ded1eb1
> > Author: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
> > Date: Tue Dec 8 14:30:04 2020 +0530
> >
> > gimple-isel: Fold x CMP y ? -1 : 0 to x CMP y [PR97872]
> >
> > caused
> >
> > FAIL: gcc.target/i386/pr78102.c scan-assembler-times pcmpeqq 3
> Hi,
> This is a known issue with the patch, and discussed here:
> https://gcc.gnu.org/pipermail/gcc/2020-December/234438.html
> I guess Hongtao will check in a fix for that soon.
>
According to https://uops.info/table.html,
both pcmpeqq and pcmpeqd use only port 1, so i think there's no
performance difference between
vpcmpeqq %xmm1, %xmm0, %xmm0
vpxor %xmm1, %xmm1, %xmm1
vpcmpeqq %xmm1, %xmm0, %xmm0
and
vpcmpeqq %xmm1, %xmm0, %xmm0
vpcmpeqd %xmm1, %xmm1, %xmm1
vpandn %xmm1, %xmm0, %xmm0
So fix up testcase as below.
gcc/testsuite
* gcc.target/i386/i386/pr78102.c: Adjust testcase.
1 file changed, 1 insertion(+), 1 deletion(-)
gcc/testsuite/gcc.target/i386/pr78102.c | 2 +-
modified gcc/testsuite/gcc.target/i386/pr78102.c
@@ -1,7 +1,7 @@
/* PR target/78102 */
/* { dg-do compile } */
/* { dg-options "-O2 -mno-sse4.2 -msse4.1" } */
-/* { dg-final { scan-assembler-times "pcmpeqq" 3 } } */
+/* { dg-final { scan-assembler-times "pcmpeq" 4 } } */
Ok for trunk?
--
BR,
Hongtao
next prev parent reply other threads:[~2020-12-09 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 18:59 [r11-5839 Regression] FAIL: gcc.target/i386/pr78102.c scan-assembler-times pcmpeqq 3 on Linux/x86_64 sunil.k.pandey
2020-12-09 9:21 ` Prathamesh Kulkarni
2020-12-09 10:24 ` Hongtao Liu [this message]
2020-12-10 12:51 ` [PATCH] Fix up testcase Prathamesh Kulkarni
2020-12-11 5:15 ` Hongtao Liu
2020-12-11 6:52 ` Prathamesh Kulkarni
2020-12-13 15:58 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZc-bxtHdnYhD63gCpQG-yW07Q7u40x=Sd0Ys9q6O5kQzJ3Uw@mail.gmail.com' \
--to=crazylht@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).