From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id 5E8973858C60 for ; Wed, 8 Sep 2021 00:50:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E8973858C60 Received: by mail-vk1-xa2c.google.com with SMTP id 3so190988vkg.7 for ; Tue, 07 Sep 2021 17:50:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GkjDsSX+ZIlhiNA8XhQNS85LfC6lpNyrtTnSA06c0Yo=; b=DdhxLSSkhrcWrFk0Amfg/NXAsrd0HUD0Xw8TrHhCTXrNZCaIr4rpahGQZhX1eoy6fa tojnP/xxfCs0Z4xYfSb7jathlmUfMoWIGQXvqFb5oBpyeqZ8wRBGREX+0pItfl3Uw1xj oxEAllOKpApHplJBs+A+3C/sRHcuKjeA6Rziul6yIYzfHEnUzV+jV8eF1gE/7mzvKzU5 i+iVpSRrI8nG7Za3m1ZHsTWghOGRT3BtIgnR0k3t9L9+3jDLohlfLPUrIelwXai+aCZJ X/bTm7mTtySN1e4r9PmENDXVE5Iq36iYHza5NS48Vl/vVAWKNTn39v6SqQLoyjIKP8kB GOMw== X-Gm-Message-State: AOAM531FN/uEeKIGYJZYvtykRPWxhJmcR+SL1OehSSTiNXzXnSetGcLp vlWgyWSQ6l0ZavnIUWI3wS75geVwRVRT99EwVZAMIKwvDuke+w== X-Google-Smtp-Source: ABdhPJwQW6+6cI5N9hdngXd1yuGpxaPrSf0i5fvsBeyuOGX/feKZgFBegs9IwDxpNqHpOA1hodOMYaXaBYU8cBkcRiE= X-Received: by 2002:a1f:a28a:: with SMTP id l132mr579771vke.21.1631062219051; Tue, 07 Sep 2021 17:50:19 -0700 (PDT) MIME-Version: 1.0 References: <20210831111749.1530591-1-hongtao.liu@intel.com> <20210831111749.1530591-3-hongtao.liu@intel.com> <20210902175526.GK1583@gate.crashing.org> <87a6ktog1g.fsf@igel.home> <20210907231927.GN1583@gate.crashing.org> In-Reply-To: <20210907231927.GN1583@gate.crashing.org> From: Hongtao Liu Date: Wed, 8 Sep 2021 08:55:56 +0800 Message-ID: Subject: Re: [PATCH 2/2] Get rid of all float-int special cases in validate_subreg. To: Segher Boessenkool Cc: Andreas Schwab , Richard Sandiford , liuhongt , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 00:50:20 -0000 On Wed, Sep 8, 2021 at 7:20 AM Segher Boessenkool wrote: > > On Fri, Sep 03, 2021 at 05:05:47PM +0200, Andreas Schwab wrote: > > On Sep 02 2021, Segher Boessenkool wrote: > > > On Tue, Aug 31, 2021 at 07:17:49PM +0800, liuhongt via Gcc-patches wrote: > > >> * emit-rtl.c (validate_subreg): Get rid of all float-int > > >> special cases. > > > > > > This caused various regressions on powerpc. Please revert this until > > > this can be done safely (the comment this patch deletes says why it can > > > not be done yet). > > > > This also breaks ada on riscv64. > > > > s-fatgen.adb: In function 'System.Fat_Flt.Attr_Float.Scaling': > > s-fatgen.adb:830:8: error: unable to find a register to spill > > s-fatgen.adb:830:8: error: this is the insn: > > (insn 215 321 216 26 (set (reg:SF 88 [ xx.26_39 ]) > > (mult:SF (reg:SF 190) > > (subreg:SF (reg:DI 221 [164]) 0))) "s-fatgen.adb":821:25 17 {mulsf3} > > (expr_list:REG_DEAD (reg:DI 221 [164]) > > (expr_list:REG_DEAD (reg:SF 190) > > (nil)))) > > during RTL pass: reload > > It still is broken on rs6000. This breaks when building SPEC for > example (but in many more places as well). > > This needs to be fixed somehow. > > I sent > (Message-ID: <20210907230730.GM1583@gate.crashing.org>) that may be a > start discussing this somewhat. The idea of the change looks fine, but > the time isn't ripe for it yet (if it was intentional!) > > In the meantime, various targets still are broken. This needs a real > fix. How many *other* targets have been broken, just not detected yet? riscv64 report related bug. Other than that, no other target reports related regression yet. > > > Segher -- BR, Hongtao