From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id 082F03858D28 for ; Thu, 4 May 2023 05:35:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 082F03858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-55a8019379fso36438897b3.0 for ; Wed, 03 May 2023 22:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683178525; x=1685770525; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IHWL5UBKZM9wwPjgoUrYUAdDrWLrSZV29tN6xH0SRn4=; b=pqBwzOyLIZ1HZzAcVOrl4mG3iDleFTsta98zOomGYWMIdJNGy6BkYS0LujT1Iogzfx VT7fXgQJK+lEypZWgK3Ur1WOwwuKDzv9jdf2UEQgJ2c6B+41FjZ4z2PoNovekpgEx58D baL3boKnFSW9+6XKOlIFEzNsP/rzlxWfOFCO9BPKSy+0NbNs5iRaT+bxiWKOTYV9IUHM 1muhZEKVaatN93CJ2sqiFt7JhBrvRDiRh1sFxA4oRctlSUVmjbFVnssnA1zleUozunac IysONweQ3gN8buTwIo24tgpdwmW6M7gnESMm0yi7VYLD6xjvstNfaLKjobZxlwC9K2xk R9Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683178525; x=1685770525; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IHWL5UBKZM9wwPjgoUrYUAdDrWLrSZV29tN6xH0SRn4=; b=kFRakvBmDlqLzimNzpTBFMrVdVxO0ickwoOBu2hpjjaVMrjSO/hnOZmvFtFrjy2Z3v BqD7ewU9Vjs6Fl7KQHRSWxhunSapWtFkUDH6hcVfOE6VuWkxmAa9jlSNrXGzBgEzRRDL Pl6BVCA9dSgKpGicBtHUmlcmoB/M8w8Rpq5enR+/802Z5Uj4yRK1DUdxx7WlwbhUXCvm etzZar1CttXJ565EQRFM6x1gPkjPye9e6ctCi147WsRva6e5yCrFWD4jXcX+VzvpDyJU d8ttBIPx4Tfo8VHGNu5NShdX86gLnKqaU+iZwF+m9snVKHVpFK9k4IBaTNiz4+d3enmD 5gZg== X-Gm-Message-State: AC+VfDyd2y+GSb39b/1tbD29YMLcE2aSjuGJzGZsK+OlgVLTFNxEIjfc OxMLsAOG+q8iKtlgj0aKQQpJuw9LJsdRYcAKV6U= X-Google-Smtp-Source: ACHHUZ4hMaZT7Rpomxwfkeibd+SUu9lB7hn8/ctTSLwV9HIk6JGES/sB3Hq+AfyagWyMZdzsJNC/mcwpeybt49ZEj9M= X-Received: by 2002:a0d:e6cb:0:b0:55a:470:e957 with SMTP id p194-20020a0de6cb000000b0055a0470e957mr1059453ywe.14.1683178525015; Wed, 03 May 2023 22:35:25 -0700 (PDT) MIME-Version: 1.0 References: <20221215062137.3128845-1-hongtao.liu@intel.com> <20221215062137.3128845-2-hongtao.liu@intel.com> In-Reply-To: From: Hongtao Liu Date: Thu, 4 May 2023 13:35:14 +0800 Message-ID: Subject: Re: [PATCH V2 2/2] [x86] x86: Add a new option -mdaz-ftz to enable FTZ and DAZ flags in MXCSR. To: Uros Bizjak Cc: "H.J. Lu" , gcc-patches@gcc.gnu.org, Jakub Jelinek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Dec 22, 2022 at 4:04=E2=80=AFPM Uros Bizjak wro= te: > > On Thu, Dec 22, 2022 at 5:40 AM Hongtao Liu wrote: > > > > On Thu, Dec 22, 2022 at 6:46 AM Jakub Jelinek wrote: > > > > > > On Wed, Dec 21, 2022 at 02:43:43PM -0800, H.J. Lu wrote: > > > > > > > > > > Target RejectNegative > > > > > > > > > > Set 80387 floating-point precision to 80-bit. > > > > > > > > > > > > > > > > > > > > +mdaz-ftz > > > > > > > > > > +Target > > > > > > > > > > > > > > > > > > s/Target/Driver/ > > > > > > > > Change to Driver and Got error like:cc1: error: command-lin= e option > > > > > > > > =E2=80=98-mdaz-ftz=E2=80=99 is valid for the driver but not= for C. > > > > > > > Hi Jakub: > > > > > > > I didn't find a good solution to handle this error after ch= anging > > > > > > > *Target* to *Driver*, Could you give some hints how to solve = this > > > > > > > problem? > > > > > > > Or is it ok for you to mark this as *Target*(there won't be a= ny save > > > > > > > and restore in cfun since there's no variable defined here.) > > > > > > > > > > > > Since all -m* options are passed to cc1, -mdaz-ftz can't be mar= ked > > > > > > as Driver. We need to give it a different name to mark it as D= river. > > > > > > > > > > It is ok like that. > > > > > > > > > > Jakub > > > > > > > > > > > > > The GCC driver handles -mno-XXX automatically for -mXXX. Use > > > > a different name needs to handle the negation. Or we can do somet= hing > > > > like this to check for CL_DRIVER before passing it to cc1. > > > > > > I meant I'm ok with -m{,no-}daz-ftz option being Target rather than D= river. > > > > > Thanks. > > Uros, Is the patch for you? > > The original patch is then OK. Some users found the -mdaz-ftz option to be very useful, and want it to be backport to GCC12 and GCC11. But the patch is not a bugfix one, so i'd like to ask options from other maintainers, if the patch is suitable for backport? The backport patches include both this one and [1] which apply -mdaz-ftz to all other x86 targets. [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610053.html > > Thanks, > Uros. --=20 BR, Hongtao