From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by sourceware.org (Postfix) with ESMTPS id E1AE0382E06A for ; Fri, 17 Jul 2020 07:23:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E1AE0382E06A Received: by mail-vs1-xe34.google.com with SMTP id q15so4368467vso.9 for ; Fri, 17 Jul 2020 00:23:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=toetHW9zEzxVyZqTJqQEnEoaPerHCeR2/9ldGUYNx+Q=; b=nTNAbEjAA65U9cAzN/Puq6EtftyY4yoXQaynCwwgibVc7F0TYZGY0LWdFYOUkpu6+K q3ogl9Jyy/JomOvV1K4kk9L+2ZlylrNHzt+etJjnvEgpsPFJBis7TMijrrTo4+p75m/J vCyc1EsZl67q9Rx+sevE5r61W6SHzu1kOiaNSVcThA3Fej31YQaKz3lAHfwHf8ii+g3u ERkYUT8HAqwTociF0q1qJaqX/fJwKMeZEZ6AXph+MAG6QCiZfHrMWyqbYqltM85ZBJAE Ck3Cg5qZdUSaT8xWDECAiFCpYok9DUMw9u3C74oS6CeK8N0+pP3BumHIV6pwb8p/kmYE CRjw== X-Gm-Message-State: AOAM5306LwOpolmGCGkRqNGvhu5A8fhzQbMV0waWlqtS0Tp9Sx079VzQ /5lx/MpwzXa+iNqqI4wCEES7CaYD/Epd/c+4vFUVUv8Ryko= X-Google-Smtp-Source: ABdhPJy3R0Xef0vdj/V+3wBCm3YS6VKSP0J9YbgShVGjluSw2qQ9/LSA00RLsp1Shw5fLlwq9v5qZJ47kylL0OJtTSY= X-Received: by 2002:a67:d01a:: with SMTP id r26mr6171482vsi.200.1594970627352; Fri, 17 Jul 2020 00:23:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hongtao Liu Date: Fri, 17 Jul 2020 15:24:05 +0800 Message-ID: Subject: Re: [PATCH] [AVX512] [PR87767] Optimize memory broadcast for constant vector under AVX512 To: GCC Patches , kirill.yukhin@gmail.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 07:23:49 -0000 ping! On Fri, Jul 10, 2020 at 5:24 PM Hongtao Liu wrote: > > + maintainer. > cc H.J > > On Thu, Jul 9, 2020 at 4:33 PM Hongtao Liu wrote: > > > > Hi: > > For a constant vector having one duplicated value, there's no need > > to put the whole vector in the constant pool, using embedded broadcast > > instead. > > > > Bootstrap test is Ok, regression test for i386/x86-64 backend is ok. > > > > gcc/ChangeLog: > > > > PR target/87767 > > * config/i386/i386-features.c > > (replace_constant_pool_with_broadcast): New function. > > (constant_pool_broadcast): Ditto. > > (class pass_constant_pool_broadcast): New pass. > > (make_pass_constant_pool_broadcast): Ditto. > > * config/i386/i386-passes.def: Insert new pass after combine. > > * config/i386/i386-protos.h > > (make_pass_constant_pool_broadcast): Declare. > > * config/i386/sse.md (*avx512dq_mul3_bcst, > > *avx512f_mul3_bcst): New define_insn. > > > > gcc/testsuite/ChangeLog: > > > > PR target/87767 > > * gcc.target/i386/avx2-broadcast-pr87767-1.c: New test. > > * gcc.target/i386/avx512f-broadcast-pr87767-1.c: New test. > > * gcc.target/i386/avx512f-broadcast-pr87767-2.c: New test. > > * gcc.target/i386/avx512vl-broadcast-pr87767-1.c: New test. > > * gcc.target/i386/pr92865-1.c: Adjust testcase. > > > > > > > > > > -- > > BR, > > Hongtao > > > > -- > BR, > Hongtao -- BR, Hongtao